feat(crashtracking): Don't send dd properties they should be avialable via telemetry

Author: bric3

dd-java-agent/agent-crashtracking/src/main/java/datadog/crashtracking/parsers/RuntimeArgs.java

@@ -14,8 +14,8 @@
  *   <li>pre-split J9 user arguments, such as individual {@code 2CIUSERARG} records
  * </ul>
  *
- * <p>Only a curated subset of arguments is retained for telemetry: {@code -Ddd.*}, {@code -Djdk.*},
- * {@code -Djava.*}, {@code -Dsun.*}, {@code -javaagent:}, {@code -agentlib:}, {@code -X*}, and
+ * <p>Only a curated subset of arguments is retained for telemetry: {@code -Djdk.*}, {@code
+ * -Djava.*}, {@code -Dsun.*}, {@code -javaagent:}, {@code -agentlib:}, {@code -X*}, and
  * module/native-access options.
  */
 final class RuntimeArgs {
@@ -89,7 +89,7 @@ private static boolean isAllowedSystemProperty(String arg) {
     if (hasSecretLikePropertyName(arg)) {
       return false;
     }
-    if (arg.startsWith("-Ddd.") || arg.startsWith("-Djdk.") || arg.startsWith("-Dosgi.")) {
+    if (arg.startsWith("-Djdk.") || arg.startsWith("-Dosgi.")) {
       return true;
     }
     // J9 lists them as vm args.

dd-java-agent/agent-crashtracking/src/test/java/datadog/crashtracking/parsers/RuntimeArgsTest.java

@@ -19,11 +19,11 @@ public class RuntimeArgsTest {
   @TableTest({
     "scenario                            | resource                           | isIncluded | vmArg                                                                                        ",
     "telemetry fixture logging property  | sample-crash-for-telemetry.txt     | true       | -Djava.util.logging.config.file=/opt/REDACT_THIS/REDACT_THIS/etc/java.util.logging.properties",
-    "telemetry fixture dd property       | sample-crash-for-telemetry.txt     | true       | -Ddd.profiling.enabled=true                                                                  ",
+    "telemetry fixture dd property       | sample-crash-for-telemetry.txt     | false      | -Ddd.profiling.enabled=true                                                                  ",
     "telemetry fixture excluded property | sample-crash-for-telemetry.txt     | false      | -Dkaraf.startRemoteShell=REDACT_THIS                                                         ",
     "telemetry fixture ws provider       | sample-crash-for-telemetry.txt     | false      | -Djavax.xml.ws.spi.Provider=com.sun.xml.ws.spi.ProviderImpl                                  ",
     "telemetry with OnError              | sample-crash-for-telemetry-2.txt   | true       | -XX:OnError=/tmp/dd_crash_uploader.sh %p                                                     ",
-    "telemetry jdk8                      | sample-crash-for-telemetry-3.txt   | true       | -Ddd.trace.enabled=false                                                                     ",
+    "telemetry jdk8                      | sample-crash-for-telemetry-3.txt   | false      | -Ddd.trace.enabled=false                                                                     ",
     "linux aarch64                       | sample-crash-linux-aarch64.txt     | true       | --add-modules=ALL-DEFAULT                                                                    ",
     "macos aarch64                       | sample-crash-macos-aarch64.txt     | true       | --enable-native-access=ALL-UNNAMED                                                           ",
     "jdk8 zip                            | sample-crash-jdk8-zip-getentry.txt | true       | -Dsun.zip.disableMemoryMapping=false                                                         "
@@ -62,6 +62,8 @@ public void testParseVmArgsHandlesArgNormalization(String raw, String expectedIn
     "scenario                     | raw                                                | isIncluded | vmArg                                             ",
     "jaas login config excluded   | -Djava.security.auth.login.config=/etc/jaas.conf   | false      | -Djava.security.auth.login.config=/etc/jaas.conf  ",
     "java socks password excluded | -Djava.net.socks.password=hunter2                  | false      | -Djava.net.socks.password=hunter2                 ",
+    "dd service excluded          | -Ddd.service=myapp                                 | false      | -Ddd.service=myapp                                ",
+    "dd trace enabled excluded    | -Ddd.trace.enabled=true                            | false      | -Ddd.trace.enabled=true                           ",
     "dd pwd excluded              | -Ddd.db.pwd=hunter2                                | false      | -Ddd.db.pwd=hunter2                               ",
     "dd passphrase excluded       | -Ddd.ssl.passphrase=topsecret                      | false      | -Ddd.ssl.passphrase=topsecret                     ",
     "dd api key excluded          | -Ddd.api-key=deadbeef                              | false      | -Ddd.api-key=deadbeef                             ",
@@ -85,7 +87,7 @@ public void testParseVmArgsExcludesSecretLikeSystemProperties(
   @TableTest({
     "scenario                    | resource                                | isIncluded | vmArg                                                                                                                                      ",
     "truncated ibmj9 optionsfile | redacted-truncated-ibmj9-8-javacore.txt | true       | -Xoptionsfile=/opt/REDACTED/java/8.0/jre/lib/ppc64/compressedrefs/options.default                                                          ",
-    "truncated ibmj9 dd arg      | redacted-truncated-ibmj9-8-javacore.txt | true       | -Ddd.service=REDACTED                                                                                                                      ",
+    "truncated ibmj9 dd arg      | redacted-truncated-ibmj9-8-javacore.txt | false      | -Ddd.service=REDACTED                                                                                                                      ",
     "truncated ibmj9 osgi arg    | redacted-truncated-ibmj9-8-javacore.txt | true       | -Dosgi.install.area=/opt/REDACTED                                                                                                          ",
     "truncated ibmj9 status arg  | redacted-truncated-ibmj9-8-javacore.txt | false      | -Dwas.status.socket=REDACTED                                                                                                               ",
     "truncated ibmj9 xtq arg     | redacted-truncated-ibmj9-8-javacore.txt | false      | -Dcom.ibm.xtq.processor.overrideSecureProcessing=true                                                                                      ",