fix(openfeature): return PARSE_ERROR for invalid regex in flag condition (#11071)

fix(openfeature): return PARSE_ERROR for invalid regex in flag condition

test(openfeature): add NOT_MATCHES invalid-regex test and fix comment

- Add test case for NOT_MATCHES with invalid regex pattern, which follows
  the same PatternSyntaxException propagation path as MATCHES
- Fix misleading comment on integer-string-variant-flag test case to
  accurately describe the PARSE_ERROR trigger (unparseable variant value)

Merge remote-tracking branch 'origin/master' into typo/parse-error-regex

Merge remote-tracking branch 'origin/master' into typo/parse-error-regex

Co-authored-by: devflow.devflow-routing-intake <devflow.devflow-routing-intake@kubernetes.us1.ddbuild.io>

Author: typotter

products/feature-flagging/feature-flagging-api/src/main/java/datadog/trace/api/openfeature/DDEvaluator.java

@@ -39,6 +39,7 @@
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.atomic.AtomicReference;
 import java.util.regex.Pattern;
+import java.util.regex.PatternSyntaxException;
 
 class DDEvaluator implements Evaluator, FeatureFlaggingGateway.ConfigListener {
 
@@ -155,6 +156,8 @@ public <T> ProviderEvaluation<T> evaluate(
           .value(defaultValue)
           .reason(Reason.DEFAULT.name())
           .build();
+    } catch (final PatternSyntaxException e) {
+      return error(defaultValue, ErrorCode.PARSE_ERROR, e);
     } catch (final NumberFormatException e) {
       return error(defaultValue, ErrorCode.TYPE_MISMATCH, e);
     } catch (final Exception e) {
@@ -258,12 +261,10 @@ private static boolean evaluateCondition(
   }
 
   private static boolean matchesRegex(final Object attributeValue, final Object conditionValue) {
-    try {
-      final Pattern pattern = Pattern.compile(String.valueOf(conditionValue));
-      return pattern.matcher(String.valueOf(attributeValue)).find();
-    } catch (Exception e) {
-      return false;
-    }
+    // PatternSyntaxException is intentionally not caught here so it propagates to evaluate(),
+    // which maps it to ErrorCode.PARSE_ERROR.
+    final Pattern pattern = Pattern.compile(String.valueOf(conditionValue));
+    return pattern.matcher(String.valueOf(attributeValue)).find();
   }
 
   private static boolean isOneOf(final Object attributeValue, final Object conditionValue) {

products/feature-flagging/feature-flagging-api/src/test/java/datadog/trace/api/openfeature/DDEvaluatorTest.java

@@ -316,7 +316,8 @@ private static List<TestCase<?>> evaluateTestCases() {
             .flag("integer-flag")
             .targetingKey("user-123")
             .result(new Result<>(0.0).reason(ERROR.name()).errorCode(ErrorCode.TYPE_MISMATCH)),
-        // Variant value type mismatch: INTEGER flag with string variant value
+        // Variant stores "not-a-number" for an INTEGER flag; Double.parseDouble fails ->
+        // PARSE_ERROR
         new TestCase<>(0)
             .flag("integer-string-variant-flag")
             .targetingKey("user-123")
@@ -490,7 +491,17 @@ private static List<TestCase<?>> evaluateTestCases() {
             .result(
                 new Result<>("null-handled")
                     .reason(TARGETING_MATCH.name())
-                    .variant("null-variant")));
+                    .variant("null-variant")),
+        new TestCase<>("default")
+            .flag("invalid-regex-flag")
+            .targetingKey("user-123")
+            .context("email", "user@example.com")
+            .result(new Result<>("default").reason(ERROR.name()).errorCode(ErrorCode.PARSE_ERROR)),
+        new TestCase<>("default")
+            .flag("invalid-regex-not-matches-flag")
+            .targetingKey("user-123")
+            .context("email", "user@example.com")
+            .result(new Result<>("default").reason(ERROR.name()).errorCode(ErrorCode.PARSE_ERROR)));
   }
 
   @MethodSource("evaluateTestCases")
@@ -582,6 +593,8 @@ private ServerConfiguration createTestConfiguration() {
     flags.put(
         "integer-string-variant-flag",
         createSimpleFlag("integer-string-variant-flag", ValueType.INTEGER, "not-a-number", "bad"));
+    flags.put("invalid-regex-flag", createInvalidRegexFlag());
+    flags.put("invalid-regex-not-matches-flag", createInvalidRegexNotMatchesFlag());
     return new ServerConfiguration(null, null, null, flags);
   }
 
@@ -1267,6 +1280,43 @@ private Flag createCountryRuleFlag() {
         asList(usAllocation, globalAllocation));
   }
 
+  private Flag createInvalidRegexFlag() {
+    final Map<String, Variant> variants = new HashMap<>();
+    variants.put("matched", new Variant("matched", "matched-value"));
+
+    // Condition with an intentionally invalid regex pattern (unclosed bracket)
+    final List<ConditionConfiguration> conditions =
+        singletonList(new ConditionConfiguration(ConditionOperator.MATCHES, "email", "[invalid"));
+    final List<Rule> rules = singletonList(new Rule(conditions));
+    final List<Split> splits = singletonList(new Split(emptyList(), "matched", null));
+    final Allocation allocation =
+        new Allocation("invalid-regex-alloc", rules, null, null, splits, false);
+
+    return new Flag(
+        "invalid-regex-flag", true, ValueType.STRING, variants, singletonList(allocation));
+  }
+
+  private Flag createInvalidRegexNotMatchesFlag() {
+    final Map<String, Variant> variants = new HashMap<>();
+    variants.put("excluded", new Variant("excluded", "excluded-value"));
+
+    // Condition with an intentionally invalid regex pattern (unclosed bracket) under NOT_MATCHES
+    final List<ConditionConfiguration> conditions =
+        singletonList(
+            new ConditionConfiguration(ConditionOperator.NOT_MATCHES, "email", "[invalid"));
+    final List<Rule> rules = singletonList(new Rule(conditions));
+    final List<Split> splits = singletonList(new Split(emptyList(), "excluded", null));
+    final Allocation allocation =
+        new Allocation("invalid-regex-not-matches-alloc", rules, null, null, splits, false);
+
+    return new Flag(
+        "invalid-regex-not-matches-flag",
+        true,
+        ValueType.STRING,
+        variants,
+        singletonList(allocation));
+  }
+
   private static Map<String, Object> mapOf(final Object... props) {
     final Map<String, Object> result = new HashMap<>(props.length << 1);
     int index = 0;