Skip to content

Commit cd5bbe1

Browse files
authored
Use quotes for system tests refs (#10998)
Use quotes for system tests refs Co-authored-by: sarah.chen <sarah.chen@datadoghq.com>
1 parent 50402e3 commit cd5bbe1

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

.github/workflows/run-system-tests.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ jobs:
7272
with:
7373
library: java
7474
# If you change the following comment, update the pattern in the update_system_test_reference.sh script to match.
75-
ref: main # system tests are pinned on release branches only
75+
ref: "main" # system tests are pinned on release branches only
7676
binaries_artifact: binaries
7777
desired_execution_time: 900 # 15 minutes
7878
scenarios_groups: tracer-release

.gitlab-ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1071,7 +1071,7 @@ publishing-gate:
10711071

10721072
configure_system_tests:
10731073
variables:
1074-
SYSTEM_TESTS_REF: main # system tests are pinned on release branches only
1074+
SYSTEM_TESTS_REF: "main" # system tests are pinned on release branches only
10751075
SYSTEM_TESTS_SCENARIOS_GROUPS: "simple_onboarding,simple_onboarding_profiling,simple_onboarding_appsec,docker-ssi,lib-injection"
10761076

10771077
create_key:

tooling/update_system_test_reference.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ fi
1414
GITHUB_TARGET=".github/workflows/run-system-tests.yaml"
1515
GITLAB_TARGET=".gitlab-ci.yml"
1616
GITHUB_PATTERN_1='(\s*system-tests\.yml@)(\S+)(\s+# system tests.*)' # pattern to update the "system-tests.yml@" reference
17-
GITHUB_PATTERN_2='(\s*ref: )(\S+)(\s+# system tests.*)' # pattern to update the "ref:" reference
18-
GITLAB_PATTERN='(\s*SYSTEM_TESTS_REF:\s*)(\S+)(\s+# system tests.*)' # pattern to update the GitLab SYSTEM_TESTS_REF variable
17+
GITHUB_PATTERN_2='(\s*ref: ")([^"]+)("\s+# system tests.*)' # pattern to update the quoted "ref:" reference
18+
GITLAB_PATTERN='(\s*SYSTEM_TESTS_REF: ")([^"]+)("\s+# system tests.*)' # pattern to update the quoted GitLab SYSTEM_TESTS_REF variable
1919

2020
echo "Fetching latest commit SHA for system-tests branch: $BRANCH"
2121
REF=$(git ls-remote https://github.com/DataDog/system-tests "refs/heads/$BRANCH" | cut -f 1)

0 commit comments

Comments
 (0)