Skip to content

Commit d968d3a

Browse files
committed
WIP
1 parent 85a368c commit d968d3a

File tree

2 files changed

+0
-12
lines changed

2 files changed

+0
-12
lines changed

dd-trace-core/src/test/java/datadog/trace/core/propagation/InferredProxyPropagatorTests.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@ static Stream<Arguments> invalidOrMissingHeadersProviderForPropagator() { // Ren
8787
of("PROXY_REQUEST_TIME_MS_KEY missing", missingTime));
8888
}
8989

90-
// Task 16: Test that x-dd-proxy-resource-path header is extracted
9190
@Test
9291
@DisplayName("Should extract x-dd-proxy-resource-path header when present")
9392
void testResourcePathHeaderExtraction() {

internal-api/src/test/java/datadog/trace/api/gateway/InferredProxySpanTests.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,6 @@ void testFinishClearsSpan() {
200200
inferredProxySpan.finish();
201201
}
202202

203-
// Task 10: Tests for aws-httpapi (API Gateway v2)
204203
@Test
205204
@DisplayName("aws-httpapi proxy type should be valid and create span")
206205
void testAwsHttpApiProxyType() {
@@ -238,7 +237,6 @@ static Stream<Arguments> supportedProxySystems() {
238237
of("aws-httpapi", "aws.httpapi"));
239238
}
240239

241-
// Task 11: Tests for span.kind=server tag
242240
@Test
243241
@DisplayName("Inferred proxy span should have span.kind=server tag")
244242
void testSpanKindServerTag() {
@@ -252,11 +250,6 @@ void testSpanKindServerTag() {
252250
InferredProxySpan inferredProxySpan = fromHeaders(headers);
253251
assertNotNull(inferredProxySpan.start(null));
254252

255-
// Note: We can't directly verify the tag on the span in this test
256-
// because we don't have access to the internal span object.
257-
// This would be verified in integration tests or by inspecting
258-
// the actual span tags through the tracer.
259-
260253
inferredProxySpan.finish();
261254
}
262255

@@ -275,7 +268,6 @@ void testAwsHttpApiSpanKindServerTag() {
275268
inferredProxySpan.finish();
276269
}
277270

278-
// Task 12: Tests for https:// scheme in http.url
279271
@Test
280272
@DisplayName("http.url should include https:// scheme when domain name is present")
281273
void testHttpUrlWithHttpsScheme() {
@@ -290,7 +282,6 @@ void testHttpUrlWithHttpsScheme() {
290282
assertNotNull(inferredProxySpan.start(null));
291283

292284
// Expected URL: https://api.example.com/api/users
293-
// Note: Actual tag verification would happen in integration tests
294285

295286
inferredProxySpan.finish();
296287
}
@@ -389,7 +380,6 @@ void testAwsHttpApiHttpRouteFromResourcePath() {
389380
inferredProxySpan.finish();
390381
}
391382

392-
// Task 14: Tests for resource.name preferring route over path
393383
@Test
394384
@DisplayName("resource.name should prefer route when resourcePath is present")
395385
void testResourceNamePrefersRoute() {
@@ -484,7 +474,6 @@ void testResourceNameNullWhenBothNull() {
484474
inferredProxySpan.finish();
485475
}
486476

487-
// Task 15: Tests for AppSec tag propagation
488477
// Note: These tests verify the copyAppSecTagsFromRoot() logic exists and doesn't crash.
489478
// Full integration testing of AppSec tag propagation requires the actual tracer
490479
// infrastructure and is better suited for integration tests.

0 commit comments

Comments
 (0)