Fix clone_synchronizedSet to clone the synchronized set (not the plain one)

dougqh · claude · dougqh · commit e1a6de340c66 · 2026-06-24T13:52:11.000-04:00
Per Codex review: it copied `hashSet`, unlike the other clone_* methods which
copy their own structure. Copy `synchronizedSet` so it faithfully measures
cloning the synchronized variant.

Co-Authored-By: Claude Opus 4.8 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/internal-api/src/jmh/java/datadog/trace/util/SingleThreadedSetBenchmark.java b/internal-api/src/jmh/java/datadog/trace/util/SingleThreadedSetBenchmark.java
@@ -153,7 +153,7 @@ public Set<String> clone_hashSet() {
 
   @Benchmark
   public Set<String> clone_synchronizedSet() {
-    return Collections.synchronizedSet(new HashSet<>(hashSet));
+    return Collections.synchronizedSet(new HashSet<>(synchronizedSet));
   }
 
   @Benchmark

Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,7 @@ public Set<String> clone_hashSet() {`
`153`	`153`
`154`	`154`	`@Benchmark`
`155`	`155`	`public Set<String> clone_synchronizedSet() {`
`156`		`- return Collections.synchronizedSet(new HashSet<>(hashSet));`
	`156`	`+ return Collections.synchronizedSet(new HashSet<>(synchronizedSet));`
`157`	`157`	`}`
`158`	`158`
`159`	`159`	`@Benchmark`