Skip to content

Commit f01b7c3

Browse files
committed
fix(ci): Remove broken packageSources task
This tasks create "-sources.jar" like the `withSourcesJar()` from Java gradle plugin (source: https://docs.gradle.org/current/kotlin-dsl/gradle/org.gradle.api.plugins/-java-plugin-extension/with-sources-jar.html) The artifact produced by the "packageSources" tasks were overridden by the Java plugin ones at every build and broke the build cache. I checked the artifact that should be produced by the "packageSources" task are the same (in size and in file count) that the ones the Java plugin builds. You should be able to safely remove the task without trying to fix it.
1 parent 8c1f7d8 commit f01b7c3

File tree

4 files changed

+0
-18
lines changed

4 files changed

+0
-18
lines changed

dd-java-agent/agent-tooling/build.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ configurations {
3535
}
3636

3737
compileJava.dependsOn 'generateClassNameTries'
38-
packageSources.dependsOn 'generateClassNameTries'
3938
sourcesJar.dependsOn 'generateClassNameTries'
4039

4140
dependencies {

dd-java-agent/instrumentation/iast-instrumenter/build.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ apply from: "${rootDir}/gradle/tries.gradle"
1010
addTestSuiteForDir('latestDepTest', 'test')
1111

1212
compileJava.dependsOn 'generateClassNameTries'
13-
packageSources.dependsOn 'generateClassNameTries'
1413
sourcesJar.dependsOn 'generateClassNameTries'
1514

1615

dd-smoke-tests/springboot-tomcat/build.gradle

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -67,10 +67,6 @@ dependencies {
6767
testImplementation project(':dd-smoke-tests')
6868
}
6969

70-
tasks.packageSources {
71-
dependsOn 'unzip'
72-
}
73-
7470
tasks.sourcesJar {
7571
dependsOn 'unzip'
7672
}
@@ -95,10 +91,6 @@ tasks.javadocJar{
9591
dependsOn 'unzip'
9692
}
9793

98-
tasks.packageSources{
99-
dependsOn 'unzip'
100-
}
101-
10294
tasks.sourcesJar{
10395
dependsOn 'unzip'
10496
}

gradle/java_no_deps.gradle

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -101,15 +101,7 @@ jar {
101101
Instead we should 'fail early' and avoid building such Jars.
102102
*/
103103
duplicatesStrategy = 'fail'
104-
}
105-
106-
tasks.register("packageSources", Jar) {
107-
archiveClassifier = 'sources'
108-
from sourceSets.main.allSource
109-
}
110-
artifacts.archives packageSources
111104

112-
jar {
113105
manifest {
114106
attributes(
115107
"Implementation-Title": project.name,

0 commit comments

Comments
 (0)