Commit f2ad8aa
Fix platform-dependent String.getBytes() calls to use explicit UTF-8 charset
Specify StandardCharsets.UTF_8 in String.getBytes() calls used with
MessageDigest and other encoding-sensitive APIs. Without an explicit
charset, getBytes() uses the platform's default charset, which can
vary across systems and produce inconsistent results.
Files changed:
- AppSecEventTracker: user ID anonymization hash now uses UTF-8,
ensuring consistent hashing across all platforms. Also resolved
the TODO about MessageDigest caching with a clarifying comment
referencing micro-benchmark data showing negligible overhead.
- Fingerprinter: exception fingerprint hashes now use UTF-8.
- JsonStreamParser: JSON byte conversion now uses UTF-8 (JSON spec).
- LLMObsSpanMapper: writeUTF8() now receives actual UTF-8 bytes.1 parent c13e821 commit f2ad8aa
4 files changed
Lines changed: 14 additions & 5 deletions
File tree
- dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/exception
- dd-trace-core/src/main/java/datadog/trace
- core/util
- llmobs/writer/ddintake
- internal-api/src/main/java/datadog/trace/api/appsec
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
6 | 7 | | |
7 | 8 | | |
8 | 9 | | |
| |||
30 | 31 | | |
31 | 32 | | |
32 | 33 | | |
33 | | - | |
| 34 | + | |
34 | 35 | | |
35 | 36 | | |
36 | 37 | | |
| |||
40 | 41 | | |
41 | 42 | | |
42 | 43 | | |
| 44 | + | |
43 | 45 | | |
44 | 46 | | |
45 | 47 | | |
46 | 48 | | |
47 | 49 | | |
48 | 50 | | |
49 | 51 | | |
50 | | - | |
| 52 | + | |
51 | 53 | | |
52 | 54 | | |
53 | 55 | | |
| |||
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| |||
60 | 61 | | |
61 | 62 | | |
62 | 63 | | |
63 | | - | |
| 64 | + | |
64 | 65 | | |
65 | 66 | | |
66 | 67 | | |
| |||
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
311 | 311 | | |
312 | 312 | | |
313 | 313 | | |
| 314 | + | |
314 | 315 | | |
315 | 316 | | |
316 | 317 | | |
| |||
331 | 332 | | |
332 | 333 | | |
333 | 334 | | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
334 | 338 | | |
335 | 339 | | |
336 | 340 | | |
| |||
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
| 39 | + | |
39 | 40 | | |
40 | 41 | | |
41 | 42 | | |
| |||
374 | 375 | | |
375 | 376 | | |
376 | 377 | | |
377 | | - | |
| 378 | + | |
| 379 | + | |
378 | 380 | | |
379 | 381 | | |
380 | 382 | | |
381 | 383 | | |
382 | | - | |
| 384 | + | |
383 | 385 | | |
384 | 386 | | |
385 | 387 | | |
| |||
0 commit comments