Skip to content

Commit f452dff

Browse files
Add logging utility module (#10879)
feat(logging): Create dedicated module for logging utils feat(logging): Migrate unit tests to JUnit feat(logging): Migrate to logging-utils module feat(debugger): Order dependencies feat(logging): Improve migrated tests fix(logging): Fix duplicate classes Co-authored-by: bruce.bujon <bruce.bujon@datadoghq.com>
1 parent c51637a commit f452dff

File tree

47 files changed

+401
-382
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

47 files changed

+401
-382
lines changed

dd-java-agent/agent-debugger/build.gradle

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -32,20 +32,21 @@ excludedClassesCoverage += [
3232

3333
dependencies {
3434
// main dependencies
35-
implementation project(':utils:container-utils')
36-
implementation libs.slf4j
37-
implementation libs.bundles.asm
38-
implementation project(':internal-api')
39-
implementation project(':communication')
40-
implementation project(':products:metrics:metrics-lib')
41-
compileOnly project(':dd-java-agent:agent-tooling')
4235
compileOnly project(':dd-java-agent:agent-builder')
36+
compileOnly project(':dd-java-agent:agent-tooling')
4337
compileOnly project(':dd-trace-core')
44-
implementation project(':dd-java-agent:agent-debugger:debugger-el')
38+
implementation project(':communication')
4539
implementation project(':dd-java-agent:agent-debugger:debugger-bootstrap')
46-
implementation libs.okhttp
40+
implementation project(':dd-java-agent:agent-debugger:debugger-el')
41+
implementation project(':internal-api')
42+
implementation project(':products:metrics:metrics-lib')
43+
implementation project(':utils:container-utils')
44+
implementation project(':utils:logging-utils')
45+
implementation libs.bundles.asm
4746
implementation libs.dogstatsd
4847
implementation libs.moshi
48+
implementation libs.okhttp
49+
implementation libs.slf4j
4950

5051
testImplementation libs.asm.util
5152
testImplementation libs.bundles.junit5

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/agent/ConfigurationUpdater.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@
1414
import com.datadog.debugger.util.ExceptionHelper;
1515
import com.datadog.debugger.util.SpringHelper;
1616
import datadog.environment.JavaVirtualMachine;
17+
import datadog.logging.RatelimitedLogger;
1718
import datadog.trace.api.Config;
1819
import datadog.trace.bootstrap.debugger.DebuggerContext;
1920
import datadog.trace.bootstrap.debugger.ProbeId;
2021
import datadog.trace.bootstrap.debugger.ProbeImplementation;
2122
import datadog.trace.bootstrap.debugger.ProbeRateLimiter;
22-
import datadog.trace.relocate.api.RatelimitedLogger;
2323
import datadog.trace.util.TagsHelper;
2424
import java.lang.annotation.Annotation;
2525
import java.lang.annotation.ElementType;

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/sink/ProbeStatusSink.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@
1010
import com.datadog.debugger.util.ExceptionHelper;
1111
import com.datadog.debugger.util.MoshiHelper;
1212
import com.squareup.moshi.JsonAdapter;
13+
import datadog.logging.RatelimitedLogger;
1314
import datadog.trace.api.Config;
1415
import datadog.trace.bootstrap.debugger.ProbeId;
15-
import datadog.trace.relocate.api.RatelimitedLogger;
1616
import java.time.Clock;
1717
import java.time.Duration;
1818
import java.time.Instant;

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/uploader/BatchUploader.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
import com.datadog.debugger.util.DebuggerMetrics;
66
import datadog.common.container.ContainerInfo;
77
import datadog.communication.http.OkHttpUtils;
8+
import datadog.logging.RatelimitedLogger;
89
import datadog.trace.api.Config;
9-
import datadog.trace.relocate.api.RatelimitedLogger;
1010
import datadog.trace.util.AgentThreadFactory;
1111
import java.io.IOException;
1212
import java.time.Duration;

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/util/ExceptionHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.datadog.debugger.util;
22

3-
import datadog.trace.relocate.api.RatelimitedLogger;
3+
import datadog.logging.RatelimitedLogger;
44
import java.io.PrintWriter;
55
import java.io.StringWriter;
66
import java.io.Writer;

dd-java-agent/agent-debugger/src/test/java/com/datadog/debugger/uploader/BatchUploaderTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
import static org.mockito.Mockito.verify;
1313
import static org.mockito.Mockito.when;
1414

15+
import datadog.logging.RatelimitedLogger;
1516
import datadog.trace.api.Config;
16-
import datadog.trace.relocate.api.RatelimitedLogger;
1717
import java.io.IOException;
1818
import java.net.ConnectException;
1919
import java.net.ServerSocket;

dd-java-agent/agent-debugger/src/test/java/com/datadog/debugger/util/ExceptionHelperTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
import static org.mockito.Mockito.doAnswer;
88
import static org.mockito.Mockito.when;
99

10-
import datadog.trace.relocate.api.RatelimitedLogger;
10+
import datadog.logging.RatelimitedLogger;
1111
import java.util.ArrayDeque;
1212
import java.util.Deque;
1313
import org.junit.jupiter.api.Test;

dd-java-agent/agent-otel/otel-bootstrap/build.gradle

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,8 @@ dependencies {
7373
embeddedClasspath group: 'io.opentelemetry.javaagent.instrumentation', name: 'opentelemetry-javaagent-servlet-common-bootstrap', version: "$otelInstrumentationApiVersion-alpha"
7474

7575
compileOnly project(':dd-java-agent:agent-bootstrap')
76+
77+
implementation project(':utils:logging-utils')
7678
}
7779

7880
tasks.named("shadowJar", ShadowJar) {

dd-java-agent/agent-otel/otel-bootstrap/src/main/java/datadog/trace/bootstrap/otel/metrics/data/OtelMetricStorage.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
package datadog.trace.bootstrap.otel.metrics.data;
22

3+
import datadog.logging.RatelimitedLogger;
34
import datadog.trace.api.Config;
45
import datadog.trace.api.config.OtlpConfig;
56
import datadog.trace.bootstrap.instrumentation.api.UTF8BytesString;
67
import datadog.trace.bootstrap.otel.metrics.OtelInstrumentDescriptor;
78
import datadog.trace.bootstrap.otel.metrics.OtelInstrumentType;
89
import datadog.trace.bootstrap.otel.metrics.export.OtelMetricVisitor;
9-
import datadog.trace.relocate.api.RatelimitedLogger;
1010
import io.opentelemetry.api.common.Attributes;
1111
import java.util.List;
1212
import java.util.Map;

dd-java-agent/agent-otel/otel-shim/build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,5 @@ dependencies {
1010

1111
implementation project(':products:metrics:metrics-api')
1212
implementation project(':internal-api')
13+
implementation project(':utils:logging-utils')
1314
}

0 commit comments

Comments
 (0)