Commit f8163c2
committed
Add supportsMultipart() hook to skip multipart test on Jetty 9.0.x
Spock AST-transforms feature methods, so @OverRide on a feature method
override triggers a compile error. Use a boolean hook instead:
- AppSecInactiveHttpServerTest.supportsMultipart() returns true by default
and is guarded with assumeTrue() at the setup: block level
- Jetty9InactiveAppSecTest overrides to false in both jetty-server-9.0 and
jetty-server-9.0.4, where jetty-appsec-8.1.3 range [8.1.3, 9.2.0.RC0)
causes ParameterCollector.put(String, String) to fail → HTTP 500.
Verified locally: tests=8, skipped=3 (multipart correctly skipped), failures=0.1 parent 05a5ec4 commit f8163c2
3 files changed
Lines changed: 9 additions & 10 deletions
File tree
- dd-java-agent
- appsec/appsec-test-fixtures/src/main/groovy/com/datadog/appsec
- instrumentation/jetty/jetty-server
- jetty-server-9.0.4/src/test/groovy/datadog/trace/instrumentation/jetty9
- jetty-server-9.0/src/test/groovy/datadog/trace/instrumentation/jetty9
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
139 | 139 | | |
140 | 140 | | |
141 | 141 | | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
142 | 146 | | |
143 | 147 | | |
| 148 | + | |
144 | 149 | | |
145 | 150 | | |
146 | 151 | | |
| |||
Lines changed: 2 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | 5 | | |
7 | 6 | | |
8 | 7 | | |
| |||
14 | 13 | | |
15 | 14 | | |
16 | 15 | | |
17 | | - | |
18 | 16 | | |
19 | | - | |
20 | | - | |
21 | | - | |
| 17 | + | |
| 18 | + | |
22 | 19 | | |
23 | 20 | | |
Lines changed: 2 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | 5 | | |
7 | 6 | | |
8 | 7 | | |
| |||
14 | 13 | | |
15 | 14 | | |
16 | 15 | | |
17 | | - | |
18 | 16 | | |
19 | | - | |
20 | | - | |
21 | | - | |
| 17 | + | |
| 18 | + | |
22 | 19 | | |
23 | 20 | | |
0 commit comments