Separate context tracking from tracing on http client instrumentations#10782
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~b1dbb3061b, baseline=1.61.0-SNAPSHOT~3275dcc717
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1056074
Total [baseline] (11.016 s) : 0, 11016352
Agent [candidate] (1.057 s) : 0, 1057023
Total [candidate] (10.976 s) : 0, 10976206
section appsec
Agent [baseline] (1.246 s) : 0, 1246358
Total [baseline] (11.183 s) : 0, 11182960
Agent [candidate] (1.24 s) : 0, 1239896
Total [candidate] (11.207 s) : 0, 11207082
section iast
Agent [baseline] (1.224 s) : 0, 1224182
Total [baseline] (11.319 s) : 0, 11319049
Agent [candidate] (1.223 s) : 0, 1223315
Total [candidate] (11.367 s) : 0, 11367454
section profiling
Agent [baseline] (1.179 s) : 0, 1179354
Total [baseline] (11.021 s) : 0, 11021302
Agent [candidate] (1.185 s) : 0, 1185055
Total [candidate] (10.972 s) : 0, 10971612
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~b1dbb3061b, baseline=1.61.0-SNAPSHOT~3275dcc717
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (626.812 ms) : 0, 626812
BytebuddyAgent [candidate] (627.335 ms) : 0, 627335
AgentMeter [baseline] (28.965 ms) : 0, 28965
AgentMeter [candidate] (29.036 ms) : 0, 29036
GlobalTracer [baseline] (255.982 ms) : 0, 255982
GlobalTracer [candidate] (256.488 ms) : 0, 256488
AppSec [baseline] (31.653 ms) : 0, 31653
AppSec [candidate] (31.682 ms) : 0, 31682
Debugger [baseline] (59.995 ms) : 0, 59995
Debugger [candidate] (60.4 ms) : 0, 60400
Remote Config [baseline] (579.683 µs) : 0, 580
Remote Config [candidate] (598.618 µs) : 0, 599
Telemetry [baseline] (7.958 ms) : 0, 7958
Telemetry [candidate] (7.939 ms) : 0, 7939
Flare Poller [baseline] (7.128 ms) : 0, 7128
Flare Poller [candidate] (6.477 ms) : 0, 6477
section appsec
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (658.27 ms) : 0, 658270
BytebuddyAgent [candidate] (654.65 ms) : 0, 654650
AgentMeter [baseline] (11.963 ms) : 0, 11963
AgentMeter [candidate] (11.92 ms) : 0, 11920
GlobalTracer [baseline] (257.655 ms) : 0, 257655
GlobalTracer [candidate] (256.234 ms) : 0, 256234
IAST [baseline] (24.289 ms) : 0, 24289
IAST [candidate] (24.079 ms) : 0, 24079
AppSec [baseline] (177.921 ms) : 0, 177921
AppSec [candidate] (177.067 ms) : 0, 177067
Debugger [baseline] (66.291 ms) : 0, 66291
Debugger [candidate] (66.228 ms) : 0, 66228
Remote Config [baseline] (605.761 µs) : 0, 606
Remote Config [candidate] (618.097 µs) : 0, 618
Telemetry [baseline] (8.303 ms) : 0, 8303
Telemetry [candidate] (8.247 ms) : 0, 8247
Flare Poller [baseline] (3.643 ms) : 0, 3643
Flare Poller [candidate] (3.616 ms) : 0, 3616
section iast
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (793.547 ms) : 0, 793547
BytebuddyAgent [candidate] (793.042 ms) : 0, 793042
AgentMeter [baseline] (11.329 ms) : 0, 11329
AgentMeter [candidate] (11.278 ms) : 0, 11278
GlobalTracer [baseline] (246.482 ms) : 0, 246482
GlobalTracer [candidate] (246.28 ms) : 0, 246280
IAST [baseline] (25.359 ms) : 0, 25359
IAST [candidate] (25.273 ms) : 0, 25273
AppSec [baseline] (26.521 ms) : 0, 26521
AppSec [candidate] (27.299 ms) : 0, 27299
Debugger [baseline] (70.519 ms) : 0, 70519
Debugger [candidate] (69.848 ms) : 0, 69848
Remote Config [baseline] (532.981 µs) : 0, 533
Remote Config [candidate] (528.759 µs) : 0, 529
Telemetry [baseline] (9.259 ms) : 0, 9259
Telemetry [candidate] (9.208 ms) : 0, 9208
Flare Poller [baseline] (3.39 ms) : 0, 3390
Flare Poller [candidate] (3.411 ms) : 0, 3411
section profiling
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.174 ms) : 0, 1174
BytebuddyAgent [baseline] (680.8 ms) : 0, 680800
BytebuddyAgent [candidate] (684.401 ms) : 0, 684401
AgentMeter [baseline] (8.595 ms) : 0, 8595
AgentMeter [candidate] (8.616 ms) : 0, 8616
GlobalTracer [baseline] (215.129 ms) : 0, 215129
GlobalTracer [candidate] (215.942 ms) : 0, 215942
AppSec [baseline] (32.203 ms) : 0, 32203
AppSec [candidate] (32.425 ms) : 0, 32425
Debugger [baseline] (64.424 ms) : 0, 64424
Debugger [candidate] (66.248 ms) : 0, 66248
Remote Config [baseline] (579.051 µs) : 0, 579
Remote Config [candidate] (571.557 µs) : 0, 572
Telemetry [baseline] (8.402 ms) : 0, 8402
Telemetry [candidate] (7.707 ms) : 0, 7707
Flare Poller [baseline] (4.238 ms) : 0, 4238
Flare Poller [candidate] (3.424 ms) : 0, 3424
ProfilingAgent [baseline] (93.194 ms) : 0, 93194
ProfilingAgent [candidate] (93.636 ms) : 0, 93636
Profiling [baseline] (93.758 ms) : 0, 93758
Profiling [candidate] (94.201 ms) : 0, 94201
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~b1dbb3061b, baseline=1.61.0-SNAPSHOT~3275dcc717
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1057422
Total [baseline] (8.847 s) : 0, 8846670
Agent [candidate] (1.059 s) : 0, 1059429
Total [candidate] (8.801 s) : 0, 8800592
section iast
Agent [baseline] (1.223 s) : 0, 1222767
Total [baseline] (9.535 s) : 0, 9534745
Agent [candidate] (1.225 s) : 0, 1224757
Total [candidate] (9.549 s) : 0, 9549336
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~b1dbb3061b, baseline=1.61.0-SNAPSHOT~3275dcc717
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (628.968 ms) : 0, 628968
BytebuddyAgent [candidate] (628.299 ms) : 0, 628299
AgentMeter [baseline] (29.073 ms) : 0, 29073
AgentMeter [candidate] (29.14 ms) : 0, 29140
GlobalTracer [baseline] (256.598 ms) : 0, 256598
GlobalTracer [candidate] (257.108 ms) : 0, 257108
AppSec [baseline] (31.744 ms) : 0, 31744
AppSec [candidate] (31.73 ms) : 0, 31730
Debugger [baseline] (59.509 ms) : 0, 59509
Debugger [candidate] (59.362 ms) : 0, 59362
Remote Config [baseline] (585.677 µs) : 0, 586
Remote Config [candidate] (593.103 µs) : 0, 593
Telemetry [baseline] (8.122 ms) : 0, 8122
Telemetry [candidate] (8.031 ms) : 0, 8031
Flare Poller [baseline] (5.691 ms) : 0, 5691
Flare Poller [candidate] (7.955 ms) : 0, 7955
section iast
crashtracking [baseline] (1.198 ms) : 0, 1198
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (793.109 ms) : 0, 793109
BytebuddyAgent [candidate] (795.381 ms) : 0, 795381
AgentMeter [baseline] (11.356 ms) : 0, 11356
AgentMeter [candidate] (11.294 ms) : 0, 11294
GlobalTracer [baseline] (246.267 ms) : 0, 246267
GlobalTracer [candidate] (247.046 ms) : 0, 247046
AppSec [baseline] (26.426 ms) : 0, 26426
AppSec [candidate] (26.374 ms) : 0, 26374
Debugger [baseline] (69.401 ms) : 0, 69401
Debugger [candidate] (69.326 ms) : 0, 69326
Remote Config [baseline] (522.73 µs) : 0, 523
Remote Config [candidate] (521.344 µs) : 0, 521
Telemetry [baseline] (9.711 ms) : 0, 9711
Telemetry [candidate] (9.072 ms) : 0, 9072
Flare Poller [baseline] (3.494 ms) : 0, 3494
Flare Poller [candidate] (3.315 ms) : 0, 3315
IAST [baseline] (25.31 ms) : 0, 25310
IAST [candidate] (25.275 ms) : 0, 25275
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 7 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~b1dbb3061b, baseline=1.61.0-SNAPSHOT~3275dcc717
dateFormat X
axisFormat %s
section baseline
no_agent (17.434 ms) : 17259, 17609
. : milestone, 17434,
appsec (18.321 ms) : 18139, 18502
. : milestone, 18321,
code_origins (17.768 ms) : 17593, 17942
. : milestone, 17768,
iast (18.734 ms) : 18547, 18922
. : milestone, 18734,
profiling (18.637 ms) : 18454, 18819
. : milestone, 18637,
tracing (17.753 ms) : 17579, 17927
. : milestone, 17753,
section candidate
no_agent (19.298 ms) : 19098, 19497
. : milestone, 19298,
appsec (19.509 ms) : 19308, 19709
. : milestone, 19509,
code_origins (17.755 ms) : 17577, 17932
. : milestone, 17755,
iast (18.001 ms) : 17823, 18180
. : milestone, 18001,
profiling (18.786 ms) : 18596, 18976
. : milestone, 18786,
tracing (18.935 ms) : 18743, 19127
. : milestone, 18935,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~b1dbb3061b, baseline=1.61.0-SNAPSHOT~3275dcc717
dateFormat X
axisFormat %s
section baseline
no_agent (1.171 ms) : 1160, 1183
. : milestone, 1171,
iast (3.216 ms) : 3174, 3259
. : milestone, 3216,
iast_FULL (5.769 ms) : 5711, 5827
. : milestone, 5769,
iast_GLOBAL (3.393 ms) : 3344, 3441
. : milestone, 3393,
profiling (2.041 ms) : 2019, 2062
. : milestone, 2041,
tracing (1.769 ms) : 1754, 1784
. : milestone, 1769,
section candidate
no_agent (1.195 ms) : 1183, 1207
. : milestone, 1195,
iast (3.27 ms) : 3230, 3309
. : milestone, 3270,
iast_FULL (5.937 ms) : 5876, 5997
. : milestone, 5937,
iast_GLOBAL (3.557 ms) : 3499, 3616
. : milestone, 3557,
profiling (2.12 ms) : 2100, 2140
. : milestone, 2120,
tracing (1.87 ms) : 1854, 1887
. : milestone, 1870,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~b1dbb3061b, baseline=1.61.0-SNAPSHOT~3275dcc717
dateFormat X
axisFormat %s
section baseline
no_agent (15.316 s) : 15316000, 15316000
. : milestone, 15316000,
appsec (14.757 s) : 14757000, 14757000
. : milestone, 14757000,
iast (18.701 s) : 18701000, 18701000
. : milestone, 18701000,
iast_GLOBAL (17.955 s) : 17955000, 17955000
. : milestone, 17955000,
profiling (14.994 s) : 14994000, 14994000
. : milestone, 14994000,
tracing (14.99 s) : 14990000, 14990000
. : milestone, 14990000,
section candidate
no_agent (15.326 s) : 15326000, 15326000
. : milestone, 15326000,
appsec (14.62 s) : 14620000, 14620000
. : milestone, 14620000,
iast (18.035 s) : 18035000, 18035000
. : milestone, 18035000,
iast_GLOBAL (18.235 s) : 18235000, 18235000
. : milestone, 18235000,
profiling (14.841 s) : 14841000, 14841000
. : milestone, 14841000,
tracing (15.314 s) : 15314000, 15314000
. : milestone, 15314000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~b1dbb3061b, baseline=1.61.0-SNAPSHOT~3275dcc717
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (3.749 ms) : 3532, 3966
. : milestone, 3749,
iast (2.258 ms) : 2189, 2327
. : milestone, 2258,
iast_GLOBAL (2.301 ms) : 2232, 2371
. : milestone, 2301,
profiling (2.115 ms) : 2059, 2172
. : milestone, 2115,
tracing (2.064 ms) : 2010, 2118
. : milestone, 2064,
section candidate
no_agent (1.483 ms) : 1471, 1494
. : milestone, 1483,
appsec (3.74 ms) : 3524, 3957
. : milestone, 3740,
iast (2.252 ms) : 2183, 2321
. : milestone, 2252,
iast_GLOBAL (2.298 ms) : 2229, 2367
. : milestone, 2298,
profiling (2.082 ms) : 2028, 2136
. : milestone, 2082,
tracing (2.065 ms) : 2011, 2119
. : milestone, 2065,
|
3d916ac to
c0cf2fc
Compare
3037d71 to
b1dbb30
Compare
PerfectSlayer
left a comment
There was a problem hiding this comment.
Looking good for the LP team (java-net instrumentation)
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
Separates HTTP header injection (context propagation) from span lifecycle management by gating injectContext() calls behind ad-hoc context tracking advices.
It's mostly a Claude generated PR that I supervised.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.