Replace Objects.hash with HashingUtils in DBInfo#10783
Replace Objects.hash with HashingUtils in DBInfo#10783gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intomasterfrom
Conversation
Co-authored-by: dougqh <dougqh@gmail.com>
|
I can only run on private repositories. |
PerfectSlayer
left a comment
There was a problem hiding this comment.
Looking good, thanks!
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 65 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~6821f6b955, baseline=1.61.0-SNAPSHOT~c04d61b318
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.053 s) : 0, 1053389
Total [baseline] (8.816 s) : 0, 8816403
Agent [candidate] (1.064 s) : 0, 1063732
Total [candidate] (8.829 s) : 0, 8829175
section iast
Agent [baseline] (1.227 s) : 0, 1227452
Total [baseline] (9.563 s) : 0, 9562719
Agent [candidate] (1.234 s) : 0, 1234375
Total [candidate] (9.571 s) : 0, 9571312
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~6821f6b955, baseline=1.61.0-SNAPSHOT~c04d61b318
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.233 ms) : 0, 1233
BytebuddyAgent [baseline] (626.737 ms) : 0, 626737
BytebuddyAgent [candidate] (633.432 ms) : 0, 633432
AgentMeter [baseline] (29.193 ms) : 0, 29193
AgentMeter [candidate] (29.274 ms) : 0, 29274
GlobalTracer [baseline] (256.13 ms) : 0, 256130
GlobalTracer [candidate] (258.621 ms) : 0, 258621
AppSec [baseline] (31.452 ms) : 0, 31452
AppSec [candidate] (31.78 ms) : 0, 31780
Debugger [baseline] (58.596 ms) : 0, 58596
Debugger [candidate] (59.082 ms) : 0, 59082
Remote Config [baseline] (593.096 µs) : 0, 593
Remote Config [candidate] (592.623 µs) : 0, 593
Telemetry [baseline] (8.657 ms) : 0, 8657
Telemetry [candidate] (8.693 ms) : 0, 8693
Flare Poller [baseline] (4.912 ms) : 0, 4912
Flare Poller [candidate] (4.952 ms) : 0, 4952
section iast
crashtracking [baseline] (1.198 ms) : 0, 1198
crashtracking [candidate] (1.203 ms) : 0, 1203
BytebuddyAgent [baseline] (797.366 ms) : 0, 797366
BytebuddyAgent [candidate] (802.909 ms) : 0, 802909
AgentMeter [baseline] (11.306 ms) : 0, 11306
AgentMeter [candidate] (11.599 ms) : 0, 11599
GlobalTracer [baseline] (246.965 ms) : 0, 246965
GlobalTracer [candidate] (248.022 ms) : 0, 248022
AppSec [baseline] (26.466 ms) : 0, 26466
AppSec [candidate] (26.372 ms) : 0, 26372
Debugger [baseline] (62.721 ms) : 0, 62721
Debugger [candidate] (62.689 ms) : 0, 62689
Remote Config [baseline] (529.549 µs) : 0, 530
Remote Config [candidate] (538.958 µs) : 0, 539
Telemetry [baseline] (14.765 ms) : 0, 14765
Telemetry [candidate] (14.713 ms) : 0, 14713
Flare Poller [baseline] (4.879 ms) : 0, 4879
Flare Poller [candidate] (4.886 ms) : 0, 4886
IAST [baseline] (25.125 ms) : 0, 25125
IAST [candidate] (25.152 ms) : 0, 25152
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~6821f6b955, baseline=1.61.0-SNAPSHOT~c04d61b318
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1055766
Total [baseline] (11.019 s) : 0, 11018520
Agent [candidate] (1.066 s) : 0, 1065504
Total [candidate] (11.03 s) : 0, 11030230
section appsec
Agent [baseline] (1.245 s) : 0, 1245303
Total [baseline] (11.17 s) : 0, 11170247
Agent [candidate] (1.246 s) : 0, 1246224
Total [candidate] (11.101 s) : 0, 11101287
section iast
Agent [baseline] (1.234 s) : 0, 1233694
Total [baseline] (11.348 s) : 0, 11347518
Agent [candidate] (1.246 s) : 0, 1245804
Total [candidate] (11.438 s) : 0, 11438214
section profiling
Agent [baseline] (1.18 s) : 0, 1179628
Total [baseline] (10.911 s) : 0, 10911277
Agent [candidate] (1.178 s) : 0, 1178186
Total [candidate] (10.917 s) : 0, 10917192
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~6821f6b955, baseline=1.61.0-SNAPSHOT~c04d61b318
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (626.976 ms) : 0, 626976
BytebuddyAgent [candidate] (631.303 ms) : 0, 631303
AgentMeter [baseline] (29.089 ms) : 0, 29089
AgentMeter [candidate] (29.236 ms) : 0, 29236
GlobalTracer [baseline] (256.659 ms) : 0, 256659
GlobalTracer [candidate] (258.191 ms) : 0, 258191
AppSec [baseline] (31.477 ms) : 0, 31477
AppSec [candidate] (31.723 ms) : 0, 31723
Debugger [baseline] (59.616 ms) : 0, 59616
Debugger [candidate] (59.788 ms) : 0, 59788
Remote Config [baseline] (624.318 µs) : 0, 624
Remote Config [candidate] (587.841 µs) : 0, 588
Telemetry [baseline] (8.618 ms) : 0, 8618
Telemetry [candidate] (8.681 ms) : 0, 8681
Flare Poller [baseline] (5.671 ms) : 0, 5671
Flare Poller [candidate] (8.716 ms) : 0, 8716
section appsec
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (656.86 ms) : 0, 656860
BytebuddyAgent [candidate] (658.639 ms) : 0, 658639
AgentMeter [baseline] (12.005 ms) : 0, 12005
AgentMeter [candidate] (12.011 ms) : 0, 12011
GlobalTracer [baseline] (258.046 ms) : 0, 258046
GlobalTracer [candidate] (258.065 ms) : 0, 258065
IAST [baseline] (23.951 ms) : 0, 23951
IAST [candidate] (23.917 ms) : 0, 23917
AppSec [baseline] (178.127 ms) : 0, 178127
AppSec [candidate] (177.44 ms) : 0, 177440
Debugger [baseline] (65.672 ms) : 0, 65672
Debugger [candidate] (65.494 ms) : 0, 65494
Remote Config [baseline] (577.624 µs) : 0, 578
Remote Config [candidate] (575.389 µs) : 0, 575
Telemetry [baseline] (9.055 ms) : 0, 9055
Telemetry [candidate] (9.043 ms) : 0, 9043
Flare Poller [baseline] (3.63 ms) : 0, 3630
Flare Poller [candidate] (3.572 ms) : 0, 3572
section iast
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.221 ms) : 0, 1221
BytebuddyAgent [baseline] (799.942 ms) : 0, 799942
BytebuddyAgent [candidate] (808.697 ms) : 0, 808697
AgentMeter [baseline] (11.421 ms) : 0, 11421
AgentMeter [candidate] (11.718 ms) : 0, 11718
GlobalTracer [baseline] (248.915 ms) : 0, 248915
GlobalTracer [candidate] (251.011 ms) : 0, 251011
IAST [baseline] (25.324 ms) : 0, 25324
IAST [candidate] (25.72 ms) : 0, 25720
AppSec [baseline] (26.639 ms) : 0, 26639
AppSec [candidate] (27.086 ms) : 0, 27086
Debugger [baseline] (63.956 ms) : 0, 63956
Debugger [candidate] (63.834 ms) : 0, 63834
Remote Config [baseline] (533.121 µs) : 0, 533
Remote Config [candidate] (536.361 µs) : 0, 536
Telemetry [baseline] (14.9 ms) : 0, 14900
Telemetry [candidate] (14.923 ms) : 0, 14923
Flare Poller [baseline] (4.885 ms) : 0, 4885
Flare Poller [candidate] (4.744 ms) : 0, 4744
section profiling
crashtracking [baseline] (1.165 ms) : 0, 1165
crashtracking [candidate] (1.153 ms) : 0, 1153
BytebuddyAgent [baseline] (681.485 ms) : 0, 681485
BytebuddyAgent [candidate] (680.932 ms) : 0, 680932
AgentMeter [baseline] (8.585 ms) : 0, 8585
AgentMeter [candidate] (8.538 ms) : 0, 8538
GlobalTracer [baseline] (215.089 ms) : 0, 215089
GlobalTracer [candidate] (214.741 ms) : 0, 214741
AppSec [baseline] (31.835 ms) : 0, 31835
AppSec [candidate] (31.801 ms) : 0, 31801
Debugger [baseline] (64.329 ms) : 0, 64329
Debugger [candidate] (63.503 ms) : 0, 63503
Remote Config [baseline] (581.258 µs) : 0, 581
Remote Config [candidate] (582.209 µs) : 0, 582
Telemetry [baseline] (8.903 ms) : 0, 8903
Telemetry [candidate] (8.887 ms) : 0, 8887
Flare Poller [baseline] (3.511 ms) : 0, 3511
Flare Poller [candidate] (4.164 ms) : 0, 4164
ProfilingAgent [baseline] (93.396 ms) : 0, 93396
ProfilingAgent [candidate] (93.243 ms) : 0, 93243
Profiling [baseline] (93.956 ms) : 0, 93956
Profiling [candidate] (93.809 ms) : 0, 93809
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~6821f6b955, baseline=1.61.0-SNAPSHOT~c04d61b318
dateFormat X
axisFormat %s
section baseline
no_agent (1.186 ms) : 1174, 1197
. : milestone, 1186,
iast (3.173 ms) : 3133, 3213
. : milestone, 3173,
iast_FULL (5.777 ms) : 5718, 5835
. : milestone, 5777,
iast_GLOBAL (3.453 ms) : 3396, 3509
. : milestone, 3453,
profiling (2.202 ms) : 2179, 2225
. : milestone, 2202,
tracing (1.769 ms) : 1754, 1783
. : milestone, 1769,
section candidate
no_agent (1.193 ms) : 1181, 1205
. : milestone, 1193,
iast (3.188 ms) : 3146, 3230
. : milestone, 3188,
iast_FULL (5.766 ms) : 5710, 5823
. : milestone, 5766,
iast_GLOBAL (3.571 ms) : 3515, 3627
. : milestone, 3571,
profiling (2.04 ms) : 2020, 2059
. : milestone, 2040,
tracing (1.806 ms) : 1791, 1820
. : milestone, 1806,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~6821f6b955, baseline=1.61.0-SNAPSHOT~c04d61b318
dateFormat X
axisFormat %s
section baseline
no_agent (19.456 ms) : 19249, 19662
. : milestone, 19456,
appsec (18.868 ms) : 18677, 19058
. : milestone, 18868,
code_origins (17.784 ms) : 17607, 17962
. : milestone, 17784,
iast (17.927 ms) : 17747, 18107
. : milestone, 17927,
profiling (18.8 ms) : 18613, 18988
. : milestone, 18800,
tracing (17.68 ms) : 17506, 17855
. : milestone, 17680,
section candidate
no_agent (19.067 ms) : 18871, 19263
. : milestone, 19067,
appsec (18.656 ms) : 18468, 18843
. : milestone, 18656,
code_origins (17.946 ms) : 17768, 18123
. : milestone, 17946,
iast (17.96 ms) : 17776, 18144
. : milestone, 17960,
profiling (19.758 ms) : 19559, 19957
. : milestone, 19758,
tracing (17.604 ms) : 17432, 17776
. : milestone, 17604,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 1 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~6821f6b955, baseline=1.61.0-SNAPSHOT~c04d61b318
dateFormat X
axisFormat %s
section baseline
no_agent (15.278 s) : 15278000, 15278000
. : milestone, 15278000,
appsec (14.737 s) : 14737000, 14737000
. : milestone, 14737000,
iast (18.22 s) : 18220000, 18220000
. : milestone, 18220000,
iast_GLOBAL (17.867 s) : 17867000, 17867000
. : milestone, 17867000,
profiling (14.785 s) : 14785000, 14785000
. : milestone, 14785000,
tracing (14.895 s) : 14895000, 14895000
. : milestone, 14895000,
section candidate
no_agent (15.073 s) : 15073000, 15073000
. : milestone, 15073000,
appsec (15.108 s) : 15108000, 15108000
. : milestone, 15108000,
iast (18.089 s) : 18089000, 18089000
. : milestone, 18089000,
iast_GLOBAL (17.97 s) : 17970000, 17970000
. : milestone, 17970000,
profiling (15.638 s) : 15638000, 15638000
. : milestone, 15638000,
tracing (15.022 s) : 15022000, 15022000
. : milestone, 15022000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~6821f6b955, baseline=1.61.0-SNAPSHOT~c04d61b318
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (3.781 ms) : 3560, 4002
. : milestone, 3781,
iast (2.25 ms) : 2181, 2320
. : milestone, 2250,
iast_GLOBAL (2.297 ms) : 2228, 2367
. : milestone, 2297,
profiling (2.505 ms) : 2349, 2661
. : milestone, 2505,
tracing (2.057 ms) : 2003, 2111
. : milestone, 2057,
section candidate
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (2.504 ms) : 2449, 2559
. : milestone, 2504,
iast (2.251 ms) : 2181, 2320
. : milestone, 2251,
iast_GLOBAL (2.293 ms) : 2224, 2363
. : milestone, 2293,
profiling (2.084 ms) : 2029, 2139
. : milestone, 2084,
tracing (2.057 ms) : 2003, 2111
. : milestone, 2057,
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
Replaces calls to
java.util.Objects.hashwithdatadog.trace.util.HashingUtilsin the DBInfo class to use Datadog's internal hashing utilities instead of the standard Java library.Motivation
Avoids
Object[]allocation from calling var-arg methodObjects.hashAdditional Notes
The change maintains the same hashCode() behavior by sequentially hashing all fields in the same order using
HashingUtils.addToHash().Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
PR by Bits
View session in Datadog
Comment @DataDog to request changes