Skip to content

Use HashingUtils in config hashCode#10812

Closed
dougqh wants to merge 2 commits intomasterfrom
dd/refactor/use-hashingutils-in-config-hashcode
Closed

Use HashingUtils in config hashCode#10812
dougqh wants to merge 2 commits intomasterfrom
dd/refactor/use-hashingutils-in-config-hashcode

Conversation

@dougqh
Copy link
Copy Markdown
Contributor

@dougqh dougqh commented Mar 11, 2026

What Does This Do

Replaces Objects.hash(...) usage in ParsedConfigKey and ConfigSetting with HashingUtils-based hashing.

Motivation

Avoid varargs-based Objects.hash and auto-boxing in these classes

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

Note: Once your PR is ready to merge, add it to the merge queue by commenting /merge. /merge -c cancels the queue request. /merge -f --reason "reason" skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.


PR by Bits
View session in Datadog

Comment @DataDog to request changes

Co-authored-by: dougqh <dougqh@gmail.com>
@datadog-datadog-prod-us1
Copy link
Copy Markdown
Contributor

View session in Datadog

Bits Dev status: ✅ Done

CI Auto-fix: Disabled | Enable

Comment @DataDog to request changes

@datadog-prod-us1-6
Copy link
Copy Markdown

I can only run on private repositories.

@dougqh dougqh added type: enhancement Enhancements and improvements tag: ibm IBM JVM related comp: core Tracer core comp: remote config Configuration at Runtime and removed Bits AI labels Mar 11, 2026
@dougqh dougqh marked this pull request as ready for review March 11, 2026 18:18
@dougqh dougqh requested review from a team as code owners March 11, 2026 18:18
@dougqh dougqh requested review from amarziali and removed request for a team March 11, 2026 18:18
@dougqh dougqh marked this pull request as draft March 11, 2026 18:21
@dougqh
Copy link
Copy Markdown
Contributor Author

dougqh commented Mar 11, 2026

Looks like HashingUtils may not be visible to config-utils, will revisit later on

@dougqh
Copy link
Copy Markdown
Contributor Author

dougqh commented Mar 11, 2026

Need to relocate HashingUtils before making this change

@dougqh dougqh closed this Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: core Tracer core comp: remote config Configuration at Runtime tag: ibm IBM JVM related type: enhancement Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants