Skip to content

Use HashingUtils in config hashCode #10812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dougqh wants to merge 2 commits into from
Closed

Use HashingUtils in config hashCode #10812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b96603
Use HashingUtils in config hashCode
datadog-datadog-prod-us1[bot] Mar 11, 2026
43e18b2
Tweaking approach to avoid auto-boxing
dougqh Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...e-config/remote-config-core/src/main/java/datadog/remoteconfig/state/ParsedConfigKey.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import datadog.remoteconfig.Product;
import datadog.remoteconfig.ReportableException;
import datadog.trace.util.HashingUtils;
import java.util.Locale;
import java.util.Objects;
import java.util.regex.Matcher;
Expand Down Expand Up @@ -90,6 +91,6 @@ public boolean equals(Object o) {

@Override
public int hashCode() {
return Objects.hash(originalKey);
return HashingUtils.hash(originalKey);
}
}
9 changes: 8 additions & 1 deletion utils/config-utils/src/main/java/datadog/trace/api/ConfigSetting.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package datadog.trace.api;

import datadog.trace.util.HashingUtils;
import java.util.Arrays;
import java.util.BitSet;
import java.util.HashSet;
Expand Down Expand Up @@ -132,7 +133,13 @@ public boolean equals(Object o) {

@Override
public int hashCode() {
return Objects.hash(key, value, origin, seqId, configId);
int hash = 0;
hash = HashingUtils.addToHash(hash, key);
hash = HashingUtils.addToHash(hash, value);
hash = HashingUtils.addToHash(hash, origin);
hash = HashingUtils.addToHash(hash, seqId);
hash = HashingUtils.addToHash(hash, configId);
return hash;
}

@Override
Expand Down
Loading