Reduce VirtualThread tests flakiness#10834
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomasterfrom Mar 13, 2026
Merged
Reduce VirtualThread tests flakiness#10834gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomasterfrom
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomasterfrom
Conversation
Introduce generic blockUntil method to wait for trace pattern before evaluating them
PerfectSlayer
added
tag: no release notes
amarziali
approved these changes
Mar 13, 2026
Contributor
amarziali
left a comment
amarziali
left a comment
There was a problem hiding this comment.
The approach is cleaner however I don't know if this will reduce the flakiness since it waits similarly for the same stuff
Contributor
Author
I used to check for the jobs to complete. Now I check for the spans to be written. |
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 64 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~03f496964a, baseline=1.61.0-SNAPSHOT~c00f676bb9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1055685
Total [baseline] (8.821 s) : 0, 8820939
Agent [candidate] (1.056 s) : 0, 1056342
Total [candidate] (8.88 s) : 0, 8879825
section iast
Agent [baseline] (1.226 s) : 0, 1225538
Total [baseline] (9.611 s) : 0, 9611479
Agent [candidate] (1.233 s) : 0, 1232647
Total [candidate] (9.54 s) : 0, 9540389
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~03f496964a, baseline=1.61.0-SNAPSHOT~c00f676bb9
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.207 ms) : 0, 1207
crashtracking [candidate] (1.199 ms) : 0, 1199
BytebuddyAgent [baseline] (626.81 ms) : 0, 626810
BytebuddyAgent [candidate] (628.506 ms) : 0, 628506
AgentMeter [baseline] (29.375 ms) : 0, 29375
AgentMeter [candidate] (29.299 ms) : 0, 29299
GlobalTracer [baseline] (256.127 ms) : 0, 256127
GlobalTracer [candidate] (256.682 ms) : 0, 256682
AppSec [baseline] (31.633 ms) : 0, 31633
AppSec [candidate] (31.614 ms) : 0, 31614
Debugger [baseline] (59.419 ms) : 0, 59419
Debugger [candidate] (59.446 ms) : 0, 59446
Remote Config [baseline] (587.634 µs) : 0, 588
Remote Config [candidate] (580.831 µs) : 0, 581
Telemetry [baseline] (9.435 ms) : 0, 9435
Telemetry [candidate] (9.509 ms) : 0, 9509
Flare Poller [baseline] (5.101 ms) : 0, 5101
Flare Poller [candidate] (3.536 ms) : 0, 3536
section iast
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.218 ms) : 0, 1218
BytebuddyAgent [baseline] (794.413 ms) : 0, 794413
BytebuddyAgent [candidate] (800.274 ms) : 0, 800274
AgentMeter [baseline] (11.374 ms) : 0, 11374
AgentMeter [candidate] (11.615 ms) : 0, 11615
GlobalTracer [baseline] (246.953 ms) : 0, 246953
GlobalTracer [candidate] (247.955 ms) : 0, 247955
IAST [baseline] (25.378 ms) : 0, 25378
IAST [candidate] (25.582 ms) : 0, 25582
AppSec [baseline] (26.427 ms) : 0, 26427
AppSec [candidate] (26.632 ms) : 0, 26632
Debugger [baseline] (70.454 ms) : 0, 70454
Debugger [candidate] (68.774 ms) : 0, 68774
Remote Config [baseline] (535.401 µs) : 0, 535
Remote Config [candidate] (544.782 µs) : 0, 545
Telemetry [baseline] (9.281 ms) : 0, 9281
Telemetry [candidate] (10.241 ms) : 0, 10241
Flare Poller [baseline] (3.435 ms) : 0, 3435
Flare Poller [candidate] (3.65 ms) : 0, 3650
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~03f496964a, baseline=1.61.0-SNAPSHOT~c00f676bb9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1056341
Total [baseline] (11.065 s) : 0, 11064933
Agent [candidate] (1.057 s) : 0, 1056783
Total [candidate] (11.047 s) : 0, 11047392
section appsec
Agent [baseline] (1.244 s) : 0, 1244380
Total [baseline] (11.179 s) : 0, 11178989
Agent [candidate] (1.257 s) : 0, 1257306
Total [candidate] (11.195 s) : 0, 11195299
section iast
Agent [baseline] (1.232 s) : 0, 1232247
Total [baseline] (11.381 s) : 0, 11380789
Agent [candidate] (1.227 s) : 0, 1227197
Total [candidate] (11.278 s) : 0, 11278137
section profiling
Agent [baseline] (1.196 s) : 0, 1195519
Total [baseline] (11.226 s) : 0, 11226359
Agent [candidate] (1.183 s) : 0, 1183456
Total [candidate] (11.009 s) : 0, 11008610
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~03f496964a, baseline=1.61.0-SNAPSHOT~c00f676bb9
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (628.295 ms) : 0, 628295
BytebuddyAgent [candidate] (629.081 ms) : 0, 629081
AgentMeter [baseline] (29.172 ms) : 0, 29172
AgentMeter [candidate] (29.207 ms) : 0, 29207
GlobalTracer [baseline] (256.273 ms) : 0, 256273
GlobalTracer [candidate] (256.458 ms) : 0, 256458
AppSec [baseline] (31.601 ms) : 0, 31601
AppSec [candidate] (31.632 ms) : 0, 31632
Debugger [baseline] (60.231 ms) : 0, 60231
Debugger [candidate] (60.342 ms) : 0, 60342
Remote Config [baseline] (585.768 µs) : 0, 586
Remote Config [candidate] (591.452 µs) : 0, 591
Telemetry [baseline] (7.99 ms) : 0, 7990
Telemetry [candidate] (8.047 ms) : 0, 8047
Flare Poller [baseline] (5.079 ms) : 0, 5079
Flare Poller [candidate] (4.295 ms) : 0, 4295
section appsec
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (656.992 ms) : 0, 656992
BytebuddyAgent [candidate] (664.849 ms) : 0, 664849
AgentMeter [baseline] (12.078 ms) : 0, 12078
AgentMeter [candidate] (12.19 ms) : 0, 12190
GlobalTracer [baseline] (257.45 ms) : 0, 257450
GlobalTracer [candidate] (260.563 ms) : 0, 260563
IAST [baseline] (24.124 ms) : 0, 24124
IAST [candidate] (24.395 ms) : 0, 24395
AppSec [baseline] (177.684 ms) : 0, 177684
AppSec [candidate] (178.637 ms) : 0, 178637
Debugger [baseline] (66.055 ms) : 0, 66055
Debugger [candidate] (66.462 ms) : 0, 66462
Remote Config [baseline] (632.628 µs) : 0, 633
Remote Config [candidate] (642.812 µs) : 0, 643
Telemetry [baseline] (8.41 ms) : 0, 8410
Telemetry [candidate] (8.359 ms) : 0, 8359
Flare Poller [baseline] (3.609 ms) : 0, 3609
Flare Poller [candidate] (3.646 ms) : 0, 3646
section iast
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (798.987 ms) : 0, 798987
BytebuddyAgent [candidate] (795.897 ms) : 0, 795897
AgentMeter [baseline] (11.463 ms) : 0, 11463
AgentMeter [candidate] (11.397 ms) : 0, 11397
GlobalTracer [baseline] (248.069 ms) : 0, 248069
GlobalTracer [candidate] (247.279 ms) : 0, 247279
IAST [baseline] (25.449 ms) : 0, 25449
IAST [candidate] (25.292 ms) : 0, 25292
AppSec [baseline] (26.617 ms) : 0, 26617
AppSec [candidate] (26.426 ms) : 0, 26426
Debugger [baseline] (71.058 ms) : 0, 71058
Debugger [candidate] (70.516 ms) : 0, 70516
Remote Config [baseline] (540.267 µs) : 0, 540
Remote Config [candidate] (526.567 µs) : 0, 527
Telemetry [baseline] (9.311 ms) : 0, 9311
Telemetry [candidate] (9.255 ms) : 0, 9255
Flare Poller [baseline] (3.461 ms) : 0, 3461
Flare Poller [candidate] (3.396 ms) : 0, 3396
section profiling
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.163 ms) : 0, 1163
BytebuddyAgent [baseline] (690.084 ms) : 0, 690084
BytebuddyAgent [candidate] (683.198 ms) : 0, 683198
AgentMeter [baseline] (9.139 ms) : 0, 9139
AgentMeter [candidate] (9.04 ms) : 0, 9040
GlobalTracer [baseline] (217.797 ms) : 0, 217797
GlobalTracer [candidate] (215.645 ms) : 0, 215645
AppSec [baseline] (32.353 ms) : 0, 32353
AppSec [candidate] (32.142 ms) : 0, 32142
Debugger [baseline] (66.011 ms) : 0, 66011
Debugger [candidate] (64.996 ms) : 0, 64996
Remote Config [baseline] (570.798 µs) : 0, 571
Remote Config [candidate] (554.704 µs) : 0, 555
Telemetry [baseline] (8.567 ms) : 0, 8567
Telemetry [candidate] (8.494 ms) : 0, 8494
Flare Poller [baseline] (3.527 ms) : 0, 3527
Flare Poller [candidate] (3.447 ms) : 0, 3447
ProfilingAgent [baseline] (94.852 ms) : 0, 94852
ProfilingAgent [candidate] (93.886 ms) : 0, 93886
Profiling [baseline] (95.427 ms) : 0, 95427
Profiling [candidate] (94.444 ms) : 0, 94444
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 6 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~03f496964a, baseline=1.61.0-SNAPSHOT~c00f676bb9
dateFormat X
axisFormat %s
section baseline
no_agent (1.202 ms) : 1190, 1214
. : milestone, 1202,
iast (3.286 ms) : 3242, 3329
. : milestone, 3286,
iast_FULL (5.739 ms) : 5682, 5797
. : milestone, 5739,
iast_GLOBAL (3.526 ms) : 3470, 3582
. : milestone, 3526,
profiling (2.039 ms) : 2021, 2057
. : milestone, 2039,
tracing (1.8 ms) : 1786, 1814
. : milestone, 1800,
section candidate
no_agent (1.189 ms) : 1177, 1200
. : milestone, 1189,
iast (3.264 ms) : 3222, 3306
. : milestone, 3264,
iast_FULL (5.768 ms) : 5712, 5825
. : milestone, 5768,
iast_GLOBAL (3.698 ms) : 3633, 3763
. : milestone, 3698,
profiling (1.97 ms) : 1953, 1986
. : milestone, 1970,
tracing (1.794 ms) : 1779, 1809
. : milestone, 1794,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~03f496964a, baseline=1.61.0-SNAPSHOT~c00f676bb9
dateFormat X
axisFormat %s
section baseline
no_agent (17.857 ms) : 17677, 18036
. : milestone, 17857,
appsec (18.275 ms) : 18089, 18461
. : milestone, 18275,
code_origins (17.688 ms) : 17515, 17861
. : milestone, 17688,
iast (17.651 ms) : 17476, 17825
. : milestone, 17651,
profiling (18.651 ms) : 18465, 18836
. : milestone, 18651,
tracing (17.842 ms) : 17665, 18018
. : milestone, 17842,
section candidate
no_agent (19.219 ms) : 19023, 19416
. : milestone, 19219,
appsec (18.548 ms) : 18357, 18739
. : milestone, 18548,
code_origins (18.666 ms) : 18477, 18854
. : milestone, 18666,
iast (17.777 ms) : 17601, 17953
. : milestone, 17777,
profiling (19.674 ms) : 19473, 19875
. : milestone, 19674,
tracing (17.597 ms) : 17421, 17773
. : milestone, 17597,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~03f496964a, baseline=1.61.0-SNAPSHOT~c00f676bb9
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1486
. : milestone, 1474,
appsec (3.699 ms) : 3482, 3916
. : milestone, 3699,
iast (2.255 ms) : 2187, 2324
. : milestone, 2255,
iast_GLOBAL (2.305 ms) : 2236, 2374
. : milestone, 2305,
profiling (2.094 ms) : 2038, 2151
. : milestone, 2094,
tracing (2.068 ms) : 2014, 2121
. : milestone, 2068,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (3.806 ms) : 3584, 4029
. : milestone, 3806,
iast (2.244 ms) : 2176, 2313
. : milestone, 2244,
iast_GLOBAL (2.306 ms) : 2237, 2376
. : milestone, 2306,
profiling (2.089 ms) : 2034, 2143
. : milestone, 2089,
tracing (2.067 ms) : 2013, 2121
. : milestone, 2067,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~03f496964a, baseline=1.61.0-SNAPSHOT~c00f676bb9
dateFormat X
axisFormat %s
section baseline
no_agent (15.037 s) : 15037000, 15037000
. : milestone, 15037000,
appsec (14.63 s) : 14630000, 14630000
. : milestone, 14630000,
iast (18.473 s) : 18473000, 18473000
. : milestone, 18473000,
iast_GLOBAL (17.824 s) : 17824000, 17824000
. : milestone, 17824000,
profiling (14.99 s) : 14990000, 14990000
. : milestone, 14990000,
tracing (15.143 s) : 15143000, 15143000
. : milestone, 15143000,
section candidate
no_agent (15.548 s) : 15548000, 15548000
. : milestone, 15548000,
appsec (14.766 s) : 14766000, 14766000
. : milestone, 14766000,
iast (18.219 s) : 18219000, 18219000
. : milestone, 18219000,
iast_GLOBAL (17.856 s) : 17856000, 17856000
. : milestone, 17856000,
profiling (14.967 s) : 14967000, 14967000
. : milestone, 14967000,
tracing (14.707 s) : 14707000, 14707000
. : milestone, 14707000,
|
gh-worker-dd-mergequeue-cf854d
bot
merged commit 243ec0b
into
master
577 of 580 checks passed
bric3
reviewed
Mar 17, 2026
Comment on lines
+149
to
+161
| protected void blockUntilTracesMatch(Predicate<List<List<DDSpan>>> predicate) { | ||
| long deadline = System.currentTimeMillis() + TIMEOUT_MILLIS; | ||
| while (!predicate.test(this.writer)) { | ||
| if (System.currentTimeMillis() > deadline) { | ||
| throw new RuntimeException(new TimeoutException("Timed out waiting for traces/spans.")); | ||
| } | ||
| try { | ||
| Thread.sleep(10); | ||
| } catch (InterruptedException e) { | ||
| Thread.currentThread().interrupt(); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR aims to reduce flakiness when checking for trace structure using async calls.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.