Add processor context for hotspot crash tracking#10867
Add processor context for hotspot crash tracking#10867gh-worker-dd-mergequeue-cf854d[bot] merged 5 commits intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 64 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~388e3cd480, baseline=1.61.0-SNAPSHOT~1e19001696
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1059290
Total [baseline] (11.198 s) : 0, 11198287
Agent [candidate] (1.056 s) : 0, 1055937
Total [candidate] (11.048 s) : 0, 11048117
section appsec
Agent [baseline] (1.247 s) : 0, 1246577
Total [baseline] (11.129 s) : 0, 11128857
Agent [candidate] (1.255 s) : 0, 1255343
Total [candidate] (11.138 s) : 0, 11138162
section iast
Agent [baseline] (1.226 s) : 0, 1225851
Total [baseline] (11.271 s) : 0, 11270851
Agent [candidate] (1.235 s) : 0, 1234701
Total [candidate] (11.353 s) : 0, 11352621
section profiling
Agent [baseline] (1.19 s) : 0, 1189946
Total [baseline] (11.079 s) : 0, 11079427
Agent [candidate] (1.183 s) : 0, 1182979
Total [candidate] (10.933 s) : 0, 10932921
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~388e3cd480, baseline=1.61.0-SNAPSHOT~1e19001696
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.206 ms) : 0, 1206
crashtracking [candidate] (1.206 ms) : 0, 1206
BytebuddyAgent [baseline] (629.588 ms) : 0, 629588
BytebuddyAgent [candidate] (628.643 ms) : 0, 628643
AgentMeter [baseline] (29.574 ms) : 0, 29574
AgentMeter [candidate] (29.294 ms) : 0, 29294
GlobalTracer [baseline] (258.037 ms) : 0, 258037
GlobalTracer [candidate] (256.698 ms) : 0, 256698
AppSec [baseline] (31.965 ms) : 0, 31965
AppSec [candidate] (31.731 ms) : 0, 31731
Debugger [baseline] (60.735 ms) : 0, 60735
Debugger [candidate] (60.31 ms) : 0, 60310
Remote Config [baseline] (590.613 µs) : 0, 591
Remote Config [candidate] (585.395 µs) : 0, 585
Telemetry [baseline] (8.044 ms) : 0, 8044
Telemetry [candidate] (7.977 ms) : 0, 7977
Flare Poller [baseline] (3.533 ms) : 0, 3533
Flare Poller [candidate] (3.501 ms) : 0, 3501
section appsec
crashtracking [baseline] (1.198 ms) : 0, 1198
crashtracking [candidate] (1.206 ms) : 0, 1206
BytebuddyAgent [baseline] (658.263 ms) : 0, 658263
BytebuddyAgent [candidate] (664.62 ms) : 0, 664620
AgentMeter [baseline] (12.062 ms) : 0, 12062
AgentMeter [candidate] (12.23 ms) : 0, 12230
GlobalTracer [baseline] (258.084 ms) : 0, 258084
GlobalTracer [candidate] (259.315 ms) : 0, 259315
IAST [baseline] (24.184 ms) : 0, 24184
IAST [candidate] (24.274 ms) : 0, 24274
AppSec [baseline] (177.839 ms) : 0, 177839
AppSec [candidate] (177.938 ms) : 0, 177938
Debugger [baseline] (66.131 ms) : 0, 66131
Debugger [candidate] (66.737 ms) : 0, 66737
Remote Config [baseline] (626.215 µs) : 0, 626
Remote Config [candidate] (624.144 µs) : 0, 624
Telemetry [baseline] (8.303 ms) : 0, 8303
Telemetry [candidate] (8.367 ms) : 0, 8367
Flare Poller [baseline] (3.597 ms) : 0, 3597
Flare Poller [candidate] (3.654 ms) : 0, 3654
section iast
crashtracking [baseline] (1.212 ms) : 0, 1212
crashtracking [candidate] (1.204 ms) : 0, 1204
BytebuddyAgent [baseline] (794.96 ms) : 0, 794960
BytebuddyAgent [candidate] (799.642 ms) : 0, 799642
AgentMeter [baseline] (11.368 ms) : 0, 11368
AgentMeter [candidate] (11.507 ms) : 0, 11507
GlobalTracer [baseline] (246.802 ms) : 0, 246802
GlobalTracer [candidate] (249.356 ms) : 0, 249356
IAST [baseline] (25.326 ms) : 0, 25326
IAST [candidate] (25.601 ms) : 0, 25601
AppSec [baseline] (26.482 ms) : 0, 26482
AppSec [candidate] (26.901 ms) : 0, 26901
Debugger [baseline] (69.974 ms) : 0, 69974
Debugger [candidate] (70.545 ms) : 0, 70545
Remote Config [baseline] (524.333 µs) : 0, 524
Remote Config [candidate] (538.348 µs) : 0, 538
Telemetry [baseline] (9.678 ms) : 0, 9678
Telemetry [candidate] (9.735 ms) : 0, 9735
Flare Poller [baseline] (3.482 ms) : 0, 3482
Flare Poller [candidate] (3.494 ms) : 0, 3494
section profiling
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (687.238 ms) : 0, 687238
BytebuddyAgent [candidate] (683.007 ms) : 0, 683007
AgentMeter [baseline] (9.039 ms) : 0, 9039
AgentMeter [candidate] (8.985 ms) : 0, 8985
GlobalTracer [baseline] (216.832 ms) : 0, 216832
GlobalTracer [candidate] (215.495 ms) : 0, 215495
AppSec [baseline] (32.361 ms) : 0, 32361
AppSec [candidate] (32.104 ms) : 0, 32104
Debugger [baseline] (66.265 ms) : 0, 66265
Debugger [candidate] (64.876 ms) : 0, 64876
Remote Config [baseline] (555.101 µs) : 0, 555
Remote Config [candidate] (573.192 µs) : 0, 573
Telemetry [baseline] (7.712 ms) : 0, 7712
Telemetry [candidate] (8.476 ms) : 0, 8476
Flare Poller [baseline] (3.473 ms) : 0, 3473
Flare Poller [candidate] (3.463 ms) : 0, 3463
ProfilingAgent [baseline] (93.938 ms) : 0, 93938
ProfilingAgent [candidate] (93.914 ms) : 0, 93914
Profiling [baseline] (94.504 ms) : 0, 94504
Profiling [candidate] (94.47 ms) : 0, 94470
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~388e3cd480, baseline=1.61.0-SNAPSHOT~1e19001696
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1055114
Total [baseline] (8.869 s) : 0, 8869026
Agent [candidate] (1.055 s) : 0, 1055450
Total [candidate] (8.825 s) : 0, 8825351
section iast
Agent [baseline] (1.23 s) : 0, 1230111
Total [baseline] (9.574 s) : 0, 9573890
Agent [candidate] (1.235 s) : 0, 1235040
Total [candidate] (9.597 s) : 0, 9596817
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~388e3cd480, baseline=1.61.0-SNAPSHOT~1e19001696
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (627.249 ms) : 0, 627249
BytebuddyAgent [candidate] (628.778 ms) : 0, 628778
AgentMeter [baseline] (29.264 ms) : 0, 29264
AgentMeter [candidate] (29.364 ms) : 0, 29364
GlobalTracer [baseline] (256.564 ms) : 0, 256564
GlobalTracer [candidate] (256.753 ms) : 0, 256753
AppSec [baseline] (31.638 ms) : 0, 31638
AppSec [candidate] (31.722 ms) : 0, 31722
Debugger [baseline] (59.599 ms) : 0, 59599
Debugger [candidate] (59.571 ms) : 0, 59571
Remote Config [baseline] (595.195 µs) : 0, 595
Remote Config [candidate] (578.616 µs) : 0, 579
Telemetry [baseline] (7.983 ms) : 0, 7983
Telemetry [candidate] (7.971 ms) : 0, 7971
Flare Poller [baseline] (5.016 ms) : 0, 5016
Flare Poller [candidate] (3.487 ms) : 0, 3487
section iast
crashtracking [baseline] (1.212 ms) : 0, 1212
crashtracking [candidate] (1.208 ms) : 0, 1208
BytebuddyAgent [baseline] (799.402 ms) : 0, 799402
BytebuddyAgent [candidate] (803.703 ms) : 0, 803703
AgentMeter [baseline] (11.613 ms) : 0, 11613
AgentMeter [candidate] (11.64 ms) : 0, 11640
GlobalTracer [baseline] (246.945 ms) : 0, 246945
GlobalTracer [candidate] (246.893 ms) : 0, 246893
IAST [baseline] (25.246 ms) : 0, 25246
IAST [candidate] (25.315 ms) : 0, 25315
AppSec [baseline] (26.359 ms) : 0, 26359
AppSec [candidate] (26.437 ms) : 0, 26437
Debugger [baseline] (68.485 ms) : 0, 68485
Debugger [candidate] (69.767 ms) : 0, 69767
Remote Config [baseline] (526.686 µs) : 0, 527
Remote Config [candidate] (534.309 µs) : 0, 534
Telemetry [baseline] (10.481 ms) : 0, 10481
Telemetry [candidate] (9.731 ms) : 0, 9731
Flare Poller [baseline] (3.627 ms) : 0, 3627
Flare Poller [candidate] (3.549 ms) : 0, 3549
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 1 performance regressions! Performance is the same for 16 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~388e3cd480, baseline=1.61.0-SNAPSHOT~1e19001696
dateFormat X
axisFormat %s
section baseline
no_agent (1.181 ms) : 1169, 1192
. : milestone, 1181,
iast (3.101 ms) : 3062, 3140
. : milestone, 3101,
iast_FULL (5.674 ms) : 5618, 5730
. : milestone, 5674,
iast_GLOBAL (3.545 ms) : 3488, 3602
. : milestone, 3545,
profiling (2.072 ms) : 2054, 2091
. : milestone, 2072,
tracing (1.962 ms) : 1944, 1979
. : milestone, 1962,
section candidate
no_agent (1.174 ms) : 1163, 1186
. : milestone, 1174,
iast (3.097 ms) : 3059, 3136
. : milestone, 3097,
iast_FULL (5.729 ms) : 5672, 5786
. : milestone, 5729,
iast_GLOBAL (3.649 ms) : 3584, 3715
. : milestone, 3649,
profiling (2.156 ms) : 2137, 2175
. : milestone, 2156,
tracing (1.767 ms) : 1753, 1781
. : milestone, 1767,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~388e3cd480, baseline=1.61.0-SNAPSHOT~1e19001696
dateFormat X
axisFormat %s
section baseline
no_agent (19.312 ms) : 19113, 19511
. : milestone, 19312,
appsec (18.764 ms) : 18576, 18953
. : milestone, 18764,
code_origins (17.821 ms) : 17644, 17998
. : milestone, 17821,
iast (17.907 ms) : 17731, 18082
. : milestone, 17907,
profiling (19.624 ms) : 19427, 19820
. : milestone, 19624,
tracing (17.707 ms) : 17532, 17881
. : milestone, 17707,
section candidate
no_agent (18.267 ms) : 18077, 18457
. : milestone, 18267,
appsec (18.781 ms) : 18591, 18971
. : milestone, 18781,
code_origins (17.804 ms) : 17627, 17981
. : milestone, 17804,
iast (17.916 ms) : 17735, 18098
. : milestone, 17916,
profiling (18.331 ms) : 18149, 18513
. : milestone, 18331,
tracing (17.984 ms) : 17802, 18166
. : milestone, 17984,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~388e3cd480, baseline=1.61.0-SNAPSHOT~1e19001696
dateFormat X
axisFormat %s
section baseline
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (3.924 ms) : 3693, 4154
. : milestone, 3924,
iast (2.263 ms) : 2193, 2332
. : milestone, 2263,
iast_GLOBAL (2.307 ms) : 2237, 2376
. : milestone, 2307,
profiling (2.106 ms) : 2050, 2162
. : milestone, 2106,
tracing (2.076 ms) : 2023, 2129
. : milestone, 2076,
section candidate
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.83 ms) : 3609, 4050
. : milestone, 3830,
iast (2.267 ms) : 2198, 2336
. : milestone, 2267,
iast_GLOBAL (2.309 ms) : 2240, 2378
. : milestone, 2309,
profiling (2.087 ms) : 2032, 2142
. : milestone, 2087,
tracing (2.075 ms) : 2021, 2128
. : milestone, 2075,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~388e3cd480, baseline=1.61.0-SNAPSHOT~1e19001696
dateFormat X
axisFormat %s
section baseline
no_agent (14.899 s) : 14899000, 14899000
. : milestone, 14899000,
appsec (15.224 s) : 15224000, 15224000
. : milestone, 15224000,
iast (18.509 s) : 18509000, 18509000
. : milestone, 18509000,
iast_GLOBAL (17.741 s) : 17741000, 17741000
. : milestone, 17741000,
profiling (15.079 s) : 15079000, 15079000
. : milestone, 15079000,
tracing (14.795 s) : 14795000, 14795000
. : milestone, 14795000,
section candidate
no_agent (14.714 s) : 14714000, 14714000
. : milestone, 14714000,
appsec (14.676 s) : 14676000, 14676000
. : milestone, 14676000,
iast (18.519 s) : 18519000, 18519000
. : milestone, 18519000,
iast_GLOBAL (18.026 s) : 18026000, 18026000
. : milestone, 18026000,
profiling (15.522 s) : 15522000, 15522000
. : milestone, 15522000,
tracing (14.851 s) : 14851000, 14851000
. : milestone, 14851000,
|
f964abb to
87823ae
Compare
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
8c8bf53 to
74c1391
Compare
JVM signal handlers produce different output / formats depending on the platform. For example an Linux-x64 will of course have different register names, but they will be formated as four per line, while the linux-aarch64 will use one register per line. Links to different `os::print_context` implementations * https://github.com/openjdk/jdk/blob/master/src/hotspot/os_cpu/linux_x86/os_linux_x86.cpp#L419 * https://github.com/openjdk/jdk/blob/master/src/hotspot/os_cpu/linux_aarch64/os_linux_aarch64.cpp#L341 * https://github.com/openjdk/jdk/blob/master/src/hotspot/os_cpu/bsd_x86/os_bsd_x86.cpp#L601 * https://github.com/openjdk/jdk/blob/master/src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp#L464
74c1391 to
9b3b0aa
Compare
| * and subsequent sections such as {@code siginfo} and registers will be silently skipped. The | ||
| * resulting {@link datadog.crashtracking.dto.CrashLog} will be marked {@code incomplete}. | ||
| */ | ||
| public final class HotspotCrashLogParser { |
There was a problem hiding this comment.
J9JavacoreParser should also be also maintained here (if applicable) - but it can be done in a follow up PR
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
Adds the registry of the processor from the Hotspot crash log, in the
experimentalfield:Motivation
Additional information
ucontext_tis a POSIX struct passed to signal handlers (third argument when usingSA_SIGINFO). It captures the complete CPU state at the exact moment the signal was raised — i.e., at the point of crash. The JVM emits this information under theRegisterssection in the crash log.Links to different
os::print_contextimplementationsTest script