Add OTEL_TRACES_EXPORTER=otlp configuration#10877
Add OTEL_TRACES_EXPORTER=otlp configuration#10877gh-worker-dd-mergequeue-cf854d[bot] merged 11 commits intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 64 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~62334e0153, baseline=1.61.0-SNAPSHOT~dbb07296ec
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062812
Total [baseline] (8.864 s) : 0, 8864110
Agent [candidate] (1.063 s) : 0, 1062921
Total [candidate] (8.876 s) : 0, 8875687
section iast
Agent [baseline] (1.227 s) : 0, 1227138
Total [baseline] (9.571 s) : 0, 9570502
Agent [candidate] (1.233 s) : 0, 1233176
Total [candidate] (9.571 s) : 0, 9571238
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~62334e0153, baseline=1.61.0-SNAPSHOT~dbb07296ec
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (632.291 ms) : 0, 632291
BytebuddyAgent [candidate] (631.912 ms) : 0, 631912
AgentMeter [baseline] (29.42 ms) : 0, 29420
AgentMeter [candidate] (29.471 ms) : 0, 29471
GlobalTracer [baseline] (258.881 ms) : 0, 258881
GlobalTracer [candidate] (259.325 ms) : 0, 259325
AppSec [baseline] (31.958 ms) : 0, 31958
AppSec [candidate] (31.974 ms) : 0, 31974
Debugger [baseline] (59.963 ms) : 0, 59963
Debugger [candidate] (59.946 ms) : 0, 59946
Remote Config [baseline] (591.324 µs) : 0, 591
Remote Config [candidate] (595.124 µs) : 0, 595
Telemetry [baseline] (8.785 ms) : 0, 8785
Telemetry [candidate] (8.838 ms) : 0, 8838
Flare Poller [baseline] (3.535 ms) : 0, 3535
Flare Poller [candidate] (3.503 ms) : 0, 3503
section iast
crashtracking [baseline] (1.202 ms) : 0, 1202
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (796.112 ms) : 0, 796112
BytebuddyAgent [candidate] (800.806 ms) : 0, 800806
AgentMeter [baseline] (11.336 ms) : 0, 11336
AgentMeter [candidate] (11.381 ms) : 0, 11381
GlobalTracer [baseline] (247.263 ms) : 0, 247263
GlobalTracer [candidate] (248.578 ms) : 0, 248578
AppSec [baseline] (26.507 ms) : 0, 26507
AppSec [candidate] (26.507 ms) : 0, 26507
Debugger [baseline] (68.486 ms) : 0, 68486
Debugger [candidate] (68.598 ms) : 0, 68598
Remote Config [baseline] (525.244 µs) : 0, 525
Remote Config [candidate] (526.049 µs) : 0, 526
Telemetry [baseline] (10.558 ms) : 0, 10558
Telemetry [candidate] (10.345 ms) : 0, 10345
Flare Poller [baseline] (3.737 ms) : 0, 3737
Flare Poller [candidate] (3.646 ms) : 0, 3646
IAST [baseline] (25.32 ms) : 0, 25320
IAST [candidate] (25.398 ms) : 0, 25398
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~62334e0153, baseline=1.61.0-SNAPSHOT~dbb07296ec
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1055619
Total [baseline] (11.084 s) : 0, 11084080
Agent [candidate] (1.057 s) : 0, 1057153
Total [candidate] (11.081 s) : 0, 11080880
section appsec
Agent [baseline] (1.249 s) : 0, 1249298
Total [baseline] (11.18 s) : 0, 11179595
Agent [candidate] (1.247 s) : 0, 1247410
Total [candidate] (11.116 s) : 0, 11116184
section iast
Agent [baseline] (1.247 s) : 0, 1247062
Total [baseline] (11.301 s) : 0, 11300716
Agent [candidate] (1.233 s) : 0, 1232857
Total [candidate] (11.408 s) : 0, 11407824
section profiling
Agent [baseline] (1.2 s) : 0, 1200396
Total [baseline] (11.205 s) : 0, 11205201
Agent [candidate] (1.191 s) : 0, 1190753
Total [candidate] (11.091 s) : 0, 11090978
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~62334e0153, baseline=1.61.0-SNAPSHOT~dbb07296ec
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (627.042 ms) : 0, 627042
BytebuddyAgent [candidate] (628.82 ms) : 0, 628820
AgentMeter [baseline] (29.084 ms) : 0, 29084
AgentMeter [candidate] (29.25 ms) : 0, 29250
GlobalTracer [baseline] (256.615 ms) : 0, 256615
GlobalTracer [candidate] (257.664 ms) : 0, 257664
AppSec [baseline] (31.55 ms) : 0, 31550
AppSec [candidate] (31.758 ms) : 0, 31758
Debugger [baseline] (60.464 ms) : 0, 60464
Debugger [candidate] (60.358 ms) : 0, 60358
Remote Config [baseline] (589.798 µs) : 0, 590
Remote Config [candidate] (586.285 µs) : 0, 586
Telemetry [baseline] (8.075 ms) : 0, 8075
Telemetry [candidate] (8.027 ms) : 0, 8027
Flare Poller [baseline] (5.057 ms) : 0, 5057
Flare Poller [candidate] (3.501 ms) : 0, 3501
section appsec
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (659.622 ms) : 0, 659622
BytebuddyAgent [candidate] (659.247 ms) : 0, 659247
AgentMeter [baseline] (11.972 ms) : 0, 11972
AgentMeter [candidate] (12.039 ms) : 0, 12039
GlobalTracer [baseline] (258.62 ms) : 0, 258620
GlobalTracer [candidate] (258.192 ms) : 0, 258192
AppSec [baseline] (178.337 ms) : 0, 178337
AppSec [candidate] (177.547 ms) : 0, 177547
Debugger [baseline] (66.501 ms) : 0, 66501
Debugger [candidate] (66.167 ms) : 0, 66167
Remote Config [baseline] (619.749 µs) : 0, 620
Remote Config [candidate] (625.274 µs) : 0, 625
Telemetry [baseline] (8.346 ms) : 0, 8346
Telemetry [candidate] (8.441 ms) : 0, 8441
Flare Poller [baseline] (3.603 ms) : 0, 3603
Flare Poller [candidate] (3.606 ms) : 0, 3606
IAST [baseline] (24.262 ms) : 0, 24262
IAST [candidate] (24.117 ms) : 0, 24117
section iast
crashtracking [baseline] (1.214 ms) : 0, 1214
crashtracking [candidate] (1.205 ms) : 0, 1205
BytebuddyAgent [baseline] (810.408 ms) : 0, 810408
BytebuddyAgent [candidate] (800.517 ms) : 0, 800517
AgentMeter [baseline] (11.578 ms) : 0, 11578
AgentMeter [candidate] (11.352 ms) : 0, 11352
GlobalTracer [baseline] (250.29 ms) : 0, 250290
GlobalTracer [candidate] (247.609 ms) : 0, 247609
AppSec [baseline] (27.058 ms) : 0, 27058
AppSec [candidate] (26.649 ms) : 0, 26649
Debugger [baseline] (70.954 ms) : 0, 70954
Debugger [candidate] (70.924 ms) : 0, 70924
Remote Config [baseline] (536.495 µs) : 0, 536
Remote Config [candidate] (531.582 µs) : 0, 532
Telemetry [baseline] (9.239 ms) : 0, 9239
Telemetry [candidate] (9.21 ms) : 0, 9210
Flare Poller [baseline] (3.363 ms) : 0, 3363
Flare Poller [candidate] (3.331 ms) : 0, 3331
IAST [baseline] (25.781 ms) : 0, 25781
IAST [candidate] (25.38 ms) : 0, 25380
section profiling
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.176 ms) : 0, 1176
BytebuddyAgent [baseline] (693.995 ms) : 0, 693995
BytebuddyAgent [candidate] (688.438 ms) : 0, 688438
AgentMeter [baseline] (8.742 ms) : 0, 8742
AgentMeter [candidate] (8.676 ms) : 0, 8676
GlobalTracer [baseline] (218.55 ms) : 0, 218550
GlobalTracer [candidate] (216.935 ms) : 0, 216935
AppSec [baseline] (32.748 ms) : 0, 32748
AppSec [candidate] (32.463 ms) : 0, 32463
Debugger [baseline] (65.766 ms) : 0, 65766
Debugger [candidate] (65.457 ms) : 0, 65457
Remote Config [baseline] (588.159 µs) : 0, 588
Remote Config [candidate] (565.097 µs) : 0, 565
Telemetry [baseline] (7.866 ms) : 0, 7866
Telemetry [candidate] (8.526 ms) : 0, 8526
Flare Poller [baseline] (4.352 ms) : 0, 4352
Flare Poller [candidate] (3.518 ms) : 0, 3518
ProfilingAgent [baseline] (94.949 ms) : 0, 94949
ProfilingAgent [candidate] (93.759 ms) : 0, 93759
Profiling [baseline] (95.514 ms) : 0, 95514
Profiling [candidate] (94.313 ms) : 0, 94313
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~62334e0153, baseline=1.61.0-SNAPSHOT~dbb07296ec
dateFormat X
axisFormat %s
section baseline
no_agent (1.191 ms) : 1180, 1203
. : milestone, 1191,
iast (3.236 ms) : 3191, 3281
. : milestone, 3236,
iast_FULL (5.869 ms) : 5809, 5929
. : milestone, 5869,
iast_GLOBAL (3.627 ms) : 3563, 3691
. : milestone, 3627,
profiling (1.983 ms) : 1967, 2000
. : milestone, 1983,
tracing (1.805 ms) : 1791, 1819
. : milestone, 1805,
section candidate
no_agent (1.188 ms) : 1176, 1199
. : milestone, 1188,
iast (3.232 ms) : 3189, 3276
. : milestone, 3232,
iast_FULL (5.735 ms) : 5679, 5791
. : milestone, 5735,
iast_GLOBAL (3.459 ms) : 3397, 3520
. : milestone, 3459,
profiling (2.146 ms) : 2127, 2166
. : milestone, 2146,
tracing (1.789 ms) : 1775, 1804
. : milestone, 1789,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~62334e0153, baseline=1.61.0-SNAPSHOT~dbb07296ec
dateFormat X
axisFormat %s
section baseline
no_agent (17.456 ms) : 17279, 17634
. : milestone, 17456,
appsec (18.75 ms) : 18564, 18936
. : milestone, 18750,
code_origins (17.95 ms) : 17771, 18128
. : milestone, 17950,
iast (17.899 ms) : 17717, 18081
. : milestone, 17899,
profiling (18.557 ms) : 18371, 18742
. : milestone, 18557,
tracing (17.472 ms) : 17296, 17647
. : milestone, 17472,
section candidate
no_agent (19.244 ms) : 19046, 19443
. : milestone, 19244,
appsec (18.371 ms) : 18184, 18558
. : milestone, 18371,
code_origins (17.785 ms) : 17608, 17962
. : milestone, 17785,
iast (17.667 ms) : 17491, 17842
. : milestone, 17667,
profiling (19.635 ms) : 19440, 19831
. : milestone, 19635,
tracing (17.764 ms) : 17585, 17943
. : milestone, 17764,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 1 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~62334e0153, baseline=1.61.0-SNAPSHOT~dbb07296ec
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (3.741 ms) : 3523, 3960
. : milestone, 3741,
iast (2.259 ms) : 2190, 2328
. : milestone, 2259,
iast_GLOBAL (2.304 ms) : 2235, 2374
. : milestone, 2304,
profiling (2.513 ms) : 2299, 2727
. : milestone, 2513,
tracing (2.086 ms) : 2032, 2140
. : milestone, 2086,
section candidate
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (2.576 ms) : 2518, 2634
. : milestone, 2576,
iast (2.261 ms) : 2192, 2331
. : milestone, 2261,
iast_GLOBAL (2.304 ms) : 2235, 2374
. : milestone, 2304,
profiling (2.095 ms) : 2039, 2151
. : milestone, 2095,
tracing (2.066 ms) : 2012, 2119
. : milestone, 2066,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~62334e0153, baseline=1.61.0-SNAPSHOT~dbb07296ec
dateFormat X
axisFormat %s
section baseline
no_agent (14.978 s) : 14978000, 14978000
. : milestone, 14978000,
appsec (14.929 s) : 14929000, 14929000
. : milestone, 14929000,
iast (18.287 s) : 18287000, 18287000
. : milestone, 18287000,
iast_GLOBAL (17.926 s) : 17926000, 17926000
. : milestone, 17926000,
profiling (14.887 s) : 14887000, 14887000
. : milestone, 14887000,
tracing (14.926 s) : 14926000, 14926000
. : milestone, 14926000,
section candidate
no_agent (15.523 s) : 15523000, 15523000
. : milestone, 15523000,
appsec (14.832 s) : 14832000, 14832000
. : milestone, 14832000,
iast (18.266 s) : 18266000, 18266000
. : milestone, 18266000,
iast_GLOBAL (17.876 s) : 17876000, 17876000
. : milestone, 17876000,
profiling (14.662 s) : 14662000, 14662000
. : milestone, 14662000,
tracing (14.946 s) : 14946000, 14946000
. : milestone, 14946000,
|
| otelEnvKey | otelEnvValue || metricType | metricValue | metricNamespace | metricName | tagsOtelValue | ||
| 'OTEL_METRICS_EXPORTER' | 'otlp' || 'count' | 1 | 'tracers' | 'otel.env.unsupported' | 'config_opentelemetry:otel_metrics_exporter' | ||
| 'OTEL_TRACES_EXPORTER' | 'otlp' || 'count' | 1 | 'tracers' | 'otel.env.unsupported' | 'config_opentelemetry:otel_traces_exporter' | ||
| 'OTEL_TRACES_EXPORTER' | 'zipkin' || 'count' | 1 | 'tracers' | 'otel.env.unsupported' | 'config_opentelemetry:otel_traces_exporter' |
There was a problem hiding this comment.
This test seems to just be checking that the otel.env.unsupported metric is reported when an otel environment variable is discovered with an unsupported value; since this PR adds support for OTEL_TRACES_EXPORTER=otlp, I changed the test value to some other unsupported value -- "zipkin"
Reference: https://opentelemetry.io/docs/specs/otel/configuration/sdk-environment-variables/#exporter-selection
| public boolean isOtlpTracesExporterEnabled() { | ||
| return "otlp".equalsIgnoreCase(traceOtelExporter); | ||
| } |
There was a problem hiding this comment.
This method is not currently used, but will be used in a follow-up PR.
I previously had an additional method for getTraceOtelExporter, to just get the value, but I removed this as it was not currently used, and my immediate follow-up PRs will not use it.
It will only become necessary if we support the other OTEL_TRACES_EXPORTER fields in the future.
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
Co-authored-by: Stuart McCulloch <stuart.mcculloch@datadoghq.com>
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
Creates new configuration for otlp traces export mode.
Motivation
RFC: https://docs.google.com/document/d/1AsUrJxjJavLvSG33kUAJLYzGU8IYgrnf1SMbFDsuGmo/edit?pli=1&tab=t.0#heading=h.wbjhtxw8dxti
New configuration for enabled "otlp export" mode. Follow-up PRs will implement a new, otlp-conformant trace serialization mechanism if this configuration is enabled.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.