-
Notifications
You must be signed in to change notification settings - Fork 332
Add OTEL_TRACES_EXPORTER=otlp configuration #10877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
1062a73
db2e7d0
0875943
5e2ea6c
20af2bd
2809404
923c880
8b7c31d
4c9228d
c0a51a9
62334e0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -199,7 +199,7 @@ class OtelEnvMetricCollectorImplTest extends DDSpecification { | |
| where: | ||
| otelEnvKey | otelEnvValue || metricType | metricValue | metricNamespace | metricName | tagsOtelValue | ||
| 'OTEL_METRICS_EXPORTER' | 'otlp' || 'count' | 1 | 'tracers' | 'otel.env.unsupported' | 'config_opentelemetry:otel_metrics_exporter' | ||
| 'OTEL_TRACES_EXPORTER' | 'otlp' || 'count' | 1 | 'tracers' | 'otel.env.unsupported' | 'config_opentelemetry:otel_traces_exporter' | ||
| 'OTEL_TRACES_EXPORTER' | 'zipkin' || 'count' | 1 | 'tracers' | 'otel.env.unsupported' | 'config_opentelemetry:otel_traces_exporter' | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This test seems to just be checking that the Reference: https://opentelemetry.io/docs/specs/otel/configuration/sdk-environment-variables/#exporter-selection |
||
| 'OTEL_LOGS_EXPORTER' | 'otlp' || 'count' | 1 | 'tracers' | 'otel.env.unsupported' | 'config_opentelemetry:otel_logs_exporter' | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method is not currently used, but will be used in a follow-up PR.
I previously had an additional method for
getTraceOtelExporter, to just get the value, but I removed this as it was not currently used, and my immediate follow-up PRs will not use it.It will only become necessary if we support the other OTEL_TRACES_EXPORTER fields in the future.