Pin system-tests to SHA with pinned download-artifact action#10889
Pin system-tests to SHA with pinned download-artifact action#10889jandro996 wants to merge 3 commits intorelease/v1.60.xfrom
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
Update DataDog/system-tests ref from 61f7ee29e7432cba821a4d303c95929160bd23fd to ab6ccde3946ded935e7b1ffddf260b982275795e which pins actions/download-artifact to a full commit SHA, fixing the enterprise policy violation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
b0ebc00 to
2983bc2
Compare
init Merge branch 'master' into mhlidd/update_telemetry_key_normalization Merge branch 'master' into mhlidd/update_telemetry_key_normalization Merge branch 'master' into mhlidd/update_telemetry_key_normalization Co-authored-by: devflow.devflow-routing-intake <devflow.devflow-routing-intake@kubernetes.us1.ddbuild.io>
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~d96eff8552, baseline=1.60.0~0f5d84f2c4
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1067244
Total [baseline] (8.759 s) : 0, 8758621
Agent [candidate] (1.063 s) : 0, 1062839
Total [candidate] (8.716 s) : 0, 8715602
section iast
Agent [baseline] (1.239 s) : 0, 1238522
Total [baseline] (9.38 s) : 0, 9380108
Agent [candidate] (1.229 s) : 0, 1229376
Total [candidate] (9.348 s) : 0, 9347985
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~d96eff8552, baseline=1.60.0~0f5d84f2c4
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.214 ms) : 0, 1214
BytebuddyAgent [baseline] (628.277 ms) : 0, 628277
BytebuddyAgent [candidate] (626.037 ms) : 0, 626037
AgentMeter [baseline] (29.173 ms) : 0, 29173
AgentMeter [candidate] (29.059 ms) : 0, 29059
GlobalTracer [baseline] (258.518 ms) : 0, 258518
GlobalTracer [candidate] (257.253 ms) : 0, 257253
AppSec [baseline] (33.084 ms) : 0, 33084
AppSec [candidate] (32.954 ms) : 0, 32954
Debugger [baseline] (63.363 ms) : 0, 63363
Debugger [candidate] (62.688 ms) : 0, 62688
Remote Config [baseline] (610.677 µs) : 0, 611
Remote Config [candidate] (607.131 µs) : 0, 607
Telemetry [baseline] (12.196 ms) : 0, 12196
Telemetry [candidate] (9.839 ms) : 0, 9839
Flare Poller [baseline] (4.56 ms) : 0, 4560
Flare Poller [candidate] (6.931 ms) : 0, 6931
section iast
crashtracking [baseline] (1.22 ms) : 0, 1220
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (801.602 ms) : 0, 801602
BytebuddyAgent [candidate] (794.146 ms) : 0, 794146
AgentMeter [baseline] (11.551 ms) : 0, 11551
AgentMeter [candidate] (11.311 ms) : 0, 11311
GlobalTracer [baseline] (248.471 ms) : 0, 248471
GlobalTracer [candidate] (247.208 ms) : 0, 247208
AppSec [baseline] (34.137 ms) : 0, 34137
AppSec [candidate] (34.886 ms) : 0, 34886
Debugger [baseline] (65.47 ms) : 0, 65470
Debugger [candidate] (64.792 ms) : 0, 64792
Remote Config [baseline] (529.028 µs) : 0, 529
Remote Config [candidate] (532.073 µs) : 0, 532
Telemetry [baseline] (8.607 ms) : 0, 8607
Telemetry [candidate] (8.707 ms) : 0, 8707
Flare Poller [baseline] (3.476 ms) : 0, 3476
Flare Poller [candidate] (3.464 ms) : 0, 3464
IAST [baseline] (27.175 ms) : 0, 27175
IAST [candidate] (26.939 ms) : 0, 26939
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~d96eff8552, baseline=1.60.0~0f5d84f2c4
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.072 s) : 0, 1071927
Total [baseline] (10.924 s) : 0, 10924136
Agent [candidate] (1.065 s) : 0, 1065086
Total [candidate] (10.764 s) : 0, 10763891
section appsec
Agent [baseline] (1.24 s) : 0, 1239929
Total [baseline] (11.079 s) : 0, 11078868
Agent [candidate] (1.236 s) : 0, 1236260
Total [candidate] (11.02 s) : 0, 11019922
section iast
Agent [baseline] (1.239 s) : 0, 1239255
Total [baseline] (11.178 s) : 0, 11177762
Agent [candidate] (1.23 s) : 0, 1230443
Total [candidate] (11.18 s) : 0, 11179623
section profiling
Agent [baseline] (1.2 s) : 0, 1200423
Total [baseline] (10.977 s) : 0, 10976985
Agent [candidate] (1.202 s) : 0, 1201528
Total [candidate] (11.094 s) : 0, 11094236
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~d96eff8552, baseline=1.60.0~0f5d84f2c4
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (631.289 ms) : 0, 631289
BytebuddyAgent [candidate] (627.417 ms) : 0, 627417
AgentMeter [baseline] (29.263 ms) : 0, 29263
AgentMeter [candidate] (29.07 ms) : 0, 29070
GlobalTracer [baseline] (259.097 ms) : 0, 259097
GlobalTracer [candidate] (257.946 ms) : 0, 257946
AppSec [baseline] (33.257 ms) : 0, 33257
AppSec [candidate] (33.133 ms) : 0, 33133
Debugger [baseline] (64.993 ms) : 0, 64993
Debugger [candidate] (65.937 ms) : 0, 65937
Remote Config [baseline] (611.213 µs) : 0, 611
Remote Config [candidate] (623.572 µs) : 0, 624
Telemetry [baseline] (10.689 ms) : 0, 10689
Telemetry [candidate] (9.93 ms) : 0, 9930
Flare Poller [baseline] (5.311 ms) : 0, 5311
Flare Poller [candidate] (3.713 ms) : 0, 3713
section appsec
crashtracking [baseline] (1.201 ms) : 0, 1201
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (658.713 ms) : 0, 658713
BytebuddyAgent [candidate] (655.015 ms) : 0, 655015
AgentMeter [baseline] (12.026 ms) : 0, 12026
AgentMeter [candidate] (11.913 ms) : 0, 11913
GlobalTracer [baseline] (258.888 ms) : 0, 258888
GlobalTracer [candidate] (258.382 ms) : 0, 258382
IAST [baseline] (25.391 ms) : 0, 25391
IAST [candidate] (25.432 ms) : 0, 25432
AppSec [baseline] (167.676 ms) : 0, 167676
AppSec [candidate] (167.902 ms) : 0, 167902
Debugger [baseline] (66.33 ms) : 0, 66330
Debugger [candidate] (66.664 ms) : 0, 66664
Remote Config [baseline] (668.572 µs) : 0, 669
Remote Config [candidate] (695.856 µs) : 0, 696
Telemetry [baseline] (9.256 ms) : 0, 9256
Telemetry [candidate] (9.308 ms) : 0, 9308
Flare Poller [baseline] (3.699 ms) : 0, 3699
Flare Poller [candidate] (3.729 ms) : 0, 3729
section iast
crashtracking [baseline] (1.207 ms) : 0, 1207
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (801.403 ms) : 0, 801403
BytebuddyAgent [candidate] (794.32 ms) : 0, 794320
AgentMeter [baseline] (11.539 ms) : 0, 11539
AgentMeter [candidate] (11.291 ms) : 0, 11291
GlobalTracer [baseline] (248.7 ms) : 0, 248700
GlobalTracer [candidate] (247.556 ms) : 0, 247556
IAST [baseline] (27.197 ms) : 0, 27197
IAST [candidate] (27.067 ms) : 0, 27067
AppSec [baseline] (32.266 ms) : 0, 32266
AppSec [candidate] (32.186 ms) : 0, 32186
Debugger [baseline] (68.382 ms) : 0, 68382
Debugger [candidate] (68.225 ms) : 0, 68225
Remote Config [baseline] (533.221 µs) : 0, 533
Remote Config [candidate] (540.276 µs) : 0, 540
Telemetry [baseline] (8.519 ms) : 0, 8519
Telemetry [candidate] (8.619 ms) : 0, 8619
Flare Poller [baseline] (3.46 ms) : 0, 3460
Flare Poller [candidate] (3.432 ms) : 0, 3432
section profiling
crashtracking [baseline] (1.173 ms) : 0, 1173
crashtracking [candidate] (1.177 ms) : 0, 1177
BytebuddyAgent [baseline] (687.9 ms) : 0, 687900
BytebuddyAgent [candidate] (688.372 ms) : 0, 688372
AgentMeter [baseline] (8.633 ms) : 0, 8633
AgentMeter [candidate] (8.688 ms) : 0, 8688
GlobalTracer [baseline] (217.429 ms) : 0, 217429
GlobalTracer [candidate] (217.879 ms) : 0, 217879
AppSec [baseline] (32.711 ms) : 0, 32711
AppSec [candidate] (32.89 ms) : 0, 32890
Debugger [baseline] (67.605 ms) : 0, 67605
Debugger [candidate] (67.667 ms) : 0, 67667
Remote Config [baseline] (638.118 µs) : 0, 638
Remote Config [candidate] (639.88 µs) : 0, 640
Telemetry [baseline] (9.009 ms) : 0, 9009
Telemetry [candidate] (9.052 ms) : 0, 9052
Flare Poller [baseline] (3.83 ms) : 0, 3830
Flare Poller [candidate] (3.779 ms) : 0, 3779
ProfilingAgent [baseline] (100.252 ms) : 0, 100252
ProfilingAgent [candidate] (100.129 ms) : 0, 100129
Profiling [baseline] (100.847 ms) : 0, 100847
Profiling [candidate] (100.711 ms) : 0, 100711
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 3 performance regressions! Performance is the same for 15 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~d96eff8552, baseline=1.60.0~0f5d84f2c4
dateFormat X
axisFormat %s
section baseline
no_agent (17.943 ms) : 17765, 18121
. : milestone, 17943,
appsec (18.987 ms) : 18796, 19178
. : milestone, 18987,
code_origins (17.537 ms) : 17361, 17714
. : milestone, 17537,
iast (17.842 ms) : 17663, 18020
. : milestone, 17842,
profiling (19.073 ms) : 18881, 19264
. : milestone, 19073,
tracing (18.775 ms) : 18589, 18961
. : milestone, 18775,
section candidate
no_agent (18.376 ms) : 18186, 18566
. : milestone, 18376,
appsec (18.619 ms) : 18430, 18808
. : milestone, 18619,
code_origins (17.57 ms) : 17394, 17747
. : milestone, 17570,
iast (17.981 ms) : 17797, 18164
. : milestone, 17981,
profiling (18.703 ms) : 18518, 18889
. : milestone, 18703,
tracing (17.929 ms) : 17749, 18108
. : milestone, 17929,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~d96eff8552, baseline=1.60.0~0f5d84f2c4
dateFormat X
axisFormat %s
section baseline
no_agent (1.176 ms) : 1165, 1187
. : milestone, 1176,
iast (3.281 ms) : 3232, 3330
. : milestone, 3281,
iast_FULL (6.014 ms) : 5953, 6074
. : milestone, 6014,
iast_GLOBAL (3.478 ms) : 3416, 3540
. : milestone, 3478,
profiling (2.005 ms) : 1987, 2023
. : milestone, 2005,
tracing (1.75 ms) : 1736, 1765
. : milestone, 1750,
section candidate
no_agent (1.257 ms) : 1245, 1269
. : milestone, 1257,
iast (3.176 ms) : 3134, 3218
. : milestone, 3176,
iast_FULL (5.988 ms) : 5928, 6049
. : milestone, 5988,
iast_GLOBAL (3.672 ms) : 3611, 3733
. : milestone, 3672,
profiling (1.967 ms) : 1949, 1985
. : milestone, 1967,
tracing (1.79 ms) : 1775, 1805
. : milestone, 1790,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~d96eff8552, baseline=1.60.0~0f5d84f2c4
dateFormat X
axisFormat %s
section baseline
no_agent (1.481 ms) : 1469, 1492
. : milestone, 1481,
appsec (2.536 ms) : 2481, 2591
. : milestone, 2536,
iast (2.266 ms) : 2197, 2335
. : milestone, 2266,
iast_GLOBAL (2.31 ms) : 2240, 2380
. : milestone, 2310,
profiling (2.086 ms) : 2031, 2141
. : milestone, 2086,
tracing (2.091 ms) : 2037, 2145
. : milestone, 2091,
section candidate
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (3.753 ms) : 3536, 3969
. : milestone, 3753,
iast (2.261 ms) : 2192, 2330
. : milestone, 2261,
iast_GLOBAL (2.317 ms) : 2247, 2386
. : milestone, 2317,
profiling (2.119 ms) : 2062, 2176
. : milestone, 2119,
tracing (2.083 ms) : 2029, 2137
. : milestone, 2083,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~d96eff8552, baseline=1.60.0~0f5d84f2c4
dateFormat X
axisFormat %s
section baseline
no_agent (15.663 s) : 15663000, 15663000
. : milestone, 15663000,
appsec (14.869 s) : 14869000, 14869000
. : milestone, 14869000,
iast (18.364 s) : 18364000, 18364000
. : milestone, 18364000,
iast_GLOBAL (17.838 s) : 17838000, 17838000
. : milestone, 17838000,
profiling (15.026 s) : 15026000, 15026000
. : milestone, 15026000,
tracing (14.803 s) : 14803000, 14803000
. : milestone, 14803000,
section candidate
no_agent (15.288 s) : 15288000, 15288000
. : milestone, 15288000,
appsec (15.057 s) : 15057000, 15057000
. : milestone, 15057000,
iast (18.199 s) : 18199000, 18199000
. : milestone, 18199000,
iast_GLOBAL (17.59 s) : 17590000, 17590000
. : milestone, 17590000,
profiling (14.948 s) : 14948000, 14948000
. : milestone, 14948000,
tracing (14.862 s) : 14862000, 14862000
. : milestone, 14862000,
|
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
|
Instead of adjusted the pinned SHA, I opted to create a Then, I pinned this Looks green now... |
Thanks a lot @sarahchen6! I'll close this one |
Summary
DataDog/system-testspinned ref from61f7ee29to50e03c1d("Nccatoni/sha pin" Update the enablement logic for allocation and liveheap #6492)actions/download-artifact@v4(non-SHA pin) internally, violating the DataDog enterprise GitHub Actions policyactions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093(SHA-pinned), compliant with the policyrelease/v1.60.xwhere "Check system tests success" was stuck as "Expected — Waiting"Backport fix for #10722 to release/v1.60.x
🤖 Generated with Claude Code