Skip to content

Consider empty parameters as null in TestIdentifier creation #10902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 2 commits into from
Mar 19, 2026
+3 −2
Merged

Consider empty parameters as null in TestIdentifier creation #10902

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f3807f
feat: consider empty parameters as null
daniel-mohedano Mar 19, 2026
f8fe354
Merge branch 'master' into daniel.mohedano/test-identifier-null-param…
daniel-mohedano Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions internal-api/src/main/java/datadog/trace/api/civisibility/config/TestIdentifier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package datadog.trace.api.civisibility.config;

import datadog.trace.util.HashingUtils;
import datadog.trace.util.Strings;
import java.util.Objects;
import javax.annotation.Nullable;

Expand All @@ -17,12 +18,12 @@ public class TestIdentifier {

public TestIdentifier(String suite, String name, @Nullable String parameters) {
this.fqn = new TestFQN(suite, name);
this.parameters = parameters;
this.parameters = Strings.isNotBlank(parameters) ? parameters : null;
}

public TestIdentifier(TestFQN testFQN, @Nullable String parameters) {
this.fqn = testFQN;
this.parameters = parameters;
this.parameters = Strings.isNotBlank(parameters) ? parameters : null;
}

public String getSuite() {
Expand Down
Loading