Align gRPC status code extraction with CSS v1.3.0 spec#10910
Closed
Align gRPC status code extraction with CSS v1.3.0 spec#10910
Conversation
The client-side stats gRPC status code extraction previously only checked the `rpc.grpc.status_code` tag. This aligns with the Go reference implementation by checking 4 tag keys in priority order: rpc.grpc.status_code, grpc.code, rpc.grpc.status.code, grpc.status.code (first non-empty wins). This ensures correct status extraction for OTel-bridged spans and third-party instrumentations that may use different tag keys. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~a189a90b56, baseline=1.61.0-SNAPSHOT~126645d10a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1060734
Total [baseline] (8.896 s) : 0, 8896144
Agent [candidate] (1.062 s) : 0, 1061578
Total [candidate] (8.864 s) : 0, 8863622
section iast
Agent [baseline] (1.242 s) : 0, 1241903
Total [baseline] (9.612 s) : 0, 9612129
Agent [candidate] (1.227 s) : 0, 1227251
Total [candidate] (9.567 s) : 0, 9566616
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~a189a90b56, baseline=1.61.0-SNAPSHOT~126645d10a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (630.332 ms) : 0, 630332
BytebuddyAgent [candidate] (630.936 ms) : 0, 630936
AgentMeter [baseline] (29.235 ms) : 0, 29235
AgentMeter [candidate] (29.284 ms) : 0, 29284
GlobalTracer [baseline] (257.189 ms) : 0, 257189
GlobalTracer [candidate] (257.985 ms) : 0, 257985
AppSec [baseline] (31.734 ms) : 0, 31734
AppSec [candidate] (31.822 ms) : 0, 31822
Debugger [baseline] (59.8 ms) : 0, 59800
Debugger [candidate] (59.692 ms) : 0, 59692
Remote Config [baseline] (584.223 µs) : 0, 584
Remote Config [candidate] (584.505 µs) : 0, 585
Telemetry [baseline] (8.8 ms) : 0, 8800
Telemetry [candidate] (10.367 ms) : 0, 10367
Flare Poller [baseline] (5.765 ms) : 0, 5765
Flare Poller [candidate] (3.545 ms) : 0, 3545
section iast
crashtracking [baseline] (1.217 ms) : 0, 1217
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (807.819 ms) : 0, 807819
BytebuddyAgent [candidate] (796.067 ms) : 0, 796067
AgentMeter [baseline] (11.871 ms) : 0, 11871
AgentMeter [candidate] (11.414 ms) : 0, 11414
GlobalTracer [baseline] (248.595 ms) : 0, 248595
GlobalTracer [candidate] (247.371 ms) : 0, 247371
IAST [baseline] (25.516 ms) : 0, 25516
IAST [candidate] (25.359 ms) : 0, 25359
AppSec [baseline] (26.628 ms) : 0, 26628
AppSec [candidate] (26.507 ms) : 0, 26507
Debugger [baseline] (69.157 ms) : 0, 69157
Debugger [candidate] (68.708 ms) : 0, 68708
Remote Config [baseline] (536.253 µs) : 0, 536
Remote Config [candidate] (523.765 µs) : 0, 524
Telemetry [baseline] (10.354 ms) : 0, 10354
Telemetry [candidate] (10.304 ms) : 0, 10304
Flare Poller [baseline] (3.78 ms) : 0, 3780
Flare Poller [candidate] (3.665 ms) : 0, 3665
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~a189a90b56, baseline=1.61.0-SNAPSHOT~126645d10a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062905
Total [baseline] (11.141 s) : 0, 11140883
Agent [candidate] (1.058 s) : 0, 1057527
Total [candidate] (11.12 s) : 0, 11120224
section appsec
Agent [baseline] (1.249 s) : 0, 1249425
Total [baseline] (11.222 s) : 0, 11221789
Agent [candidate] (1.25 s) : 0, 1250470
Total [candidate] (11.161 s) : 0, 11160810
section iast
Agent [baseline] (1.237 s) : 0, 1237235
Total [baseline] (11.361 s) : 0, 11361087
Agent [candidate] (1.228 s) : 0, 1227826
Total [candidate] (11.355 s) : 0, 11354990
section profiling
Agent [baseline] (1.181 s) : 0, 1181136
Total [baseline] (11.226 s) : 0, 11225658
Agent [candidate] (1.192 s) : 0, 1191889
Total [candidate] (11.111 s) : 0, 11110687
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~a189a90b56, baseline=1.61.0-SNAPSHOT~126645d10a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.214 ms) : 0, 1214
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (633.287 ms) : 0, 633287
BytebuddyAgent [candidate] (628.434 ms) : 0, 628434
AgentMeter [baseline] (29.511 ms) : 0, 29511
AgentMeter [candidate] (29.285 ms) : 0, 29285
GlobalTracer [baseline] (258.631 ms) : 0, 258631
GlobalTracer [candidate] (257.371 ms) : 0, 257371
AppSec [baseline] (31.66 ms) : 0, 31660
AppSec [candidate] (31.774 ms) : 0, 31774
Debugger [baseline] (60.391 ms) : 0, 60391
Debugger [candidate] (60.544 ms) : 0, 60544
Remote Config [baseline] (587.32 µs) : 0, 587
Remote Config [candidate] (586.212 µs) : 0, 586
Telemetry [baseline] (8.008 ms) : 0, 8008
Telemetry [candidate] (8.042 ms) : 0, 8042
Flare Poller [baseline] (3.518 ms) : 0, 3518
Flare Poller [candidate] (4.305 ms) : 0, 4305
section appsec
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (659.47 ms) : 0, 659470
BytebuddyAgent [candidate] (659.904 ms) : 0, 659904
AgentMeter [baseline] (12.09 ms) : 0, 12090
AgentMeter [candidate] (12.193 ms) : 0, 12193
GlobalTracer [baseline] (258.334 ms) : 0, 258334
GlobalTracer [candidate] (259.201 ms) : 0, 259201
IAST [baseline] (24.24 ms) : 0, 24240
IAST [candidate] (24.439 ms) : 0, 24439
AppSec [baseline] (178.766 ms) : 0, 178766
AppSec [candidate] (178.646 ms) : 0, 178646
Debugger [baseline] (65.68 ms) : 0, 65680
Debugger [candidate] (66.093 ms) : 0, 66093
Remote Config [baseline] (625.446 µs) : 0, 625
Remote Config [candidate] (622.556 µs) : 0, 623
Telemetry [baseline] (8.342 ms) : 0, 8342
Telemetry [candidate] (8.326 ms) : 0, 8326
Flare Poller [baseline] (4.444 ms) : 0, 4444
Flare Poller [candidate] (3.568 ms) : 0, 3568
section iast
crashtracking [baseline] (1.204 ms) : 0, 1204
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (802.558 ms) : 0, 802558
BytebuddyAgent [candidate] (794.91 ms) : 0, 794910
AgentMeter [baseline] (11.671 ms) : 0, 11671
AgentMeter [candidate] (11.451 ms) : 0, 11451
GlobalTracer [baseline] (248.939 ms) : 0, 248939
GlobalTracer [candidate] (247.954 ms) : 0, 247954
IAST [baseline] (25.569 ms) : 0, 25569
IAST [candidate] (25.35 ms) : 0, 25350
AppSec [baseline] (26.717 ms) : 0, 26717
AppSec [candidate] (26.606 ms) : 0, 26606
Debugger [baseline] (71.359 ms) : 0, 71359
Debugger [candidate] (71.177 ms) : 0, 71177
Remote Config [baseline] (533.249 µs) : 0, 533
Remote Config [candidate] (531.314 µs) : 0, 531
Telemetry [baseline] (9.15 ms) : 0, 9150
Telemetry [candidate] (9.232 ms) : 0, 9232
Flare Poller [baseline] (3.381 ms) : 0, 3381
Flare Poller [candidate] (3.357 ms) : 0, 3357
section profiling
crashtracking [baseline] (1.172 ms) : 0, 1172
crashtracking [candidate] (1.17 ms) : 0, 1170
BytebuddyAgent [baseline] (681.482 ms) : 0, 681482
BytebuddyAgent [candidate] (688.386 ms) : 0, 688386
AgentMeter [baseline] (8.978 ms) : 0, 8978
AgentMeter [candidate] (9.039 ms) : 0, 9039
GlobalTracer [baseline] (214.914 ms) : 0, 214914
GlobalTracer [candidate] (217.009 ms) : 0, 217009
AppSec [baseline] (31.935 ms) : 0, 31935
AppSec [candidate] (32.415 ms) : 0, 32415
Debugger [baseline] (65.266 ms) : 0, 65266
Debugger [candidate] (65.381 ms) : 0, 65381
Remote Config [baseline] (570.111 µs) : 0, 570
Remote Config [candidate] (568.018 µs) : 0, 568
Telemetry [baseline] (7.715 ms) : 0, 7715
Telemetry [candidate] (8.543 ms) : 0, 8543
Flare Poller [baseline] (4.213 ms) : 0, 4213
Flare Poller [candidate] (3.525 ms) : 0, 3525
ProfilingAgent [baseline] (94.265 ms) : 0, 94265
ProfilingAgent [candidate] (94.627 ms) : 0, 94627
Profiling [baseline] (94.833 ms) : 0, 94833
Profiling [candidate] (95.185 ms) : 0, 95185
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 1 performance regressions! Performance is the same for 16 metrics, 15 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~a189a90b56, baseline=1.61.0-SNAPSHOT~126645d10a
dateFormat X
axisFormat %s
section baseline
no_agent (19.146 ms) : 18949, 19344
. : milestone, 19146,
appsec (18.347 ms) : 18160, 18533
. : milestone, 18347,
code_origins (17.76 ms) : 17589, 17932
. : milestone, 17760,
iast (18.558 ms) : 18373, 18744
. : milestone, 18558,
profiling (19.896 ms) : 19688, 20103
. : milestone, 19896,
tracing (17.951 ms) : 17774, 18128
. : milestone, 17951,
section candidate
no_agent (19.192 ms) : 18994, 19389
. : milestone, 19192,
appsec (18.288 ms) : 18105, 18472
. : milestone, 18288,
code_origins (17.678 ms) : 17502, 17853
. : milestone, 17678,
iast (17.657 ms) : 17483, 17831
. : milestone, 17657,
profiling (18.85 ms) : 18664, 19036
. : milestone, 18850,
tracing (19.05 ms) : 18853, 19247
. : milestone, 19050,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~a189a90b56, baseline=1.61.0-SNAPSHOT~126645d10a
dateFormat X
axisFormat %s
section baseline
no_agent (1.196 ms) : 1184, 1208
. : milestone, 1196,
iast (3.17 ms) : 3127, 3212
. : milestone, 3170,
iast_FULL (5.981 ms) : 5921, 6042
. : milestone, 5981,
iast_GLOBAL (3.6 ms) : 3543, 3657
. : milestone, 3600,
profiling (1.997 ms) : 1980, 2014
. : milestone, 1997,
tracing (1.745 ms) : 1732, 1759
. : milestone, 1745,
section candidate
no_agent (1.18 ms) : 1169, 1192
. : milestone, 1180,
iast (3.202 ms) : 3161, 3242
. : milestone, 3202,
iast_FULL (5.802 ms) : 5745, 5860
. : milestone, 5802,
iast_GLOBAL (3.543 ms) : 3497, 3588
. : milestone, 3543,
profiling (1.944 ms) : 1924, 1963
. : milestone, 1944,
tracing (1.854 ms) : 1839, 1869
. : milestone, 1854,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~a189a90b56, baseline=1.61.0-SNAPSHOT~126645d10a
dateFormat X
axisFormat %s
section baseline
no_agent (15.056 s) : 15056000, 15056000
. : milestone, 15056000,
appsec (14.67 s) : 14670000, 14670000
. : milestone, 14670000,
iast (18.695 s) : 18695000, 18695000
. : milestone, 18695000,
iast_GLOBAL (18.099 s) : 18099000, 18099000
. : milestone, 18099000,
profiling (15.342 s) : 15342000, 15342000
. : milestone, 15342000,
tracing (14.74 s) : 14740000, 14740000
. : milestone, 14740000,
section candidate
no_agent (14.772 s) : 14772000, 14772000
. : milestone, 14772000,
appsec (14.524 s) : 14524000, 14524000
. : milestone, 14524000,
iast (17.958 s) : 17958000, 17958000
. : milestone, 17958000,
iast_GLOBAL (18.151 s) : 18151000, 18151000
. : milestone, 18151000,
profiling (15.048 s) : 15048000, 15048000
. : milestone, 15048000,
tracing (14.64 s) : 14640000, 14640000
. : milestone, 14640000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~a189a90b56, baseline=1.61.0-SNAPSHOT~126645d10a
dateFormat X
axisFormat %s
section baseline
no_agent (1.47 ms) : 1459, 1482
. : milestone, 1470,
appsec (3.777 ms) : 3554, 3999
. : milestone, 3777,
iast (2.252 ms) : 2183, 2321
. : milestone, 2252,
iast_GLOBAL (2.303 ms) : 2233, 2372
. : milestone, 2303,
profiling (2.12 ms) : 2062, 2177
. : milestone, 2120,
tracing (2.054 ms) : 2001, 2107
. : milestone, 2054,
section candidate
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (2.569 ms) : 2511, 2627
. : milestone, 2569,
iast (2.253 ms) : 2184, 2322
. : milestone, 2253,
iast_GLOBAL (2.298 ms) : 2229, 2368
. : milestone, 2298,
profiling (2.104 ms) : 2048, 2160
. : milestone, 2104,
tracing (2.067 ms) : 2013, 2121
. : milestone, 2067,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rpc.grpc.status_code→grpc.code→rpc.grpc.status.code→grpc.status.code(first non-empty wins)rpc.grpc.status_codeTest plan
Related PRs
Part of cross-tracer CSS v1.3.0 alignment effort.
🤖 Generated with Claude Code