Conversation
sarahchen6
added
tag: no release notes
sarahchen6
requested review from
AlexeyKuznetsov-DD and
randomanderson
and removed request for
a team
| rules: | ||
| - if: $CI_COMMIT_BRANCH == "master" | ||
| when: on_success | ||
| - if: '$CI_COMMIT_BRANCH =~ /^mq-working-branch-/' | ||
| when: on_success | ||
| - if: '$CI_COMMIT_BRANCH =~ /^gh-readonly-queue/' | ||
| when: on_success |
There was a problem hiding this comment.
How about to introduce a rule master_and_mq_only ? similar to master_only and reuse it?
There was a problem hiding this comment.
If you override job rules with *master_only (or *master_and_mq_only), you can't append other rules alongside it, so it wouldn't be reusable in other existing jobs.
We could still put it here for readability ? Or leave it for the future when another job with the same rules is defined
There was a problem hiding this comment.
My idea was that probably we would have more than 1 place that will be master + MQ ONLY filter...
So it is not override, but just do not repeat your self?
Would it make sense?
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
there was nothing to merge |
2 participants
What Does This Do
Run SSI smoke tests on the merge queue as well as
masterMotivation
Previously SSI smoke tests were run only on
master. In order to prevent regressions from being introduced tomasterwhile also keeping PR iteration feedback loops low, we should run these smoke tests on the merge queues as well.Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.