Skip to content

Add SSI smoke tests to merge queue #11011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sarahchen6 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add SSI smoke tests to merge queue #11011

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .gitlab-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,7 +770,13 @@ test_smoke:

test_ssi_smoke:
extends: .test_job
rules: *master_only
rules:
- if: $CI_COMMIT_BRANCH == "master"
when: on_success
- if: '$CI_COMMIT_BRANCH =~ /^mq-working-branch-/'
when: on_success
- if: '$CI_COMMIT_BRANCH =~ /^gh-readonly-queue/'
when: on_success
Comment on lines +773 to +779
Copy link
Copy Markdown
Contributor

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about to introduce a rule master_and_mq_only ? similar to master_only and reuse it?

Copy link
Copy Markdown
Contributor Author

@sarahchen6 sarahchen6 Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you override job rules with *master_only (or *master_and_mq_only), you can't append other rules alongside it, so it wouldn't be reusable in other existing jobs.

We could still put it here for readability ? Or leave it for the future when another job with the same rules is defined

Copy link
Copy Markdown
Contributor

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My idea was that probably we would have more than 1 place that will be master + MQ ONLY filter...
So it is not override, but just do not repeat your self?
Would it make sense?

Copy link
Copy Markdown
Contributor Author

@sarahchen6 sarahchen6 Mar 31, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other jobs that have master + MQ (here and here) also have a few other specifications, so we only have this one instance of master + MQ 😬

Copy link
Copy Markdown
Contributor

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK than!

variables:
GRADLE_TARGET: "stageMainDist :smokeTest"
CACHE_TYPE: "smoke"
Expand Down
Loading