Mark broken synapse-3.0 passthru tests as @Flaky#11016
Closed
jordan-wong wants to merge 1 commit intomasterfrom
Closed
Mark broken synapse-3.0 passthru tests as @Flaky#11016jordan-wong wants to merge 1 commit intomasterfrom
jordan-wong wants to merge 1 commit intomasterfrom
Conversation
… fix
Three test methods have been consistently failing due to two pre-existing
instrumentation bugs:
1. Server span does not finish for non-proxied (WSDL) requests because the
isFinal check requires a non-null status line, which is not always set
when responseReady fires.
2. SynapsePassthruInstrumentation stores the proxy context at key
"dd.trace.synapse.span" but SynapseClientInstrumentation reads from
SYNAPSE_CONTEXT_KEY ("dd.trace.synapse.context"), a mismatch introduced
in #9422 that was never corrected.
Mark the three affected test methods as @flaky to unblock CI while a
proper instrumentation fix is tracked separately.
tag: no release note
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jordan-wong
added
tag: no release notes
github-actions
bot
added
the
tag: ai generated
LobeTia
requested changes
Apr 1, 2026
LobeTia
left a comment
LobeTia
left a comment
There was a problem hiding this comment.
It doesn't seems to flag all the tests (we have 6, this covers 3, 1 of which doesn't seems flaky)
Can we also have create a follow-up item in our Jira board with a remediation task to re-enable this and the results of your initial investigation?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Marks 3 failing synapse tests (100% failure rate on CI runs) as flaky so they can be skipped on CI for now.
Motivation
I grepped past commits for synapse + git bisect, and ran tests on old commits to try to determine when the test failures were introduced. The commits I tried to go back on we're eventually too old to run our test suite on (build failures). These tests have been failing for a very long period of time (>4 months).
Did not have capacity to determine full fix - need some context on past implementation decisions. From initial analysis test methods have been consistently failing due to two pre-existing instrumentation bugs:
beforeFinishMigration #9422 that was never corrected.Marking the 3 affected test methods as @flaky to clean up CI while a proper instrumentation fix is needed separately.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.