Add milestone check and local tag revert to the perform release script#11058
Open
PerfectSlayer wants to merge 1 commit intomasterfrom
Open
Add milestone check and local tag revert to the perform release script#11058PerfectSlayer wants to merge 1 commit intomasterfrom
PerfectSlayer wants to merge 1 commit intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 14 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~4d11580a30, baseline=1.61.0-SNAPSHOT~3123b191d9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1063338
Total [baseline] (11.095 s) : 0, 11095119
Agent [candidate] (1.058 s) : 0, 1057510
Total [candidate] (11.09 s) : 0, 11089998
section appsec
Agent [baseline] (1.249 s) : 0, 1249047
Total [baseline] (11.15 s) : 0, 11149680
Agent [candidate] (1.248 s) : 0, 1248013
Total [candidate] (11.065 s) : 0, 11064819
section iast
Agent [baseline] (1.23 s) : 0, 1229835
Total [baseline] (11.298 s) : 0, 11298255
Agent [candidate] (1.222 s) : 0, 1222290
Total [candidate] (11.356 s) : 0, 11356204
section profiling
Agent [baseline] (1.185 s) : 0, 1185386
Total [baseline] (11.097 s) : 0, 11096831
Agent [candidate] (1.182 s) : 0, 1181757
Total [candidate] (11.096 s) : 0, 11096390
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~4d11580a30, baseline=1.61.0-SNAPSHOT~3123b191d9
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.249 ms) : 0, 1249
crashtracking [candidate] (1.22 ms) : 0, 1220
BytebuddyAgent [baseline] (637.757 ms) : 0, 637757
BytebuddyAgent [candidate] (633.464 ms) : 0, 633464
AgentMeter [baseline] (29.463 ms) : 0, 29463
AgentMeter [candidate] (29.308 ms) : 0, 29308
GlobalTracer [baseline] (250.351 ms) : 0, 250351
GlobalTracer [candidate] (248.699 ms) : 0, 248699
AppSec [baseline] (32.274 ms) : 0, 32274
AppSec [candidate] (32.013 ms) : 0, 32013
Debugger [baseline] (60.357 ms) : 0, 60357
Debugger [candidate] (59.768 ms) : 0, 59768
Remote Config [baseline] (606.489 µs) : 0, 606
Remote Config [candidate] (599.529 µs) : 0, 600
Telemetry [baseline] (8.154 ms) : 0, 8154
Telemetry [candidate] (8.063 ms) : 0, 8063
Flare Poller [baseline] (6.704 ms) : 0, 6704
Flare Poller [candidate] (8.247 ms) : 0, 8247
section appsec
crashtracking [baseline] (1.242 ms) : 0, 1242
crashtracking [candidate] (1.216 ms) : 0, 1216
BytebuddyAgent [baseline] (662.43 ms) : 0, 662430
BytebuddyAgent [candidate] (661.931 ms) : 0, 661931
AgentMeter [baseline] (12.054 ms) : 0, 12054
AgentMeter [candidate] (12.086 ms) : 0, 12086
GlobalTracer [baseline] (249.397 ms) : 0, 249397
GlobalTracer [candidate] (249.084 ms) : 0, 249084
IAST [baseline] (24.533 ms) : 0, 24533
IAST [candidate] (24.507 ms) : 0, 24507
AppSec [baseline] (184.13 ms) : 0, 184130
AppSec [candidate] (183.868 ms) : 0, 183868
Debugger [baseline] (66.15 ms) : 0, 66150
Debugger [candidate] (66.262 ms) : 0, 66262
Remote Config [baseline] (623.163 µs) : 0, 623
Remote Config [candidate] (602.14 µs) : 0, 602
Telemetry [baseline] (8.624 ms) : 0, 8624
Telemetry [candidate] (8.601 ms) : 0, 8601
Flare Poller [baseline] (3.524 ms) : 0, 3524
Flare Poller [candidate] (3.515 ms) : 0, 3515
section iast
crashtracking [baseline] (1.223 ms) : 0, 1223
crashtracking [candidate] (1.218 ms) : 0, 1218
BytebuddyAgent [baseline] (806.983 ms) : 0, 806983
BytebuddyAgent [candidate] (798.646 ms) : 0, 798646
AgentMeter [baseline] (11.61 ms) : 0, 11610
AgentMeter [candidate] (11.428 ms) : 0, 11428
GlobalTracer [baseline] (239.447 ms) : 0, 239447
GlobalTracer [candidate] (239.008 ms) : 0, 239008
IAST [baseline] (25.656 ms) : 0, 25656
IAST [candidate] (25.911 ms) : 0, 25911
AppSec [baseline] (30.888 ms) : 0, 30888
AppSec [candidate] (32.662 ms) : 0, 32662
Debugger [baseline] (62.185 ms) : 0, 62185
Debugger [candidate] (61.353 ms) : 0, 61353
Remote Config [baseline] (1.156 ms) : 0, 1156
Remote Config [candidate] (1.206 ms) : 0, 1206
Telemetry [baseline] (10.769 ms) : 0, 10769
Telemetry [candidate] (11.188 ms) : 0, 11188
Flare Poller [baseline] (3.58 ms) : 0, 3580
Flare Poller [candidate] (3.667 ms) : 0, 3667
section profiling
crashtracking [baseline] (1.178 ms) : 0, 1178
crashtracking [candidate] (1.174 ms) : 0, 1174
BytebuddyAgent [baseline] (691.981 ms) : 0, 691981
BytebuddyAgent [candidate] (690.308 ms) : 0, 690308
AgentMeter [baseline] (9.156 ms) : 0, 9156
AgentMeter [candidate] (9.109 ms) : 0, 9109
GlobalTracer [baseline] (207.199 ms) : 0, 207199
GlobalTracer [candidate] (206.456 ms) : 0, 206456
AppSec [baseline] (32.809 ms) : 0, 32809
AppSec [candidate] (32.427 ms) : 0, 32427
Debugger [baseline] (65.795 ms) : 0, 65795
Debugger [candidate] (65.441 ms) : 0, 65441
Remote Config [baseline] (580.987 µs) : 0, 581
Remote Config [candidate] (568.202 µs) : 0, 568
Telemetry [baseline] (7.945 ms) : 0, 7945
Telemetry [candidate] (7.937 ms) : 0, 7937
Flare Poller [baseline] (3.554 ms) : 0, 3554
Flare Poller [candidate] (3.588 ms) : 0, 3588
ProfilingAgent [baseline] (93.852 ms) : 0, 93852
ProfilingAgent [candidate] (93.631 ms) : 0, 93631
Profiling [baseline] (94.424 ms) : 0, 94424
Profiling [candidate] (94.209 ms) : 0, 94209
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~4d11580a30, baseline=1.61.0-SNAPSHOT~3123b191d9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1054523
Total [baseline] (8.883 s) : 0, 8882740
Agent [candidate] (1.058 s) : 0, 1058451
Total [candidate] (8.86 s) : 0, 8859935
section iast
Agent [baseline] (1.234 s) : 0, 1233820
Total [baseline] (9.602 s) : 0, 9601591
Agent [candidate] (1.233 s) : 0, 1232883
Total [candidate] (9.573 s) : 0, 9573073
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~4d11580a30, baseline=1.61.0-SNAPSHOT~3123b191d9
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.233 ms) : 0, 1233
crashtracking [candidate] (1.213 ms) : 0, 1213
BytebuddyAgent [baseline] (631.887 ms) : 0, 631887
BytebuddyAgent [candidate] (632.886 ms) : 0, 632886
AgentMeter [baseline] (29.17 ms) : 0, 29170
AgentMeter [candidate] (29.44 ms) : 0, 29440
GlobalTracer [baseline] (247.576 ms) : 0, 247576
GlobalTracer [candidate] (250.07 ms) : 0, 250070
AppSec [baseline] (31.999 ms) : 0, 31999
AppSec [candidate] (32.131 ms) : 0, 32131
Debugger [baseline] (59.091 ms) : 0, 59091
Debugger [candidate] (59.649 ms) : 0, 59649
Remote Config [baseline] (599.397 µs) : 0, 599
Remote Config [candidate] (619.962 µs) : 0, 620
Telemetry [baseline] (8.079 ms) : 0, 8079
Telemetry [candidate] (8.217 ms) : 0, 8217
Flare Poller [baseline] (8.769 ms) : 0, 8769
Flare Poller [candidate] (8.142 ms) : 0, 8142
section iast
crashtracking [baseline] (1.249 ms) : 0, 1249
crashtracking [candidate] (1.253 ms) : 0, 1253
BytebuddyAgent [baseline] (809.494 ms) : 0, 809494
BytebuddyAgent [candidate] (811.743 ms) : 0, 811743
AgentMeter [baseline] (11.492 ms) : 0, 11492
AgentMeter [candidate] (11.516 ms) : 0, 11516
GlobalTracer [baseline] (239.752 ms) : 0, 239752
GlobalTracer [candidate] (238.562 ms) : 0, 238562
IAST [baseline] (25.943 ms) : 0, 25943
IAST [candidate] (25.794 ms) : 0, 25794
AppSec [baseline] (31.262 ms) : 0, 31262
AppSec [candidate] (29.28 ms) : 0, 29280
Debugger [baseline] (61.823 ms) : 0, 61823
Debugger [candidate] (64.008 ms) : 0, 64008
Remote Config [baseline] (542.586 µs) : 0, 543
Remote Config [candidate] (1.122 ms) : 0, 1122
Telemetry [baseline] (11.644 ms) : 0, 11644
Telemetry [candidate] (9.735 ms) : 0, 9735
Flare Poller [baseline] (4.088 ms) : 0, 4088
Flare Poller [candidate] (3.56 ms) : 0, 3560
LoadParameters
See matching parameters
SummaryFound 5 performance improvements and 3 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~4d11580a30, baseline=1.61.0-SNAPSHOT~3123b191d9
dateFormat X
axisFormat %s
section baseline
no_agent (18.412 ms) : 18222, 18603
. : milestone, 18412,
appsec (18.684 ms) : 18498, 18870
. : milestone, 18684,
code_origins (17.884 ms) : 17709, 18059
. : milestone, 17884,
iast (17.891 ms) : 17716, 18066
. : milestone, 17891,
profiling (18.951 ms) : 18765, 19137
. : milestone, 18951,
tracing (17.715 ms) : 17541, 17890
. : milestone, 17715,
section candidate
no_agent (19.77 ms) : 19571, 19969
. : milestone, 19770,
appsec (18.451 ms) : 18266, 18636
. : milestone, 18451,
code_origins (17.989 ms) : 17812, 18166
. : milestone, 17989,
iast (17.987 ms) : 17813, 18160
. : milestone, 17987,
profiling (20.078 ms) : 19874, 20283
. : milestone, 20078,
tracing (17.973 ms) : 17798, 18147
. : milestone, 17973,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~4d11580a30, baseline=1.61.0-SNAPSHOT~3123b191d9
dateFormat X
axisFormat %s
section baseline
no_agent (1.24 ms) : 1229, 1252
. : milestone, 1240,
iast (3.411 ms) : 3359, 3462
. : milestone, 3411,
iast_FULL (6.326 ms) : 6260, 6391
. : milestone, 6326,
iast_GLOBAL (3.758 ms) : 3694, 3821
. : milestone, 3758,
profiling (2.213 ms) : 2190, 2235
. : milestone, 2213,
tracing (1.841 ms) : 1826, 1855
. : milestone, 1841,
section candidate
no_agent (1.305 ms) : 1292, 1318
. : milestone, 1305,
iast (3.215 ms) : 3166, 3263
. : milestone, 3215,
iast_FULL (5.808 ms) : 5750, 5867
. : milestone, 5808,
iast_GLOBAL (3.573 ms) : 3515, 3631
. : milestone, 3573,
profiling (2.198 ms) : 2178, 2219
. : milestone, 2198,
tracing (1.929 ms) : 1912, 1946
. : milestone, 1929,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~4d11580a30, baseline=1.61.0-SNAPSHOT~3123b191d9
dateFormat X
axisFormat %s
section baseline
no_agent (1.487 ms) : 1475, 1499
. : milestone, 1487,
appsec (3.827 ms) : 3605, 4049
. : milestone, 3827,
iast (2.273 ms) : 2203, 2342
. : milestone, 2273,
iast_GLOBAL (2.318 ms) : 2248, 2388
. : milestone, 2318,
profiling (2.132 ms) : 2075, 2190
. : milestone, 2132,
tracing (2.099 ms) : 2045, 2154
. : milestone, 2099,
section candidate
no_agent (1.494 ms) : 1482, 1505
. : milestone, 1494,
appsec (3.761 ms) : 3545, 3977
. : milestone, 3761,
iast (2.269 ms) : 2200, 2339
. : milestone, 2269,
iast_GLOBAL (2.314 ms) : 2244, 2384
. : milestone, 2314,
profiling (2.133 ms) : 2075, 2190
. : milestone, 2133,
tracing (2.095 ms) : 2041, 2149
. : milestone, 2095,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~4d11580a30, baseline=1.61.0-SNAPSHOT~3123b191d9
dateFormat X
axisFormat %s
section baseline
no_agent (14.895 s) : 14895000, 14895000
. : milestone, 14895000,
appsec (14.731 s) : 14731000, 14731000
. : milestone, 14731000,
iast (18.316 s) : 18316000, 18316000
. : milestone, 18316000,
iast_GLOBAL (18.077 s) : 18077000, 18077000
. : milestone, 18077000,
profiling (14.835 s) : 14835000, 14835000
. : milestone, 14835000,
tracing (14.812 s) : 14812000, 14812000
. : milestone, 14812000,
section candidate
no_agent (15.015 s) : 15015000, 15015000
. : milestone, 15015000,
appsec (14.941 s) : 14941000, 14941000
. : milestone, 14941000,
iast (18.453 s) : 18453000, 18453000
. : milestone, 18453000,
iast_GLOBAL (18.289 s) : 18289000, 18289000
. : milestone, 18289000,
profiling (15.042 s) : 15042000, 15042000
. : milestone, 15042000,
tracing (14.9 s) : 14900000, 14900000
. : milestone, 14900000,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR improves behavior on two recent issues encountered with the script:
Motivation
The goal is to keep the script as basic as possible as any addition is particularly difficult to test, while keeping it as harden as possible.
The two behaviors were creating an invalid releases either on local or remove environments.
Additional Notes
This PR is a manual re-implementation and validation of #11024
I would rather not to make this script too complexe as it must remain as simple and stable as possible as part of the release process.
If some would like to have a more complete release automation, we might create a second script extending this one but I could not think of a way for the platform team to intensively test it and own it.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.