Add a jpms opener for HostNameResolver cache#11095
Open
Conversation
Contributor
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 61 metrics, 9 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~c7ca1979b7, baseline=1.62.0-SNAPSHOT~aeb83d6118
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.068 s) : 0, 1067774
Total [baseline] (8.91 s) : 0, 8909670
Agent [candidate] (1.068 s) : 0, 1067832
Total [candidate] (8.874 s) : 0, 8874084
section iast
Agent [baseline] (1.237 s) : 0, 1237429
Total [baseline] (9.574 s) : 0, 9573862
Agent [candidate] (1.24 s) : 0, 1240307
Total [candidate] (9.551 s) : 0, 9550517
gantt
title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~c7ca1979b7, baseline=1.62.0-SNAPSHOT~aeb83d6118
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.248 ms) : 0, 1248
crashtracking [candidate] (1.218 ms) : 0, 1218
BytebuddyAgent [baseline] (639.447 ms) : 0, 639447
BytebuddyAgent [candidate] (638.764 ms) : 0, 638764
AgentMeter [baseline] (29.898 ms) : 0, 29898
AgentMeter [candidate] (29.665 ms) : 0, 29665
GlobalTracer [baseline] (251.227 ms) : 0, 251227
GlobalTracer [candidate] (250.736 ms) : 0, 250736
AppSec [baseline] (32.527 ms) : 0, 32527
AppSec [candidate] (32.921 ms) : 0, 32921
Debugger [baseline] (59.326 ms) : 0, 59326
Debugger [candidate] (59.964 ms) : 0, 59964
Remote Config [baseline] (596.674 µs) : 0, 597
Remote Config [candidate] (602.226 µs) : 0, 602
Telemetry [baseline] (7.993 ms) : 0, 7993
Telemetry [candidate] (8.91 ms) : 0, 8910
Flare Poller [baseline] (9.102 ms) : 0, 9102
Flare Poller [candidate] (9.086 ms) : 0, 9086
section iast
crashtracking [baseline] (1.252 ms) : 0, 1252
crashtracking [candidate] (1.228 ms) : 0, 1228
BytebuddyAgent [baseline] (814.741 ms) : 0, 814741
BytebuddyAgent [candidate] (820.798 ms) : 0, 820798
AgentMeter [baseline] (11.508 ms) : 0, 11508
AgentMeter [candidate] (11.427 ms) : 0, 11427
GlobalTracer [baseline] (239.113 ms) : 0, 239113
GlobalTracer [candidate] (237.321 ms) : 0, 237321
AppSec [baseline] (29.416 ms) : 0, 29416
AppSec [candidate] (29.972 ms) : 0, 29972
Debugger [baseline] (65.972 ms) : 0, 65972
Debugger [candidate] (63.21 ms) : 0, 63210
Remote Config [baseline] (536.684 µs) : 0, 537
Remote Config [candidate] (516.41 µs) : 0, 516
Telemetry [baseline] (7.829 ms) : 0, 7829
Telemetry [candidate] (7.653 ms) : 0, 7653
Flare Poller [baseline] (3.433 ms) : 0, 3433
Flare Poller [candidate] (3.326 ms) : 0, 3326
IAST [baseline] (26.606 ms) : 0, 26606
IAST [candidate] (28.088 ms) : 0, 28088
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~c7ca1979b7, baseline=1.62.0-SNAPSHOT~aeb83d6118
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1064157
Total [baseline] (11.068 s) : 0, 11067989
Agent [candidate] (1.06 s) : 0, 1060152
Total [candidate] (11.062 s) : 0, 11061774
section appsec
Agent [baseline] (1.27 s) : 0, 1270191
Total [baseline] (11.091 s) : 0, 11090872
Agent [candidate] (1.266 s) : 0, 1266205
Total [candidate] (11.083 s) : 0, 11082878
section iast
Agent [baseline] (1.232 s) : 0, 1231832
Total [baseline] (11.264 s) : 0, 11264407
Agent [candidate] (1.241 s) : 0, 1241307
Total [candidate] (11.333 s) : 0, 11333245
section profiling
Agent [baseline] (1.197 s) : 0, 1197418
Total [baseline] (11.128 s) : 0, 11127803
Agent [candidate] (1.203 s) : 0, 1203267
Total [candidate] (11.126 s) : 0, 11125575
gantt
title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~c7ca1979b7, baseline=1.62.0-SNAPSHOT~aeb83d6118
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.239 ms) : 0, 1239
crashtracking [candidate] (1.229 ms) : 0, 1229
BytebuddyAgent [baseline] (633.819 ms) : 0, 633819
BytebuddyAgent [candidate] (632.498 ms) : 0, 632498
AgentMeter [baseline] (29.798 ms) : 0, 29798
AgentMeter [candidate] (29.578 ms) : 0, 29578
GlobalTracer [baseline] (251.25 ms) : 0, 251250
GlobalTracer [candidate] (249.443 ms) : 0, 249443
AppSec [baseline] (32.714 ms) : 0, 32714
AppSec [candidate] (32.713 ms) : 0, 32713
Debugger [baseline] (60.341 ms) : 0, 60341
Debugger [candidate] (60.118 ms) : 0, 60118
Remote Config [baseline] (605.244 µs) : 0, 605
Remote Config [candidate] (600.551 µs) : 0, 601
Telemetry [baseline] (8.149 ms) : 0, 8149
Telemetry [candidate] (8.097 ms) : 0, 8097
Flare Poller [baseline] (9.902 ms) : 0, 9902
Flare Poller [candidate] (9.825 ms) : 0, 9825
section appsec
crashtracking [baseline] (1.271 ms) : 0, 1271
crashtracking [candidate] (1.238 ms) : 0, 1238
BytebuddyAgent [baseline] (679.362 ms) : 0, 679362
BytebuddyAgent [candidate] (673.035 ms) : 0, 673035
AgentMeter [baseline] (12.264 ms) : 0, 12264
AgentMeter [candidate] (12.173 ms) : 0, 12173
GlobalTracer [baseline] (250.708 ms) : 0, 250708
GlobalTracer [candidate] (248.765 ms) : 0, 248765
AppSec [baseline] (187.119 ms) : 0, 187119
AppSec [candidate] (186.387 ms) : 0, 186387
Debugger [baseline] (66.329 ms) : 0, 66329
Debugger [candidate] (66.617 ms) : 0, 66617
Remote Config [baseline] (592.435 µs) : 0, 592
Remote Config [candidate] (570.351 µs) : 0, 570
Telemetry [baseline] (7.878 ms) : 0, 7878
Telemetry [candidate] (7.629 ms) : 0, 7629
Flare Poller [baseline] (3.526 ms) : 0, 3526
Flare Poller [candidate] (9.019 ms) : 0, 9019
IAST [baseline] (24.472 ms) : 0, 24472
IAST [candidate] (24.611 ms) : 0, 24611
section iast
crashtracking [baseline] (1.239 ms) : 0, 1239
crashtracking [candidate] (1.221 ms) : 0, 1221
BytebuddyAgent [baseline] (809.14 ms) : 0, 809140
BytebuddyAgent [candidate] (820.925 ms) : 0, 820925
AgentMeter [baseline] (11.425 ms) : 0, 11425
AgentMeter [candidate] (11.429 ms) : 0, 11429
GlobalTracer [baseline] (239.292 ms) : 0, 239292
GlobalTracer [candidate] (238.55 ms) : 0, 238550
AppSec [baseline] (28.519 ms) : 0, 28519
AppSec [candidate] (29.855 ms) : 0, 29855
Debugger [baseline] (64.599 ms) : 0, 64599
Debugger [candidate] (63.041 ms) : 0, 63041
Remote Config [baseline] (536.518 µs) : 0, 537
Remote Config [candidate] (512.852 µs) : 0, 513
Telemetry [baseline] (7.778 ms) : 0, 7778
Telemetry [candidate] (7.668 ms) : 0, 7668
Flare Poller [baseline] (3.33 ms) : 0, 3330
Flare Poller [candidate] (3.34 ms) : 0, 3340
IAST [baseline] (29.828 ms) : 0, 29828
IAST [candidate] (28.729 ms) : 0, 28729
section profiling
ProfilingAgent [baseline] (95.024 ms) : 0, 95024
ProfilingAgent [candidate] (95.126 ms) : 0, 95126
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.207 ms) : 0, 1207
BytebuddyAgent [baseline] (699.096 ms) : 0, 699096
BytebuddyAgent [candidate] (702.932 ms) : 0, 702932
AgentMeter [baseline] (9.066 ms) : 0, 9066
AgentMeter [candidate] (9.15 ms) : 0, 9150
GlobalTracer [baseline] (209.688 ms) : 0, 209688
GlobalTracer [candidate] (210.838 ms) : 0, 210838
AppSec [baseline] (32.984 ms) : 0, 32984
AppSec [candidate] (33.143 ms) : 0, 33143
Debugger [baseline] (66.307 ms) : 0, 66307
Debugger [candidate] (66.69 ms) : 0, 66690
Remote Config [baseline] (588.888 µs) : 0, 589
Remote Config [candidate] (580.699 µs) : 0, 581
Telemetry [baseline] (7.921 ms) : 0, 7921
Telemetry [candidate] (7.848 ms) : 0, 7848
Flare Poller [baseline] (3.562 ms) : 0, 3562
Flare Poller [candidate] (3.542 ms) : 0, 3542
Profiling [baseline] (95.6 ms) : 0, 95600
Profiling [candidate] (95.688 ms) : 0, 95688
LoadParameters
See matching parameters
SummaryFound 6 performance improvements and 1 performance regressions! Performance is the same for 14 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~c7ca1979b7, baseline=1.62.0-SNAPSHOT~aeb83d6118
dateFormat X
axisFormat %s
section baseline
no_agent (1.259 ms) : 1246, 1271
. : milestone, 1259,
iast (3.337 ms) : 3287, 3387
. : milestone, 3337,
iast_FULL (6.073 ms) : 6011, 6134
. : milestone, 6073,
iast_GLOBAL (3.812 ms) : 3743, 3881
. : milestone, 3812,
profiling (2.605 ms) : 2576, 2634
. : milestone, 2605,
tracing (1.866 ms) : 1850, 1881
. : milestone, 1866,
section candidate
no_agent (1.253 ms) : 1241, 1266
. : milestone, 1253,
iast (3.347 ms) : 3298, 3395
. : milestone, 3347,
iast_FULL (6.039 ms) : 5977, 6101
. : milestone, 6039,
iast_GLOBAL (3.634 ms) : 3570, 3697
. : milestone, 3634,
profiling (2.298 ms) : 2276, 2321
. : milestone, 2298,
tracing (1.861 ms) : 1845, 1876
. : milestone, 1861,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~c7ca1979b7, baseline=1.62.0-SNAPSHOT~aeb83d6118
dateFormat X
axisFormat %s
section baseline
no_agent (18.117 ms) : 17932, 18302
. : milestone, 18117,
appsec (18.759 ms) : 18572, 18945
. : milestone, 18759,
code_origins (18.801 ms) : 18616, 18986
. : milestone, 18801,
iast (19.292 ms) : 19099, 19484
. : milestone, 19292,
profiling (19.41 ms) : 19217, 19603
. : milestone, 19410,
tracing (17.861 ms) : 17685, 18038
. : milestone, 17861,
section candidate
no_agent (19.596 ms) : 19397, 19794
. : milestone, 19596,
appsec (19.078 ms) : 18885, 19271
. : milestone, 19078,
code_origins (18.495 ms) : 18312, 18678
. : milestone, 18495,
iast (17.937 ms) : 17760, 18115
. : milestone, 17937,
profiling (18.101 ms) : 17921, 18281
. : milestone, 18101,
tracing (18.119 ms) : 17939, 18298
. : milestone, 18119,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~c7ca1979b7, baseline=1.62.0-SNAPSHOT~aeb83d6118
dateFormat X
axisFormat %s
section baseline
no_agent (15.07 s) : 15070000, 15070000
. : milestone, 15070000,
appsec (14.807 s) : 14807000, 14807000
. : milestone, 14807000,
iast (18.566 s) : 18566000, 18566000
. : milestone, 18566000,
iast_GLOBAL (18.076 s) : 18076000, 18076000
. : milestone, 18076000,
profiling (15.036 s) : 15036000, 15036000
. : milestone, 15036000,
tracing (15.161 s) : 15161000, 15161000
. : milestone, 15161000,
section candidate
no_agent (15.262 s) : 15262000, 15262000
. : milestone, 15262000,
appsec (14.547 s) : 14547000, 14547000
. : milestone, 14547000,
iast (18.674 s) : 18674000, 18674000
. : milestone, 18674000,
iast_GLOBAL (18.072 s) : 18072000, 18072000
. : milestone, 18072000,
profiling (14.794 s) : 14794000, 14794000
. : milestone, 14794000,
tracing (14.997 s) : 14997000, 14997000
. : milestone, 14997000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~c7ca1979b7, baseline=1.62.0-SNAPSHOT~aeb83d6118
dateFormat X
axisFormat %s
section baseline
no_agent (1.493 ms) : 1481, 1504
. : milestone, 1493,
appsec (2.561 ms) : 2505, 2616
. : milestone, 2561,
iast (2.293 ms) : 2224, 2363
. : milestone, 2293,
iast_GLOBAL (2.333 ms) : 2263, 2403
. : milestone, 2333,
profiling (2.105 ms) : 2051, 2160
. : milestone, 2105,
tracing (2.079 ms) : 2026, 2133
. : milestone, 2079,
section candidate
no_agent (1.504 ms) : 1492, 1515
. : milestone, 1504,
appsec (2.554 ms) : 2499, 2609
. : milestone, 2554,
iast (2.291 ms) : 2221, 2361
. : milestone, 2291,
iast_GLOBAL (2.344 ms) : 2274, 2415
. : milestone, 2344,
profiling (2.121 ms) : 2065, 2177
. : milestone, 2121,
tracing (2.099 ms) : 2045, 2152
. : milestone, 2099,
|
mcculls
reviewed
Apr 14, 2026
3e28260 to
74e23d2
Compare
74e23d2 to
c7ca197
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Enable using the HostNameResolver cache also under jpms enforcement. This PR instrument java.net specific classes in order to open the module from inside.
The same kind of trick has been previously done with mule instrumentation
Solves #11088
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.