Lazily allocate HashMap in PathMatchingHttpServletRequestWrapper#11142
Closed
Lazily allocate HashMap in PathMatchingHttpServletRequestWrapper#11142
Conversation
The wrapper is created on every request to isolate attribute side effects during handler mapping lookups. Previously, a HashMap was eagerly allocated even when no handler mapping matched (and thus no attributes were set). This defers the HashMap allocation to the first setAttribute call, avoiding the cost of a HashMap with its 16-entry Node array on requests that don't match any handler mapping. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
localAttributesHashMap inPathMatchingHttpServletRequestWrapperlazily initialized — only allocated on firstsetAttribute()callgetHandler()returns null without callingsetAttribute, so the HashMap is never allocatedMotivation:
HandlerMappingResourceNameFiltercreates aPathMatchingHttpServletRequestWrapper(with an internalHashMap+ 16-entryNode[]array) on every request before checking if a matching handler exists. For non-matching requests, the allocation is wasted.Files changed
PathMatchingHttpServletRequestWrapper.java(3.1) — lazy initPathMatchingHttpServletRequestWrapper.java(6.0) — lazy initTest plan
tag: no release note
tag: ai generated
🤖 Generated with Claude Code