Migrate dd-trace-core groovy files to java part 4 #11146
Open
Migrate dd-trace-core groovy files to java part 4 #11146
Conversation
we migrate 3 tests: - CoreSpanBuilderTest - CoreTracerTest - DDSpanContextPropagationTagsTest
we save the original instance before replaced by mock to restore it Some tests rely on having. the original, and depending on the order the class my keep the mocks instead resulting in errors
Contributor
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~fcfc49dad9, baseline=1.62.0-SNAPSHOT~42f154d2f6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.053 s) : 0, 1053415
Total [baseline] (8.854 s) : 0, 8854161
Agent [candidate] (1.056 s) : 0, 1056142
Total [candidate] (8.817 s) : 0, 8817094
section iast
Agent [baseline] (1.229 s) : 0, 1229474
Total [baseline] (9.578 s) : 0, 9577790
Agent [candidate] (1.222 s) : 0, 1222441
Total [candidate] (9.588 s) : 0, 9588408
gantt
title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~fcfc49dad9, baseline=1.62.0-SNAPSHOT~42f154d2f6
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.227 ms) : 0, 1227
crashtracking [candidate] (1.24 ms) : 0, 1240
BytebuddyAgent [baseline] (630.794 ms) : 0, 630794
BytebuddyAgent [candidate] (632.179 ms) : 0, 632179
AgentMeter [baseline] (29.323 ms) : 0, 29323
AgentMeter [candidate] (29.306 ms) : 0, 29306
GlobalTracer [baseline] (247.848 ms) : 0, 247848
GlobalTracer [candidate] (248.265 ms) : 0, 248265
AppSec [baseline] (32.235 ms) : 0, 32235
AppSec [candidate] (32.306 ms) : 0, 32306
Debugger [baseline] (59.022 ms) : 0, 59022
Debugger [candidate] (59.196 ms) : 0, 59196
Remote Config [baseline] (604.763 µs) : 0, 605
Remote Config [candidate] (589.584 µs) : 0, 590
Telemetry [baseline] (8.014 ms) : 0, 8014
Telemetry [candidate] (8.065 ms) : 0, 8065
Flare Poller [baseline] (8.27 ms) : 0, 8270
Flare Poller [candidate] (9.012 ms) : 0, 9012
section iast
crashtracking [baseline] (1.237 ms) : 0, 1237
crashtracking [candidate] (1.232 ms) : 0, 1232
BytebuddyAgent [baseline] (807.538 ms) : 0, 807538
BytebuddyAgent [candidate] (800.387 ms) : 0, 800387
AgentMeter [baseline] (11.492 ms) : 0, 11492
AgentMeter [candidate] (11.329 ms) : 0, 11329
GlobalTracer [baseline] (238.863 ms) : 0, 238863
GlobalTracer [candidate] (238.708 ms) : 0, 238708
AppSec [baseline] (32.711 ms) : 0, 32711
AppSec [candidate] (31.384 ms) : 0, 31384
Debugger [baseline] (59.947 ms) : 0, 59947
Debugger [candidate] (61.714 ms) : 0, 61714
Remote Config [baseline] (532.4 µs) : 0, 532
Remote Config [candidate] (1.175 ms) : 0, 1175
Telemetry [baseline] (11.694 ms) : 0, 11694
Telemetry [candidate] (11.221 ms) : 0, 11221
Flare Poller [baseline] (3.509 ms) : 0, 3509
Flare Poller [candidate] (3.437 ms) : 0, 3437
IAST [baseline] (25.716 ms) : 0, 25716
IAST [candidate] (25.78 ms) : 0, 25780
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~fcfc49dad9, baseline=1.62.0-SNAPSHOT~42f154d2f6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1059201
Total [baseline] (11.003 s) : 0, 11002880
Agent [candidate] (1.057 s) : 0, 1056879
Total [candidate] (11.092 s) : 0, 11092482
section appsec
Agent [baseline] (1.25 s) : 0, 1250117
Total [baseline] (11.058 s) : 0, 11058055
Agent [candidate] (1.248 s) : 0, 1248246
Total [candidate] (11.094 s) : 0, 11094235
section iast
Agent [baseline] (1.223 s) : 0, 1223417
Total [baseline] (11.347 s) : 0, 11347244
Agent [candidate] (1.225 s) : 0, 1224651
Total [candidate] (11.218 s) : 0, 11218162
section profiling
Agent [baseline] (1.185 s) : 0, 1185432
Total [baseline] (11.038 s) : 0, 11038135
Agent [candidate] (1.196 s) : 0, 1196203
Total [candidate] (11.041 s) : 0, 11041237
gantt
title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~fcfc49dad9, baseline=1.62.0-SNAPSHOT~42f154d2f6
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.225 ms) : 0, 1225
crashtracking [candidate] (1.235 ms) : 0, 1235
BytebuddyAgent [baseline] (634.17 ms) : 0, 634170
BytebuddyAgent [candidate] (632.075 ms) : 0, 632075
AgentMeter [baseline] (29.457 ms) : 0, 29457
AgentMeter [candidate] (29.386 ms) : 0, 29386
GlobalTracer [baseline] (249.164 ms) : 0, 249164
GlobalTracer [candidate] (248.837 ms) : 0, 248837
AppSec [baseline] (32.296 ms) : 0, 32296
AppSec [candidate] (32.364 ms) : 0, 32364
Debugger [baseline] (59.756 ms) : 0, 59756
Debugger [candidate] (60.004 ms) : 0, 60004
Remote Config [baseline] (590.368 µs) : 0, 590
Remote Config [candidate] (589.454 µs) : 0, 589
Telemetry [baseline] (8.065 ms) : 0, 8065
Telemetry [candidate] (8.085 ms) : 0, 8085
Flare Poller [baseline] (8.247 ms) : 0, 8247
Flare Poller [candidate] (8.211 ms) : 0, 8211
section appsec
crashtracking [baseline] (1.225 ms) : 0, 1225
crashtracking [candidate] (1.224 ms) : 0, 1224
BytebuddyAgent [baseline] (662.875 ms) : 0, 662875
BytebuddyAgent [candidate] (661.66 ms) : 0, 661660
AgentMeter [baseline] (12.104 ms) : 0, 12104
AgentMeter [candidate] (12.042 ms) : 0, 12042
GlobalTracer [baseline] (248.933 ms) : 0, 248933
GlobalTracer [candidate] (248.744 ms) : 0, 248744
AppSec [baseline] (185.241 ms) : 0, 185241
AppSec [candidate] (184.992 ms) : 0, 184992
Debugger [baseline] (65.954 ms) : 0, 65954
Debugger [candidate] (66.019 ms) : 0, 66019
Remote Config [baseline] (622.065 µs) : 0, 622
Remote Config [candidate] (631.213 µs) : 0, 631
Telemetry [baseline] (8.495 ms) : 0, 8495
Telemetry [candidate] (8.421 ms) : 0, 8421
Flare Poller [baseline] (3.559 ms) : 0, 3559
Flare Poller [candidate] (3.58 ms) : 0, 3580
IAST [baseline] (24.602 ms) : 0, 24602
IAST [candidate] (24.541 ms) : 0, 24541
section iast
crashtracking [baseline] (1.248 ms) : 0, 1248
crashtracking [candidate] (1.218 ms) : 0, 1218
BytebuddyAgent [baseline] (799.622 ms) : 0, 799622
BytebuddyAgent [candidate] (802.094 ms) : 0, 802094
AgentMeter [baseline] (11.379 ms) : 0, 11379
AgentMeter [candidate] (11.391 ms) : 0, 11391
GlobalTracer [baseline] (238.834 ms) : 0, 238834
GlobalTracer [candidate] (238.959 ms) : 0, 238959
AppSec [baseline] (33.84 ms) : 0, 33840
AppSec [candidate] (31.161 ms) : 0, 31161
Debugger [baseline] (60.101 ms) : 0, 60101
Debugger [candidate] (62.134 ms) : 0, 62134
Remote Config [baseline] (547.875 µs) : 0, 548
Remote Config [candidate] (1.122 ms) : 0, 1122
Telemetry [baseline] (12.262 ms) : 0, 12262
Telemetry [candidate] (11.044 ms) : 0, 11044
Flare Poller [baseline] (3.494 ms) : 0, 3494
Flare Poller [candidate] (3.456 ms) : 0, 3456
IAST [baseline] (25.823 ms) : 0, 25823
IAST [candidate] (25.842 ms) : 0, 25842
section profiling
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (692.229 ms) : 0, 692229
BytebuddyAgent [candidate] (699.381 ms) : 0, 699381
AgentMeter [baseline] (9.098 ms) : 0, 9098
AgentMeter [candidate] (9.249 ms) : 0, 9249
GlobalTracer [baseline] (206.999 ms) : 0, 206999
GlobalTracer [candidate] (208.569 ms) : 0, 208569
AppSec [baseline] (32.785 ms) : 0, 32785
AppSec [candidate] (33.199 ms) : 0, 33199
Debugger [baseline] (65.441 ms) : 0, 65441
Debugger [candidate] (65.925 ms) : 0, 65925
Remote Config [baseline] (570.36 µs) : 0, 570
Remote Config [candidate] (579.539 µs) : 0, 580
Telemetry [baseline] (7.822 ms) : 0, 7822
Telemetry [candidate] (7.871 ms) : 0, 7871
Flare Poller [baseline] (3.6 ms) : 0, 3600
Flare Poller [candidate] (3.636 ms) : 0, 3636
ProfilingAgent [baseline] (94.391 ms) : 0, 94391
ProfilingAgent [candidate] (94.5 ms) : 0, 94500
Profiling [baseline] (94.967 ms) : 0, 94967
Profiling [candidate] (95.073 ms) : 0, 95073
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 1 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~fcfc49dad9, baseline=1.62.0-SNAPSHOT~42f154d2f6
dateFormat X
axisFormat %s
section baseline
no_agent (1.292 ms) : 1278, 1307
. : milestone, 1292,
iast (3.318 ms) : 3271, 3366
. : milestone, 3318,
iast_FULL (6.123 ms) : 6058, 6187
. : milestone, 6123,
iast_GLOBAL (3.693 ms) : 3632, 3753
. : milestone, 3693,
profiling (2.491 ms) : 2465, 2516
. : milestone, 2491,
tracing (1.949 ms) : 1932, 1966
. : milestone, 1949,
section candidate
no_agent (1.257 ms) : 1245, 1269
. : milestone, 1257,
iast (3.266 ms) : 3220, 3312
. : milestone, 3266,
iast_FULL (5.883 ms) : 5824, 5942
. : milestone, 5883,
iast_GLOBAL (3.744 ms) : 3681, 3807
. : milestone, 3744,
profiling (2.153 ms) : 2133, 2173
. : milestone, 2153,
tracing (1.917 ms) : 1901, 1934
. : milestone, 1917,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~fcfc49dad9, baseline=1.62.0-SNAPSHOT~42f154d2f6
dateFormat X
axisFormat %s
section baseline
no_agent (18.023 ms) : 17838, 18208
. : milestone, 18023,
appsec (18.807 ms) : 18613, 19002
. : milestone, 18807,
code_origins (17.927 ms) : 17748, 18106
. : milestone, 17927,
iast (19.24 ms) : 19049, 19431
. : milestone, 19240,
profiling (18.13 ms) : 17949, 18310
. : milestone, 18130,
tracing (17.632 ms) : 17457, 17807
. : milestone, 17632,
section candidate
no_agent (17.414 ms) : 17241, 17586
. : milestone, 17414,
appsec (18.706 ms) : 18514, 18898
. : milestone, 18706,
code_origins (17.868 ms) : 17691, 18045
. : milestone, 17868,
iast (18.299 ms) : 18117, 18481
. : milestone, 18299,
profiling (18.852 ms) : 18667, 19037
. : milestone, 18852,
tracing (17.759 ms) : 17584, 17934
. : milestone, 17759,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~fcfc49dad9, baseline=1.62.0-SNAPSHOT~42f154d2f6
dateFormat X
axisFormat %s
section baseline
no_agent (15.484 s) : 15484000, 15484000
. : milestone, 15484000,
appsec (14.629 s) : 14629000, 14629000
. : milestone, 14629000,
iast (18.702 s) : 18702000, 18702000
. : milestone, 18702000,
iast_GLOBAL (18.074 s) : 18074000, 18074000
. : milestone, 18074000,
profiling (14.868 s) : 14868000, 14868000
. : milestone, 14868000,
tracing (14.993 s) : 14993000, 14993000
. : milestone, 14993000,
section candidate
no_agent (15.496 s) : 15496000, 15496000
. : milestone, 15496000,
appsec (14.751 s) : 14751000, 14751000
. : milestone, 14751000,
iast (18.557 s) : 18557000, 18557000
. : milestone, 18557000,
iast_GLOBAL (18.306 s) : 18306000, 18306000
. : milestone, 18306000,
profiling (14.831 s) : 14831000, 14831000
. : milestone, 14831000,
tracing (14.843 s) : 14843000, 14843000
. : milestone, 14843000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~fcfc49dad9, baseline=1.62.0-SNAPSHOT~42f154d2f6
dateFormat X
axisFormat %s
section baseline
no_agent (1.489 ms) : 1477, 1501
. : milestone, 1489,
appsec (3.848 ms) : 3627, 4069
. : milestone, 3848,
iast (2.277 ms) : 2208, 2347
. : milestone, 2277,
iast_GLOBAL (2.326 ms) : 2256, 2395
. : milestone, 2326,
profiling (2.11 ms) : 2055, 2165
. : milestone, 2110,
tracing (2.078 ms) : 2024, 2132
. : milestone, 2078,
section candidate
no_agent (1.489 ms) : 1477, 1500
. : milestone, 1489,
appsec (2.537 ms) : 2483, 2592
. : milestone, 2537,
iast (2.279 ms) : 2210, 2348
. : milestone, 2279,
iast_GLOBAL (2.328 ms) : 2258, 2398
. : milestone, 2328,
profiling (2.11 ms) : 2055, 2166
. : milestone, 2110,
tracing (2.089 ms) : 2035, 2143
. : milestone, 2089,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
we migrate 3 tests:
Motivation
this is part of the effort to migrate groovy tests to Java/JUnit
part1: #11053
part2: #11062
part3: #11085
Additional Notes
fix some still existing groovy tests regarding ServieNameCollector singleton. see commit
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.