Migrate dd-trace-core groovy files to java part 4 #11146
Open
Migrate dd-trace-core groovy files to java part 4 #11146
Conversation
we migrate 3 tests: - CoreSpanBuilderTest - CoreTracerTest - DDSpanContextPropagationTagsTest
Contributor
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 13 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~9bce9c0a84, baseline=1.62.0-SNAPSHOT~42f154d2f6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1051968
Total [baseline] (8.808 s) : 0, 8807681
Agent [candidate] (1.058 s) : 0, 1057716
Total [candidate] (8.879 s) : 0, 8879374
section iast
Agent [baseline] (1.22 s) : 0, 1220156
Total [baseline] (9.519 s) : 0, 9518903
Agent [candidate] (1.222 s) : 0, 1222159
Total [candidate] (9.547 s) : 0, 9546918
gantt
title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~9bce9c0a84, baseline=1.62.0-SNAPSHOT~42f154d2f6
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.248 ms) : 0, 1248
crashtracking [candidate] (1.218 ms) : 0, 1218
BytebuddyAgent [baseline] (630.346 ms) : 0, 630346
BytebuddyAgent [candidate] (635.328 ms) : 0, 635328
AgentMeter [baseline] (29.44 ms) : 0, 29440
AgentMeter [candidate] (29.344 ms) : 0, 29344
GlobalTracer [baseline] (247.678 ms) : 0, 247678
GlobalTracer [candidate] (247.951 ms) : 0, 247951
AppSec [baseline] (32.207 ms) : 0, 32207
AppSec [candidate] (32.287 ms) : 0, 32287
Debugger [baseline] (58.976 ms) : 0, 58976
Debugger [candidate] (58.783 ms) : 0, 58783
Remote Config [baseline] (594.943 µs) : 0, 595
Remote Config [candidate] (584.963 µs) : 0, 585
Telemetry [baseline] (8.006 ms) : 0, 8006
Telemetry [candidate] (7.961 ms) : 0, 7961
Flare Poller [baseline] (7.377 ms) : 0, 7377
Flare Poller [candidate] (8.141 ms) : 0, 8141
section iast
crashtracking [baseline] (1.218 ms) : 0, 1218
crashtracking [candidate] (1.215 ms) : 0, 1215
BytebuddyAgent [baseline] (798.952 ms) : 0, 798952
BytebuddyAgent [candidate] (799.31 ms) : 0, 799310
AgentMeter [baseline] (11.312 ms) : 0, 11312
AgentMeter [candidate] (11.374 ms) : 0, 11374
GlobalTracer [baseline] (238.472 ms) : 0, 238472
GlobalTracer [candidate] (238.925 ms) : 0, 238925
IAST [baseline] (25.748 ms) : 0, 25748
IAST [candidate] (25.734 ms) : 0, 25734
AppSec [baseline] (31.965 ms) : 0, 31965
AppSec [candidate] (32.078 ms) : 0, 32078
Debugger [baseline] (60.116 ms) : 0, 60116
Debugger [candidate] (59.438 ms) : 0, 59438
Remote Config [baseline] (553.123 µs) : 0, 553
Remote Config [candidate] (1.723 ms) : 0, 1723
Telemetry [baseline] (12.013 ms) : 0, 12013
Telemetry [candidate] (12.732 ms) : 0, 12732
Flare Poller [baseline] (3.707 ms) : 0, 3707
Flare Poller [candidate] (3.503 ms) : 0, 3503
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~9bce9c0a84, baseline=1.62.0-SNAPSHOT~42f154d2f6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.058 s) : 0, 1058067
Total [baseline] (11.103 s) : 0, 11102932
Agent [candidate] (1.053 s) : 0, 1052862
Total [candidate] (11.106 s) : 0, 11106150
section appsec
Agent [baseline] (1.252 s) : 0, 1251959
Total [baseline] (11.108 s) : 0, 11107575
Agent [candidate] (1.246 s) : 0, 1245704
Total [candidate] (11.169 s) : 0, 11168616
section iast
Agent [baseline] (1.231 s) : 0, 1230879
Total [baseline] (11.286 s) : 0, 11285519
Agent [candidate] (1.231 s) : 0, 1230666
Total [candidate] (11.307 s) : 0, 11307143
section profiling
Agent [baseline] (1.183 s) : 0, 1183079
Total [baseline] (11.131 s) : 0, 11130841
Agent [candidate] (1.181 s) : 0, 1181299
Total [candidate] (11.084 s) : 0, 11084241
gantt
title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~9bce9c0a84, baseline=1.62.0-SNAPSHOT~42f154d2f6
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.228 ms) : 0, 1228
crashtracking [candidate] (1.21 ms) : 0, 1210
BytebuddyAgent [baseline] (632.534 ms) : 0, 632534
BytebuddyAgent [candidate] (629.809 ms) : 0, 629809
AgentMeter [baseline] (29.334 ms) : 0, 29334
AgentMeter [candidate] (29.324 ms) : 0, 29324
GlobalTracer [baseline] (249.759 ms) : 0, 249759
GlobalTracer [candidate] (247.882 ms) : 0, 247882
AppSec [baseline] (32.55 ms) : 0, 32550
AppSec [candidate] (32.151 ms) : 0, 32151
Debugger [baseline] (60.187 ms) : 0, 60187
Debugger [candidate] (59.717 ms) : 0, 59717
Remote Config [baseline] (605.26 µs) : 0, 605
Remote Config [candidate] (592.604 µs) : 0, 593
Telemetry [baseline] (8.14 ms) : 0, 8140
Telemetry [candidate] (7.99 ms) : 0, 7990
Flare Poller [baseline] (7.578 ms) : 0, 7578
Flare Poller [candidate] (8.218 ms) : 0, 8218
section appsec
crashtracking [baseline] (1.225 ms) : 0, 1225
crashtracking [candidate] (1.215 ms) : 0, 1215
BytebuddyAgent [baseline] (661.96 ms) : 0, 661960
BytebuddyAgent [candidate] (660.968 ms) : 0, 660968
AgentMeter [baseline] (12.133 ms) : 0, 12133
AgentMeter [candidate] (12.073 ms) : 0, 12073
GlobalTracer [baseline] (250.215 ms) : 0, 250215
GlobalTracer [candidate] (248.241 ms) : 0, 248241
IAST [baseline] (24.683 ms) : 0, 24683
IAST [candidate] (24.501 ms) : 0, 24501
AppSec [baseline] (186.28 ms) : 0, 186280
AppSec [candidate] (184.432 ms) : 0, 184432
Debugger [baseline] (66.395 ms) : 0, 66395
Debugger [candidate] (65.496 ms) : 0, 65496
Remote Config [baseline] (617.041 µs) : 0, 617
Remote Config [candidate] (602.09 µs) : 0, 602
Telemetry [baseline] (8.489 ms) : 0, 8489
Telemetry [candidate] (8.422 ms) : 0, 8422
Flare Poller [baseline] (3.576 ms) : 0, 3576
Flare Poller [candidate] (3.53 ms) : 0, 3530
section iast
crashtracking [baseline] (1.231 ms) : 0, 1231
crashtracking [candidate] (1.227 ms) : 0, 1227
BytebuddyAgent [baseline] (806.228 ms) : 0, 806228
BytebuddyAgent [candidate] (805.852 ms) : 0, 805852
AgentMeter [baseline] (11.611 ms) : 0, 11611
AgentMeter [candidate] (11.491 ms) : 0, 11491
GlobalTracer [baseline] (239.793 ms) : 0, 239793
GlobalTracer [candidate] (240.105 ms) : 0, 240105
IAST [baseline] (25.949 ms) : 0, 25949
IAST [candidate] (25.94 ms) : 0, 25940
AppSec [baseline] (32.91 ms) : 0, 32910
AppSec [candidate] (33.046 ms) : 0, 33046
Debugger [baseline] (61.686 ms) : 0, 61686
Debugger [candidate] (60.813 ms) : 0, 60813
Remote Config [baseline] (542.633 µs) : 0, 543
Remote Config [candidate] (543.093 µs) : 0, 543
Telemetry [baseline] (11.152 ms) : 0, 11152
Telemetry [candidate] (11.521 ms) : 0, 11521
Flare Poller [baseline] (3.498 ms) : 0, 3498
Flare Poller [candidate] (3.49 ms) : 0, 3490
section profiling
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (690.692 ms) : 0, 690692
BytebuddyAgent [candidate] (689.769 ms) : 0, 689769
AgentMeter [baseline] (9.116 ms) : 0, 9116
AgentMeter [candidate] (9.079 ms) : 0, 9079
GlobalTracer [baseline] (207.134 ms) : 0, 207134
GlobalTracer [candidate] (206.575 ms) : 0, 206575
AppSec [baseline] (32.761 ms) : 0, 32761
AppSec [candidate] (32.861 ms) : 0, 32861
Debugger [baseline] (65.456 ms) : 0, 65456
Debugger [candidate] (65.408 ms) : 0, 65408
Remote Config [baseline] (573.659 µs) : 0, 574
Remote Config [candidate] (563.358 µs) : 0, 563
Telemetry [baseline] (7.846 ms) : 0, 7846
Telemetry [candidate] (7.799 ms) : 0, 7799
Flare Poller [baseline] (3.573 ms) : 0, 3573
Flare Poller [candidate] (3.537 ms) : 0, 3537
ProfilingAgent [baseline] (93.676 ms) : 0, 93676
ProfilingAgent [candidate] (93.617 ms) : 0, 93617
Profiling [baseline] (94.239 ms) : 0, 94239
Profiling [candidate] (94.182 ms) : 0, 94182
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 5 performance regressions! Performance is the same for 13 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~9bce9c0a84, baseline=1.62.0-SNAPSHOT~42f154d2f6
dateFormat X
axisFormat %s
section baseline
no_agent (17.567 ms) : 17389, 17745
. : milestone, 17567,
appsec (18.839 ms) : 18649, 19029
. : milestone, 18839,
code_origins (18.111 ms) : 17933, 18289
. : milestone, 18111,
iast (18.967 ms) : 18773, 19161
. : milestone, 18967,
profiling (17.999 ms) : 17819, 18178
. : milestone, 17999,
tracing (18.98 ms) : 18789, 19170
. : milestone, 18980,
section candidate
no_agent (18.616 ms) : 18427, 18804
. : milestone, 18616,
appsec (18.578 ms) : 18391, 18766
. : milestone, 18578,
code_origins (17.7 ms) : 17525, 17874
. : milestone, 17700,
iast (17.865 ms) : 17690, 18039
. : milestone, 17865,
profiling (19.823 ms) : 19622, 20024
. : milestone, 19823,
tracing (19.137 ms) : 18943, 19331
. : milestone, 19137,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~9bce9c0a84, baseline=1.62.0-SNAPSHOT~42f154d2f6
dateFormat X
axisFormat %s
section baseline
no_agent (1.254 ms) : 1241, 1267
. : milestone, 1254,
iast (3.196 ms) : 3154, 3239
. : milestone, 3196,
iast_FULL (6.284 ms) : 6218, 6350
. : milestone, 6284,
iast_GLOBAL (3.728 ms) : 3667, 3789
. : milestone, 3728,
profiling (2.08 ms) : 2062, 2098
. : milestone, 2080,
tracing (1.839 ms) : 1823, 1854
. : milestone, 1839,
section candidate
no_agent (1.232 ms) : 1221, 1244
. : milestone, 1232,
iast (3.462 ms) : 3416, 3508
. : milestone, 3462,
iast_FULL (6.107 ms) : 6046, 6168
. : milestone, 6107,
iast_GLOBAL (3.722 ms) : 3659, 3786
. : milestone, 3722,
profiling (2.377 ms) : 2352, 2402
. : milestone, 2377,
tracing (1.878 ms) : 1862, 1895
. : milestone, 1878,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~9bce9c0a84, baseline=1.62.0-SNAPSHOT~42f154d2f6
dateFormat X
axisFormat %s
section baseline
no_agent (1.482 ms) : 1470, 1493
. : milestone, 1482,
appsec (2.518 ms) : 2464, 2573
. : milestone, 2518,
iast (2.265 ms) : 2196, 2333
. : milestone, 2265,
iast_GLOBAL (2.309 ms) : 2240, 2379
. : milestone, 2309,
profiling (2.086 ms) : 2031, 2140
. : milestone, 2086,
tracing (2.09 ms) : 2036, 2144
. : milestone, 2090,
section candidate
no_agent (1.485 ms) : 1473, 1496
. : milestone, 1485,
appsec (3.819 ms) : 3596, 4041
. : milestone, 3819,
iast (2.272 ms) : 2202, 2341
. : milestone, 2272,
iast_GLOBAL (2.304 ms) : 2234, 2373
. : milestone, 2304,
profiling (2.086 ms) : 2031, 2141
. : milestone, 2086,
tracing (2.071 ms) : 2018, 2125
. : milestone, 2071,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~9bce9c0a84, baseline=1.62.0-SNAPSHOT~42f154d2f6
dateFormat X
axisFormat %s
section baseline
no_agent (15.362 s) : 15362000, 15362000
. : milestone, 15362000,
appsec (15.028 s) : 15028000, 15028000
. : milestone, 15028000,
iast (18.066 s) : 18066000, 18066000
. : milestone, 18066000,
iast_GLOBAL (18.096 s) : 18096000, 18096000
. : milestone, 18096000,
profiling (14.929 s) : 14929000, 14929000
. : milestone, 14929000,
tracing (14.961 s) : 14961000, 14961000
. : milestone, 14961000,
section candidate
no_agent (15.518 s) : 15518000, 15518000
. : milestone, 15518000,
appsec (14.774 s) : 14774000, 14774000
. : milestone, 14774000,
iast (18.294 s) : 18294000, 18294000
. : milestone, 18294000,
iast_GLOBAL (18.236 s) : 18236000, 18236000
. : milestone, 18236000,
profiling (15.531 s) : 15531000, 15531000
. : milestone, 15531000,
tracing (14.897 s) : 14897000, 14897000
. : milestone, 14897000,
|
we save the original instance before replaced by mock to restore it Some tests rely on having. the original, and depending on the order the class my keep the mocks instead resulting in errors
fcfc49d to
9bce9c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
we migrate 3 tests:
Motivation
this is part of the effort to migrate groovy tests to Java/JUnit
part1: #11053
part2: #11062
part3: #11085
Additional Notes
fix some still existing groovy tests regarding ServieNameCollector singleton. see commit
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.