Remove deprecated startSpan and use integration name for telemetry#11181
Draft
Remove deprecated startSpan and use integration name for telemetry#11181
Conversation
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~70e7c69855, baseline=1.62.0-SNAPSHOT~d4d2069709
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1051568
Total [baseline] (8.866 s) : 0, 8865836
Agent [candidate] (1.065 s) : 0, 1064534
Total [candidate] (8.867 s) : 0, 8867264
section iast
Agent [baseline] (1.236 s) : 0, 1236344
Total [baseline] (9.535 s) : 0, 9534875
Agent [candidate] (1.232 s) : 0, 1231742
Total [candidate] (9.561 s) : 0, 9561352
gantt
title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~70e7c69855, baseline=1.62.0-SNAPSHOT~d4d2069709
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.242 ms) : 0, 1242
crashtracking [candidate] (1.231 ms) : 0, 1231
BytebuddyAgent [baseline] (633.7 ms) : 0, 633700
BytebuddyAgent [candidate] (642.384 ms) : 0, 642384
AgentMeter [baseline] (29.444 ms) : 0, 29444
AgentMeter [candidate] (29.711 ms) : 0, 29711
GlobalTracer [baseline] (247.918 ms) : 0, 247918
GlobalTracer [candidate] (249.688 ms) : 0, 249688
AppSec [baseline] (32.249 ms) : 0, 32249
AppSec [candidate] (32.491 ms) : 0, 32491
Debugger [baseline] (58.899 ms) : 0, 58899
Debugger [candidate] (58.996 ms) : 0, 58996
Remote Config [baseline] (589.511 µs) : 0, 590
Remote Config [candidate] (584.798 µs) : 0, 585
Telemetry [baseline] (7.992 ms) : 0, 7992
Telemetry [candidate] (8.002 ms) : 0, 8002
Flare Poller [baseline] (3.531 ms) : 0, 3531
Flare Poller [candidate] (5.122 ms) : 0, 5122
section iast
crashtracking [baseline] (1.229 ms) : 0, 1229
crashtracking [candidate] (1.214 ms) : 0, 1214
BytebuddyAgent [baseline] (814.999 ms) : 0, 814999
BytebuddyAgent [candidate] (809.618 ms) : 0, 809618
AgentMeter [baseline] (11.54 ms) : 0, 11540
AgentMeter [candidate] (11.366 ms) : 0, 11366
GlobalTracer [baseline] (238.644 ms) : 0, 238644
GlobalTracer [candidate] (239.1 ms) : 0, 239100
AppSec [baseline] (28.351 ms) : 0, 28351
AppSec [candidate] (30.076 ms) : 0, 30076
Debugger [baseline] (64.61 ms) : 0, 64610
Debugger [candidate] (64.226 ms) : 0, 64226
Remote Config [baseline] (531.932 µs) : 0, 532
Remote Config [candidate] (538.699 µs) : 0, 539
Telemetry [baseline] (7.775 ms) : 0, 7775
Telemetry [candidate] (7.817 ms) : 0, 7817
Flare Poller [baseline] (3.423 ms) : 0, 3423
Flare Poller [candidate] (3.458 ms) : 0, 3458
IAST [baseline] (29.097 ms) : 0, 29097
IAST [candidate] (28.274 ms) : 0, 28274
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~70e7c69855, baseline=1.62.0-SNAPSHOT~d4d2069709
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1060812
Total [baseline] (11.053 s) : 0, 11053210
Agent [candidate] (1.058 s) : 0, 1057866
Total [candidate] (11.029 s) : 0, 11028666
section appsec
Agent [baseline] (1.265 s) : 0, 1264979
Total [baseline] (11.119 s) : 0, 11118995
Agent [candidate] (1.263 s) : 0, 1262972
Total [candidate] (11.074 s) : 0, 11074115
section iast
Agent [baseline] (1.239 s) : 0, 1239445
Total [baseline] (11.226 s) : 0, 11226376
Agent [candidate] (1.235 s) : 0, 1234897
Total [candidate] (11.324 s) : 0, 11324344
section profiling
Agent [baseline] (1.183 s) : 0, 1183474
Total [baseline] (10.989 s) : 0, 10988783
Agent [candidate] (1.195 s) : 0, 1194513
Total [candidate] (11.147 s) : 0, 11146759
gantt
title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~70e7c69855, baseline=1.62.0-SNAPSHOT~d4d2069709
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.287 ms) : 0, 1287
crashtracking [candidate] (1.219 ms) : 0, 1219
BytebuddyAgent [baseline] (638.083 ms) : 0, 638083
BytebuddyAgent [candidate] (635.376 ms) : 0, 635376
AgentMeter [baseline] (29.597 ms) : 0, 29597
AgentMeter [candidate] (29.441 ms) : 0, 29441
GlobalTracer [baseline] (248.911 ms) : 0, 248911
GlobalTracer [candidate] (249.254 ms) : 0, 249254
AppSec [baseline] (32.497 ms) : 0, 32497
AppSec [candidate] (32.268 ms) : 0, 32268
Debugger [baseline] (59.779 ms) : 0, 59779
Debugger [candidate] (59.679 ms) : 0, 59679
Remote Config [baseline] (594.48 µs) : 0, 594
Remote Config [candidate] (607.312 µs) : 0, 607
Telemetry [baseline] (8.128 ms) : 0, 8128
Telemetry [candidate] (8.876 ms) : 0, 8876
Flare Poller [baseline] (5.845 ms) : 0, 5845
Flare Poller [candidate] (5.049 ms) : 0, 5049
section appsec
crashtracking [baseline] (1.217 ms) : 0, 1217
crashtracking [candidate] (1.217 ms) : 0, 1217
BytebuddyAgent [baseline] (676.429 ms) : 0, 676429
BytebuddyAgent [candidate] (676.059 ms) : 0, 676059
AgentMeter [baseline] (12.209 ms) : 0, 12209
AgentMeter [candidate] (12.266 ms) : 0, 12266
GlobalTracer [baseline] (249.133 ms) : 0, 249133
GlobalTracer [candidate] (249.385 ms) : 0, 249385
AppSec [baseline] (187.32 ms) : 0, 187320
AppSec [candidate] (185.683 ms) : 0, 185683
Debugger [baseline] (65.875 ms) : 0, 65875
Debugger [candidate] (66.01 ms) : 0, 66010
Remote Config [baseline] (596.343 µs) : 0, 596
Remote Config [candidate] (575.128 µs) : 0, 575
Telemetry [baseline] (8.025 ms) : 0, 8025
Telemetry [candidate] (7.811 ms) : 0, 7811
Flare Poller [baseline] (3.552 ms) : 0, 3552
Flare Poller [candidate] (3.453 ms) : 0, 3453
IAST [baseline] (24.232 ms) : 0, 24232
IAST [candidate] (24.197 ms) : 0, 24197
section iast
crashtracking [baseline] (1.224 ms) : 0, 1224
crashtracking [candidate] (1.214 ms) : 0, 1214
BytebuddyAgent [baseline] (815.339 ms) : 0, 815339
BytebuddyAgent [candidate] (812.599 ms) : 0, 812599
AgentMeter [baseline] (11.483 ms) : 0, 11483
AgentMeter [candidate] (11.401 ms) : 0, 11401
GlobalTracer [baseline] (239.859 ms) : 0, 239859
GlobalTracer [candidate] (239.732 ms) : 0, 239732
AppSec [baseline] (28.611 ms) : 0, 28611
AppSec [candidate] (26.431 ms) : 0, 26431
Debugger [baseline] (66.637 ms) : 0, 66637
Debugger [candidate] (62.65 ms) : 0, 62650
Remote Config [baseline] (531.438 µs) : 0, 531
Remote Config [candidate] (528.755 µs) : 0, 529
Telemetry [baseline] (7.773 ms) : 0, 7773
Telemetry [candidate] (7.683 ms) : 0, 7683
Flare Poller [baseline] (3.419 ms) : 0, 3419
Flare Poller [candidate] (3.345 ms) : 0, 3345
IAST [baseline] (28.468 ms) : 0, 28468
IAST [candidate] (33.362 ms) : 0, 33362
section profiling
crashtracking [baseline] (1.18 ms) : 0, 1180
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (691.038 ms) : 0, 691038
BytebuddyAgent [candidate] (697.617 ms) : 0, 697617
AgentMeter [baseline] (8.923 ms) : 0, 8923
AgentMeter [candidate] (9.074 ms) : 0, 9074
GlobalTracer [baseline] (207.077 ms) : 0, 207077
GlobalTracer [candidate] (209.19 ms) : 0, 209190
AppSec [baseline] (32.583 ms) : 0, 32583
AppSec [candidate] (32.858 ms) : 0, 32858
Debugger [baseline] (65.424 ms) : 0, 65424
Debugger [candidate] (66.29 ms) : 0, 66290
Remote Config [baseline] (571.345 µs) : 0, 571
Remote Config [candidate] (573.897 µs) : 0, 574
Telemetry [baseline] (7.811 ms) : 0, 7811
Telemetry [candidate] (7.901 ms) : 0, 7901
Flare Poller [baseline] (3.486 ms) : 0, 3486
Flare Poller [candidate] (3.554 ms) : 0, 3554
ProfilingAgent [baseline] (94.067 ms) : 0, 94067
ProfilingAgent [candidate] (94.533 ms) : 0, 94533
Profiling [baseline] (94.628 ms) : 0, 94628
Profiling [candidate] (95.087 ms) : 0, 95087
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~70e7c69855, baseline=1.62.0-SNAPSHOT~d4d2069709
dateFormat X
axisFormat %s
section baseline
no_agent (19.538 ms) : 19339, 19737
. : milestone, 19538,
appsec (18.811 ms) : 18621, 19001
. : milestone, 18811,
code_origins (18.024 ms) : 17848, 18199
. : milestone, 18024,
iast (18.1 ms) : 17918, 18282
. : milestone, 18100,
profiling (18.489 ms) : 18303, 18676
. : milestone, 18489,
tracing (18.104 ms) : 17923, 18285
. : milestone, 18104,
section candidate
no_agent (19.644 ms) : 19442, 19845
. : milestone, 19644,
appsec (18.842 ms) : 18650, 19034
. : milestone, 18842,
code_origins (18.893 ms) : 18700, 19085
. : milestone, 18893,
iast (17.935 ms) : 17756, 18114
. : milestone, 17935,
profiling (18.713 ms) : 18530, 18896
. : milestone, 18713,
tracing (18.632 ms) : 18445, 18819
. : milestone, 18632,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~70e7c69855, baseline=1.62.0-SNAPSHOT~d4d2069709
dateFormat X
axisFormat %s
section baseline
no_agent (1.24 ms) : 1228, 1252
. : milestone, 1240,
iast (3.43 ms) : 3380, 3480
. : milestone, 3430,
iast_FULL (6.038 ms) : 5976, 6100
. : milestone, 6038,
iast_GLOBAL (3.637 ms) : 3578, 3696
. : milestone, 3637,
profiling (2.066 ms) : 2048, 2083
. : milestone, 2066,
tracing (1.948 ms) : 1931, 1965
. : milestone, 1948,
section candidate
no_agent (1.244 ms) : 1232, 1256
. : milestone, 1244,
iast (3.3 ms) : 3249, 3351
. : milestone, 3300,
iast_FULL (5.901 ms) : 5842, 5960
. : milestone, 5901,
iast_GLOBAL (3.662 ms) : 3607, 3717
. : milestone, 3662,
profiling (2.425 ms) : 2401, 2449
. : milestone, 2425,
tracing (1.929 ms) : 1912, 1946
. : milestone, 1929,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 1 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~70e7c69855, baseline=1.62.0-SNAPSHOT~d4d2069709
dateFormat X
axisFormat %s
section baseline
no_agent (1.49 ms) : 1478, 1502
. : milestone, 1490,
appsec (3.859 ms) : 3636, 4082
. : milestone, 3859,
iast (2.278 ms) : 2208, 2347
. : milestone, 2278,
iast_GLOBAL (2.32 ms) : 2250, 2390
. : milestone, 2320,
profiling (2.109 ms) : 2054, 2164
. : milestone, 2109,
tracing (2.1 ms) : 2046, 2154
. : milestone, 2100,
section candidate
no_agent (1.49 ms) : 1478, 1502
. : milestone, 1490,
appsec (2.531 ms) : 2477, 2586
. : milestone, 2531,
iast (2.276 ms) : 2206, 2345
. : milestone, 2276,
iast_GLOBAL (2.319 ms) : 2249, 2389
. : milestone, 2319,
profiling (2.531 ms) : 2369, 2694
. : milestone, 2531,
tracing (2.091 ms) : 2038, 2145
. : milestone, 2091,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~70e7c69855, baseline=1.62.0-SNAPSHOT~d4d2069709
dateFormat X
axisFormat %s
section baseline
no_agent (15.461 s) : 15461000, 15461000
. : milestone, 15461000,
appsec (15.101 s) : 15101000, 15101000
. : milestone, 15101000,
iast (18.562 s) : 18562000, 18562000
. : milestone, 18562000,
iast_GLOBAL (17.866 s) : 17866000, 17866000
. : milestone, 17866000,
profiling (14.844 s) : 14844000, 14844000
. : milestone, 14844000,
tracing (15.037 s) : 15037000, 15037000
. : milestone, 15037000,
section candidate
no_agent (15.362 s) : 15362000, 15362000
. : milestone, 15362000,
appsec (15.076 s) : 15076000, 15076000
. : milestone, 15076000,
iast (18.939 s) : 18939000, 18939000
. : milestone, 18939000,
iast_GLOBAL (17.921 s) : 17921000, 17921000
. : milestone, 17921000,
profiling (15.584 s) : 15584000, 15584000
. : milestone, 15584000,
tracing (15.11 s) : 15110000, 15110000
. : milestone, 15110000,
|
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
be63ca7 to
abab0a5
Compare
abab0a5 to
d069edd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Removes the 4 deprecated
startSpanoverloads fromAgentTracerthat accepted aCharSequencespan name as the only/first argument and defaulted to"datadog"as the instrumentation name:All ~145 call sites across ~143 instrumentation files have been migrated to the non-deprecated form that explicitly passes the integration's own name as the first
Stringargument (matchinginstrumentationNames()[0]from the nearest decorator). This ensures spans are attributed to the correct integration rather than the generic"datadog"default.The private
DEFAULT_INSTRUMENTATION_NAME = "datadog"constant inAgentTraceris also removed; the two remaining deprecated methods inTracerAPI(buildSpan(CharSequence)andsingleSpanBuilder(CharSequence)) now inline the"datadog"literal directly.No behaviour change — this is a pure refactor. The instrumentation name passed to the tracer now matches what each integration already declared as its own name.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.