Skip to content

Update evaluation reason for empty waterfall to DEFAULT instead of ERROR/GENERAL per REASON.9 #11193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 3 commits into from
Apr 29, 2026
+5 −4
Merged

Update evaluation reason for empty waterfall to DEFAULT instead of ERROR/GENERAL per REASON.9 #11193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4104dc6
Fix REASON-9: empty allocations waterfall returns DEFAULT not GENERAL
typotter Apr 23, 2026
7a36352
fix(ffe): add null-allocations guard; fix empty-allocs test expectation
typotter Apr 28, 2026
f1be827
Update error message for null allocations in feature flag
typotter Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...lagging/feature-flagging-api/src/main/java/datadog/trace/api/openfeature/DDEvaluator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,8 @@ public <T> ProviderEvaluation<T> evaluate(
.build();
}

if (isEmpty(flag.allocations)) {
return error(defaultValue, ErrorCode.GENERAL, "Missing allocations for flag " + flag.key);
if (flag.allocations == null) {
Copy link
Copy Markdown
Contributor Author

@typotter typotter Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dropping the guard here lets us fall through to the default return below.
Open to adding a short circuit instead if that makes it more readable here.

return error(defaultValue, ErrorCode.GENERAL, "Missing allocations for flag " + key);
}

final Date now = new Date();
Expand Down
5 changes: 3 additions & 2 deletions ...ing/feature-flagging-api/src/test/java/datadog/trace/api/openfeature/DDEvaluatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
import static java.util.Collections.emptyMap;
import static java.util.Collections.singletonList;
import static org.hamcrest.CoreMatchers.equalTo;
import static org.hamcrest.CoreMatchers.nullValue;
import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.hasEntry;
import static org.hamcrest.Matchers.oneOf;
Expand Down Expand Up @@ -174,8 +175,8 @@ public void testNoAllocations() {

details = evaluator.evaluate(Integer.class, "empty-allocation", 23, ctx);
assertThat(details.getValue(), equalTo(23));
assertThat(details.getReason(), equalTo(ERROR.name()));
assertThat(details.getErrorCode(), equalTo(ErrorCode.GENERAL));
assertThat(details.getReason(), equalTo(DEFAULT.name()));
assertThat(details.getErrorCode(), nullValue());
}

private static Arguments[] flatteningTestCases() {
Expand Down
Loading