Skip to content

Update TestNG6 DTD resolution during tests#11206

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomasterfrom
daniel.mohedano/testng-dtd-resolution
Apr 27, 2026
Merged

Update TestNG6 DTD resolution during tests#11206
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomasterfrom
daniel.mohedano/testng-dtd-resolution

Conversation

@daniel-mohedano
Copy link
Copy Markdown
Contributor

@daniel-mohedano daniel-mohedano commented Apr 27, 2026 •
edited
Loading

What Does This Do

  • In TestNG instrumentation tests related to XML-defined test suites, switches the DTD URL in <!DOCTYPE suite SYSTEM …> from https://testng.org/testng-1.0.dtd to http://testng.org/testng-1.0.dtd so the XML parser relies on the classpath-bundled DTD.

Motivation

TestNG's XML parsers will try to resolve and validate the DTD definition when running the test suites. This is a source of flakiness for the instrumentation tests as the resolution depends on network calls.

Additional Notes

test-environment-trigger: skip

Contributor Checklist

Jira ticket: [PROJ-IDENT]

Note: Once your PR is ready to merge, add it to the merge queue by commenting /merge. /merge -c cancels the queue request. /merge -f --reason "reason" skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.

@daniel-mohedano daniel-mohedano added type: enhancement Enhancements and improvements tag: no release notes Changes to exclude from release notes comp: ci visibility Continuous Integration Visibility labels Apr 27, 2026
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Apr 27, 2026 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master daniel.mohedano/testng-dtd-resolution
git_commit_date 1777278065 1777292225
git_commit_sha 53af2b0 bdd3c27
release_version 1.62.0-SNAPSHOT~53af2b0381 1.62.0-SNAPSHOT~bdd3c272f9
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1777293974 1777293974
ci_job_id 1633186215 1633186215
ci_pipeline_id 109873693 109873693
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-fp7wvwl9 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-fp7wvwl9 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~bdd3c272f9, baseline=1.62.0-SNAPSHOT~53af2b0381

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.058 s) : 0, 1058399
Total [baseline] (8.861 s) : 0, 8861305
Agent [candidate] (1.057 s) : 0, 1057339
Total [candidate] (8.863 s) : 0, 8863158
section iast
Agent [baseline] (1.237 s) : 0, 1236634
Total [baseline] (9.594 s) : 0, 9593530
Agent [candidate] (1.234 s) : 0, 1234488
Total [candidate] (9.545 s) : 0, 9544771
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.058 s -
Agent iast 1.237 s 178.236 ms (16.8%)
Total tracing 8.861 s -
Total iast 9.594 s 732.224 ms (8.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.057 s -
Agent iast 1.234 s 177.15 ms (16.8%)
Total tracing 8.863 s -
Total iast 9.545 s 681.612 ms (7.7%) 
gantt
    title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~bdd3c272f9, baseline=1.62.0-SNAPSHOT~53af2b0381

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.229 ms) : 0, 1229
crashtracking [candidate] (1.231 ms) : 0, 1231
BytebuddyAgent [baseline] (637.051 ms) : 0, 637051
BytebuddyAgent [candidate] (635.814 ms) : 0, 635814
AgentMeter [baseline] (29.647 ms) : 0, 29647
AgentMeter [candidate] (29.786 ms) : 0, 29786
GlobalTracer [baseline] (248.879 ms) : 0, 248879
GlobalTracer [candidate] (249.758 ms) : 0, 249758
AppSec [baseline] (32.369 ms) : 0, 32369
AppSec [candidate] (32.491 ms) : 0, 32491
Debugger [baseline] (59.805 ms) : 0, 59805
Debugger [candidate] (59.74 ms) : 0, 59740
Remote Config [baseline] (615.862 µs) : 0, 616
Remote Config [candidate] (604.239 µs) : 0, 604
Telemetry [baseline] (8.069 ms) : 0, 8069
Telemetry [candidate] (8.1 ms) : 0, 8100
Flare Poller [baseline] (4.424 ms) : 0, 4424
Flare Poller [candidate] (3.572 ms) : 0, 3572
section iast
crashtracking [baseline] (1.237 ms) : 0, 1237
crashtracking [candidate] (1.223 ms) : 0, 1223
BytebuddyAgent [baseline] (813.995 ms) : 0, 813995
BytebuddyAgent [candidate] (811.857 ms) : 0, 811857
AgentMeter [baseline] (11.395 ms) : 0, 11395
AgentMeter [candidate] (11.389 ms) : 0, 11389
GlobalTracer [baseline] (239.658 ms) : 0, 239658
GlobalTracer [candidate] (239.665 ms) : 0, 239665
IAST [baseline] (29.37 ms) : 0, 29370
IAST [candidate] (30.091 ms) : 0, 30091
AppSec [baseline] (27.735 ms) : 0, 27735
AppSec [candidate] (28.585 ms) : 0, 28585
Debugger [baseline] (65.313 ms) : 0, 65313
Debugger [candidate] (63.892 ms) : 0, 63892
Remote Config [baseline] (547.377 µs) : 0, 547
Remote Config [candidate] (533.538 µs) : 0, 534
Telemetry [baseline] (7.746 ms) : 0, 7746
Telemetry [candidate] (7.816 ms) : 0, 7816
Flare Poller [baseline] (3.458 ms) : 0, 3458
Flare Poller [candidate] (3.397 ms) : 0, 3397
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~bdd3c272f9, baseline=1.62.0-SNAPSHOT~53af2b0381

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.072 s) : 0, 1072026
Total [baseline] (11.167 s) : 0, 11166784
Agent [candidate] (1.057 s) : 0, 1057076
Total [candidate] (11.193 s) : 0, 11193016
section appsec
Agent [baseline] (1.273 s) : 0, 1273106
Total [baseline] (11.181 s) : 0, 11181494
Agent [candidate] (1.276 s) : 0, 1276222
Total [candidate] (11.135 s) : 0, 11134690
section iast
Agent [baseline] (1.235 s) : 0, 1235014
Total [baseline] (11.311 s) : 0, 11311266
Agent [candidate] (1.234 s) : 0, 1234317
Total [candidate] (11.319 s) : 0, 11319157
section profiling
Agent [baseline] (1.194 s) : 0, 1194046
Total [baseline] (11.085 s) : 0, 11085141
Agent [candidate] (1.187 s) : 0, 1186884
Total [candidate] (11.035 s) : 0, 11034538
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.072 s -
Agent appsec 1.273 s 201.08 ms (18.8%)
Agent iast 1.235 s 162.988 ms (15.2%)
Agent profiling 1.194 s 122.02 ms (11.4%)
Total tracing 11.167 s -
Total appsec 11.181 s 14.71 ms (0.1%)
Total iast 11.311 s 144.481 ms (1.3%)
Total profiling 11.085 s -81.643 ms (-0.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.057 s -
Agent appsec 1.276 s 219.145 ms (20.7%)
Agent iast 1.234 s 177.241 ms (16.8%)
Agent profiling 1.187 s 129.808 ms (12.3%)
Total tracing 11.193 s -
Total appsec 11.135 s -58.326 ms (-0.5%)
Total iast 11.319 s 126.141 ms (1.1%)
Total profiling 11.035 s -158.479 ms (-1.4%) 
gantt
    title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~bdd3c272f9, baseline=1.62.0-SNAPSHOT~53af2b0381

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.26 ms) : 0, 1260
crashtracking [candidate] (1.236 ms) : 0, 1236
BytebuddyAgent [baseline] (644.718 ms) : 0, 644718
BytebuddyAgent [candidate] (636.306 ms) : 0, 636306
AgentMeter [baseline] (29.994 ms) : 0, 29994
AgentMeter [candidate] (29.526 ms) : 0, 29526
GlobalTracer [baseline] (251.366 ms) : 0, 251366
GlobalTracer [candidate] (249.144 ms) : 0, 249144
AppSec [baseline] (32.817 ms) : 0, 32817
AppSec [candidate] (32.276 ms) : 0, 32276
Debugger [baseline] (61.352 ms) : 0, 61352
Debugger [candidate] (60.147 ms) : 0, 60147
Remote Config [baseline] (617.947 µs) : 0, 618
Remote Config [candidate] (605.539 µs) : 0, 606
Telemetry [baseline] (8.18 ms) : 0, 8180
Telemetry [candidate] (8.091 ms) : 0, 8091
Flare Poller [baseline] (5.235 ms) : 0, 5235
Flare Poller [candidate] (3.584 ms) : 0, 3584
section appsec
crashtracking [baseline] (1.241 ms) : 0, 1241
crashtracking [candidate] (1.248 ms) : 0, 1248
BytebuddyAgent [baseline] (679.723 ms) : 0, 679723
BytebuddyAgent [candidate] (684.983 ms) : 0, 684983
AgentMeter [baseline] (12.294 ms) : 0, 12294
AgentMeter [candidate] (12.414 ms) : 0, 12414
GlobalTracer [baseline] (252.186 ms) : 0, 252186
GlobalTracer [candidate] (251.169 ms) : 0, 251169
IAST [baseline] (24.47 ms) : 0, 24470
IAST [candidate] (24.41 ms) : 0, 24410
AppSec [baseline] (188.621 ms) : 0, 188621
AppSec [candidate] (189.724 ms) : 0, 189724
Debugger [baseline] (65.907 ms) : 0, 65907
Debugger [candidate] (63.678 ms) : 0, 63678
Remote Config [baseline] (594.051 µs) : 0, 594
Remote Config [candidate] (576.124 µs) : 0, 576
Telemetry [baseline] (8.032 ms) : 0, 8032
Telemetry [candidate] (7.967 ms) : 0, 7967
Flare Poller [baseline] (3.523 ms) : 0, 3523
Flare Poller [candidate] (3.477 ms) : 0, 3477
section iast
crashtracking [baseline] (1.226 ms) : 0, 1226
crashtracking [candidate] (1.222 ms) : 0, 1222
BytebuddyAgent [baseline] (812.292 ms) : 0, 812292
BytebuddyAgent [candidate] (811.26 ms) : 0, 811260
AgentMeter [baseline] (11.42 ms) : 0, 11420
AgentMeter [candidate] (11.384 ms) : 0, 11384
GlobalTracer [baseline] (239.547 ms) : 0, 239547
GlobalTracer [candidate] (239.359 ms) : 0, 239359
IAST [baseline] (31.802 ms) : 0, 31802
IAST [candidate] (29.225 ms) : 0, 29225
AppSec [baseline] (28.243 ms) : 0, 28243
AppSec [candidate] (30.107 ms) : 0, 30107
Debugger [baseline] (62.863 ms) : 0, 62863
Debugger [candidate] (63.948 ms) : 0, 63948
Remote Config [baseline] (539.145 µs) : 0, 539
Remote Config [candidate] (531.161 µs) : 0, 531
Telemetry [baseline] (7.678 ms) : 0, 7678
Telemetry [candidate] (7.813 ms) : 0, 7813
Flare Poller [baseline] (3.397 ms) : 0, 3397
Flare Poller [candidate] (3.442 ms) : 0, 3442
section profiling
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.171 ms) : 0, 1171
BytebuddyAgent [baseline] (697.398 ms) : 0, 697398
BytebuddyAgent [candidate] (693.81 ms) : 0, 693810
AgentMeter [baseline] (8.971 ms) : 0, 8971
AgentMeter [candidate] (9.002 ms) : 0, 9002
GlobalTracer [baseline] (208.761 ms) : 0, 208761
GlobalTracer [candidate] (207.85 ms) : 0, 207850
AppSec [baseline] (32.894 ms) : 0, 32894
AppSec [candidate] (32.552 ms) : 0, 32552
Debugger [baseline] (66.457 ms) : 0, 66457
Debugger [candidate] (65.57 ms) : 0, 65570
Remote Config [baseline] (587.921 µs) : 0, 588
Remote Config [candidate] (574.419 µs) : 0, 574
Telemetry [baseline] (7.828 ms) : 0, 7828
Telemetry [candidate] (7.81 ms) : 0, 7810
Flare Poller [baseline] (3.514 ms) : 0, 3514
Flare Poller [candidate] (3.483 ms) : 0, 3483
ProfilingAgent [baseline] (94.419 ms) : 0, 94419
ProfilingAgent [candidate] (93.568 ms) : 0, 93568
Profiling [baseline] (95.006 ms) : 0, 95006
Profiling [candidate] (94.125 ms) : 0, 94125
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master daniel.mohedano/testng-dtd-resolution
git_commit_date 1777278065 1777292225
git_commit_sha 53af2b0 bdd3c27
release_version 1.62.0-SNAPSHOT~53af2b0381 1.62.0-SNAPSHOT~bdd3c272f9
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1777294461 1777294461
ci_job_id 1633186216 1633186216
ci_pipeline_id 109873693 109873693
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-3rwlazia 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-3rwlazia 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 20 metrics, 15 unstable metrics.

scenario Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p95 Δ mean throughput candidate mean agg_http_req_duration_p50 candidate mean agg_http_req_duration_p95 candidate mean throughput baseline mean agg_http_req_duration_p50 baseline mean agg_http_req_duration_p95 baseline mean throughput
scenario:load:insecure-bank:iast_GLOBAL:high_load better
[-249.221µs; -140.856µs] or [-8.366%; -4.728%]		 same
[-456.798µs; +2.991µs] or [-5.582%; +0.037%]		 unstable
[-83.290op/s; +211.165op/s] or [-6.816%; +17.280%]		 2.784ms 7.957ms 1285.969op/s 2.979ms 8.184ms 1222.031op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~bdd3c272f9, baseline=1.62.0-SNAPSHOT~53af2b0381
    dateFormat X
    axisFormat %s
section baseline
no_agent (19.474 ms) : 19277, 19671
.   : milestone, 19474,
appsec (18.69 ms) : 18498, 18883
.   : milestone, 18690,
code_origins (17.964 ms) : 17787, 18142
.   : milestone, 17964,
iast (17.956 ms) : 17782, 18131
.   : milestone, 17956,
profiling (18.651 ms) : 18465, 18837
.   : milestone, 18651,
tracing (18.064 ms) : 17883, 18245
.   : milestone, 18064,
section candidate
no_agent (19.253 ms) : 19058, 19447
.   : milestone, 19253,
appsec (18.768 ms) : 18575, 18962
.   : milestone, 18768,
code_origins (17.698 ms) : 17525, 17870
.   : milestone, 17698,
iast (18.074 ms) : 17896, 18253
.   : milestone, 18074,
profiling (18.486 ms) : 18300, 18672
.   : milestone, 18486,
tracing (17.868 ms) : 17688, 18047
.   : milestone, 17868,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 19.474 ms [19.277 ms, 19.671 ms] -
appsec 18.69 ms [18.498 ms, 18.883 ms] -783.864 µs (-4.0%)
code_origins 17.964 ms [17.787 ms, 18.142 ms] -1.51 ms (-7.8%)
iast 17.956 ms [17.782 ms, 18.131 ms] -1.518 ms (-7.8%)
profiling 18.651 ms [18.465 ms, 18.837 ms] -822.927 µs (-4.2%)
tracing 18.064 ms [17.883 ms, 18.245 ms] -1.41 ms (-7.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 19.253 ms [19.058 ms, 19.447 ms] -
appsec 18.768 ms [18.575 ms, 18.962 ms] -484.638 µs (-2.5%)
code_origins 17.698 ms [17.525 ms, 17.87 ms] -1.555 ms (-8.1%)
iast 18.074 ms [17.896 ms, 18.253 ms] -1.178 ms (-6.1%)
profiling 18.486 ms [18.3 ms, 18.672 ms] -766.795 µs (-4.0%)
tracing 17.868 ms [17.688 ms, 18.047 ms] -1.385 ms (-7.2%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~bdd3c272f9, baseline=1.62.0-SNAPSHOT~53af2b0381
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.241 ms) : 1228, 1254
.   : milestone, 1241,
iast (3.385 ms) : 3335, 3434
.   : milestone, 3385,
iast_FULL (5.903 ms) : 5843, 5962
.   : milestone, 5903,
iast_GLOBAL (3.756 ms) : 3693, 3819
.   : milestone, 3756,
profiling (2.363 ms) : 2341, 2385
.   : milestone, 2363,
tracing (1.883 ms) : 1866, 1900
.   : milestone, 1883,
section candidate
no_agent (1.262 ms) : 1250, 1275
.   : milestone, 1262,
iast (3.259 ms) : 3217, 3302
.   : milestone, 3259,
iast_FULL (6.075 ms) : 6013, 6138
.   : milestone, 6075,
iast_GLOBAL (3.564 ms) : 3504, 3624
.   : milestone, 3564,
profiling (2.488 ms) : 2461, 2516
.   : milestone, 2488,
tracing (1.861 ms) : 1846, 1876
.   : milestone, 1861,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.241 ms [1.228 ms, 1.254 ms] -
iast 3.385 ms [3.335 ms, 3.434 ms] 2.144 ms (172.8%)
iast_FULL 5.903 ms [5.843 ms, 5.962 ms] 4.662 ms (375.6%)
iast_GLOBAL 3.756 ms [3.693 ms, 3.819 ms] 2.515 ms (202.6%)
profiling 2.363 ms [2.341 ms, 2.385 ms] 1.122 ms (90.4%)
tracing 1.883 ms [1.866 ms, 1.9 ms] 641.67 µs (51.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.262 ms [1.25 ms, 1.275 ms] -
iast 3.259 ms [3.217 ms, 3.302 ms] 1.997 ms (158.2%)
iast_FULL 6.075 ms [6.013 ms, 6.138 ms] 4.813 ms (381.2%)
iast_GLOBAL 3.564 ms [3.504 ms, 3.624 ms] 2.302 ms (182.3%)
profiling 2.488 ms [2.461 ms, 2.516 ms] 1.226 ms (97.1%)
tracing 1.861 ms [1.846 ms, 1.876 ms] 598.579 µs (47.4%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master daniel.mohedano/testng-dtd-resolution
git_commit_date 1777278065 1777292225
git_commit_sha 53af2b0 bdd3c27
release_version 1.62.0-SNAPSHOT~53af2b0381 1.62.0-SNAPSHOT~bdd3c272f9
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1777294275 1777294275
ci_job_id 1633186218 1633186218
ci_pipeline_id 109873693 109873693
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-7n3b9j7d 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-7n3b9j7d 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~bdd3c272f9, baseline=1.62.0-SNAPSHOT~53af2b0381
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.495 ms) : 1483, 1506
.   : milestone, 1495,
appsec (2.537 ms) : 2483, 2592
.   : milestone, 2537,
iast (2.284 ms) : 2214, 2354
.   : milestone, 2284,
iast_GLOBAL (2.326 ms) : 2256, 2396
.   : milestone, 2326,
profiling (2.528 ms) : 2363, 2693
.   : milestone, 2528,
tracing (2.084 ms) : 2031, 2138
.   : milestone, 2084,
section candidate
no_agent (1.492 ms) : 1481, 1504
.   : milestone, 1492,
appsec (3.835 ms) : 3612, 4057
.   : milestone, 3835,
iast (2.284 ms) : 2214, 2354
.   : milestone, 2284,
iast_GLOBAL (2.326 ms) : 2256, 2396
.   : milestone, 2326,
profiling (2.116 ms) : 2061, 2171
.   : milestone, 2116,
tracing (2.082 ms) : 2029, 2136
.   : milestone, 2082,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.495 ms [1.483 ms, 1.506 ms] -
appsec 2.537 ms [2.483 ms, 2.592 ms] 1.043 ms (69.7%)
iast 2.284 ms [2.214 ms, 2.354 ms] 789.673 µs (52.8%)
iast_GLOBAL 2.326 ms [2.256 ms, 2.396 ms] 831.541 µs (55.6%)
profiling 2.528 ms [2.363 ms, 2.693 ms] 1.033 ms (69.1%)
tracing 2.084 ms [2.031 ms, 2.138 ms] 589.575 µs (39.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.492 ms [1.481 ms, 1.504 ms] -
appsec 3.835 ms [3.612 ms, 4.057 ms] 2.342 ms (157.0%)
iast 2.284 ms [2.214 ms, 2.354 ms] 791.225 µs (53.0%)
iast_GLOBAL 2.326 ms [2.256 ms, 2.396 ms] 833.688 µs (55.9%)
profiling 2.116 ms [2.061 ms, 2.171 ms] 623.523 µs (41.8%)
tracing 2.082 ms [2.029 ms, 2.136 ms] 589.847 µs (39.5%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~bdd3c272f9, baseline=1.62.0-SNAPSHOT~53af2b0381
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.422 s) : 15422000, 15422000
.   : milestone, 15422000,
appsec (14.589 s) : 14589000, 14589000
.   : milestone, 14589000,
iast (18.232 s) : 18232000, 18232000
.   : milestone, 18232000,
iast_GLOBAL (17.925 s) : 17925000, 17925000
.   : milestone, 17925000,
profiling (15.051 s) : 15051000, 15051000
.   : milestone, 15051000,
tracing (14.954 s) : 14954000, 14954000
.   : milestone, 14954000,
section candidate
no_agent (15.386 s) : 15386000, 15386000
.   : milestone, 15386000,
appsec (14.999 s) : 14999000, 14999000
.   : milestone, 14999000,
iast (18.389 s) : 18389000, 18389000
.   : milestone, 18389000,
iast_GLOBAL (17.77 s) : 17770000, 17770000
.   : milestone, 17770000,
profiling (14.86 s) : 14860000, 14860000
.   : milestone, 14860000,
tracing (14.985 s) : 14985000, 14985000
.   : milestone, 14985000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.422 s [15.422 s, 15.422 s] -
appsec 14.589 s [14.589 s, 14.589 s] -833.0 ms (-5.4%)
iast 18.232 s [18.232 s, 18.232 s] 2.81 s (18.2%)
iast_GLOBAL 17.925 s [17.925 s, 17.925 s] 2.503 s (16.2%)
profiling 15.051 s [15.051 s, 15.051 s] -371.0 ms (-2.4%)
tracing 14.954 s [14.954 s, 14.954 s] -468.0 ms (-3.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.386 s [15.386 s, 15.386 s] -
appsec 14.999 s [14.999 s, 14.999 s] -387.0 ms (-2.5%)
iast 18.389 s [18.389 s, 18.389 s] 3.003 s (19.5%)
iast_GLOBAL 17.77 s [17.77 s, 17.77 s] 2.384 s (15.5%)
profiling 14.86 s [14.86 s, 14.86 s] -526.0 ms (-3.4%)
tracing 14.985 s [14.985 s, 14.985 s] -401.0 ms (-2.6%)

@daniel-mohedano daniel-mohedano marked this pull request as ready for review April 27, 2026 11:53
@daniel-mohedano daniel-mohedano requested a review from a team as a code owner April 27, 2026 11:53
AlexeyKuznetsov-DD
AlexeyKuznetsov-DD approved these changes Apr 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but worth to check if https -> http would help same way as in #11177.

Comment thread ...es/test-successful-test-cases-in-TESTS-parallel-mode-not-all-test-methods-included/suite.xml
@@ -1,4 +1,3 @@
<!DOCTYPE suite SYSTEM "https://testng.org/testng-1.0.dtd" >
Copy link
Copy Markdown
Contributor

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, recently I faced same issue with this tests failed to load DTD.
But just curious - would it works if replace https with http?
For hibernate that worked, see #11177.

Copy link
Copy Markdown
Contributor Author

@daniel-mohedano daniel-mohedano Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point! Seems like replacing them to http would indeed resolve them locally. Addressed in bdd3c27 to keep the validation but change the URL to do it locally

@daniel-mohedano daniel-mohedano changed the title Remove TestNG DTD resolution during tests Update TestNG6 DTD resolution during tests Apr 27, 2026
@daniel-mohedano
Copy link
Copy Markdown
Contributor Author

daniel-mohedano commented Apr 27, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented Apr 27, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-04-27 14:08:52 UTC ℹ️ Start processing command /merge

2026-04-27 14:08:57 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).

2026-04-27 15:18:29 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 1ce5d90 into master Apr 27, 2026
757 of 759 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the daniel.mohedano/testng-dtd-resolution branch April 27, 2026 15:18
@github-actions github-actions Bot added this to the 1.62.0 milestone Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD AlexeyKuznetsov-DD approved these changes

Assignees

No one assigned

Labels

comp: ci visibility Continuous Integration Visibility tag: no release notes Changes to exclude from release notes type: enhancement Enhancements and improvements

Projects

None yet

Milestone

1.62.0

Development

Successfully merging this pull request may close these issues.

2 participants

@daniel-mohedano @AlexeyKuznetsov-DD