Skip to content

Update TestNG6 DTD resolution during tests #11206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 2 commits into from
Apr 27, 2026
Merged

Update TestNG6 DTD resolution during tests #11206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55b8f8d
fix: remove testng DTD resolution
daniel-mohedano Apr 27, 2026
bdd3c27
fix: resolve DTD locally through http
daniel-mohedano Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...test-successful-test-cases-in-TESTS-parallel-mode-not-all-test-methods-included/suite.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE suite SYSTEM "https://testng.org/testng-1.0.dtd" >
Copy link
Copy Markdown
Contributor

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, recently I faced same issue with this tests failed to load DTD.
But just curious - would it works if replace https with http?
For hibernate that worked, see #11177.

Copy link
Copy Markdown
Contributor Author

@daniel-mohedano daniel-mohedano Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point! Seems like replacing them to http would indeed resolve them locally. Addressed in bdd3c27 to keep the validation but change the URL to do it locally

<!DOCTYPE suite SYSTEM "http://testng.org/testng-1.0.dtd" >
<suite name="API Test Suite" parallel="tests" configfailurepolicy="continue">
<test name="Test A">
<classes>
Expand Down
2 changes: 1 addition & 1 deletion ...test/resources/test-successful-test-cases-in-TESTS-parallel-mode-same-test-case/suite.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE suite SYSTEM "https://testng.org/testng-1.0.dtd" >
<!DOCTYPE suite SYSTEM "http://testng.org/testng-1.0.dtd" >
<suite name="API Test Suite" parallel="tests" configfailurepolicy="continue">
<test name="Test A">
<classes>
Expand Down
2 changes: 1 addition & 1 deletion ...testng-6.4/src/test/resources/test-successful-test-cases-in-TESTS-parallel-mode/suite.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE suite SYSTEM "https://testng.org/testng-1.0.dtd" >
<!DOCTYPE suite SYSTEM "http://testng.org/testng-1.0.dtd" >
<suite name="API Test Suite" parallel="tests" configfailurepolicy="continue">
<test name="Test A">
<classes>
Expand Down
Loading