Skip to content

Miscellaneous OpenTelemetry Metrics fixes#11240

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 6 commits intomasterfrom
mcculls/otel-metrics-fixes
May 1, 2026
Merged

Miscellaneous OpenTelemetry Metrics fixes#11240
gh-worker-dd-mergequeue-cf854d[bot] merged 6 commits intomasterfrom
mcculls/otel-metrics-fixes

Conversation

@mcculls
Copy link
Copy Markdown
Contributor

@mcculls mcculls commented Apr 30, 2026

What Does This Do

  • Ensure OpenTelemetryMetricsInstrumentation only applies to 1.38+ (this is when DoubleGauge was added)
  • Add opentelemetry-1 as an alias for OTel metrics instrumentation (to match OTel traces instrumentation)
  • Optimization: avoid repeated lookup of attributes reader when they're from the same class-loader
  • Migrate OpenTelemetry Metrics activation tests to java
  • Migrate OpenTelemetry MetricsTest to java

Contributor Checklist

Jira ticket: [PROJ-IDENT]

Note: Once your PR is ready to merge, add it to the merge queue by commenting /merge. /merge -c cancels the queue request. /merge -f --reason "reason" skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.

@mcculls mcculls added type: bug Bug report and fix tag: performance Performance related changes inst: opentelemetry OpenTelemetry instrumentation labels Apr 30, 2026
@mcculls mcculls force-pushed the mcculls/otel-metrics-fixes branch from 419fa64 to 85ede69 Compare April 30, 2026 11:33
@mcculls mcculls force-pushed the mcculls/otel-metrics-fixes branch from 85ede69 to c5f8adb Compare April 30, 2026 13:05
@mcculls mcculls force-pushed the mcculls/otel-metrics-fixes branch from c5f8adb to 1391996 Compare April 30, 2026 13:24
@mcculls mcculls marked this pull request as ready for review April 30, 2026 15:11
@mcculls mcculls requested review from a team as code owners April 30, 2026 15:11
@mcculls mcculls requested review from mtoffl01 and sarahchen6 and removed request for a team April 30, 2026 15:11
Copy link
Copy Markdown
Contributor

@sarahchen6 sarahchen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the test migration too!

@mcculls mcculls added this pull request to the merge queue May 1, 2026
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 1, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented May 1, 2026

View all feedbacks in Devflow UI.

2026-05-01 08:49:22 UTC ℹ️ Start processing command /merge


2026-05-01 08:49:27 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-05-01 09:58:53 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 1, 2026
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit d8fe2e9 into master May 1, 2026
754 of 756 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the mcculls/otel-metrics-fixes branch May 1, 2026 09:58
@github-actions github-actions Bot added this to the 1.62.0 milestone May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inst: opentelemetry OpenTelemetry instrumentation tag: performance Performance related changes type: bug Bug report and fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants