Skip to content

Improve test strategy on claude.md#11270

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
masterfrom
andrea.marziali/claude-groovy
May 5, 2026
Merged

Improve test strategy on claude.md#11270
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
masterfrom
andrea.marziali/claude-groovy

Conversation

@amarziali

Copy link
Copy Markdown
Contributor

What Does This Do

Instructs agents to always add new test as java (junit) and to migrate to junit old spock one when adding new test cases

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

Note: Once your PR is ready to merge, add it to the merge queue by commenting /merge. /merge -c cancels the queue request. /merge -f --reason "reason" skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.

@amarziali amarziali requested a review from a team as a code owner May 4, 2026 14:14
@amarziali amarziali added the type: enhancement Enhancements and improvements label May 4, 2026
@amarziali amarziali requested a review from ygree May 4, 2026 14:14
@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@amarziali amarziali added comp: tooling Build & Tooling type: documentation and removed type: documentation type: enhancement Enhancements and improvements labels May 4, 2026
@sarahchen6 sarahchen6 added the type: enhancement Enhancements and improvements label May 4, 2026

@sarahchen6 sarahchen6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarahchen6 sarahchen6 removed the type: enhancement Enhancements and improvements label May 4, 2026

@PerfectSlayer PerfectSlayer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added comments / suggestions to make sure the skill is not references in AGENTS.md

Comment thread .claude/CLAUDE.md Outdated
Comment thread AGENTS.md Outdated

@bric3 bric3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with @PerfectSlayer suggestions

amarziali and others added 3 commits May 5, 2026 08:36
Co-authored-by: Bruce Bujon <PerfectSlayer@users.noreply.github.com>
Co-authored-by: Bruce Bujon <PerfectSlayer@users.noreply.github.com>
@amarziali amarziali enabled auto-merge May 5, 2026 06:39
@amarziali amarziali added this pull request to the merge queue May 5, 2026
@dd-octo-sts

dd-octo-sts Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented May 5, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-05-05 07:36:16 UTC ℹ️ Start processing command /merge


2026-05-05 07:36:21 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-05-05 08:51:29 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 5, 2026
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit d085341 into master May 5, 2026
570 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the andrea.marziali/claude-groovy branch May 5, 2026 08:51
@github-actions github-actions Bot added this to the 1.63.0 milestone May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants