Skip to content

Unbound virtual thread tests#11729

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
andrea.marziali/java-conc-test
Jun 24, 2026
Merged

Unbound virtual thread tests#11729
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
andrea.marziali/java-conc-test

Conversation

@amarziali

Copy link
Copy Markdown
Contributor

What Does This Do

Unbounds jvm version testing for virtual thread instrumentation and narrow the bound to the preview test suite which only concerns structured concurrency (that had the issue)

Motivation

Additional Notes

Contributor Checklist

  • Format the title according to the contribution guidelines
  • Assign the type: and (comp: or inst:) labels in addition to any other useful labels
  • Avoid using close, fix, or any linking keywords when referencing an issue
    Use solves instead, and assign the PR milestone to the issue
  • Update the CODEOWNERS file on source file addition, migration, or deletion
  • Update public documentation with any new configuration flags or behaviors
  • Add your completed PR to the merge queue by commenting /merge. You can also:
    • Customize the commit message associated with the merge with /merge --commit-message "..."
    • Remove your PR from the merge queue with /merge -c
    • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)
    • Get more information in this doc

Jira ticket: [PROJ-IDENT]

@amarziali
amarziali requested a review from PerfectSlayer June 24, 2026 14:33
@amarziali
amarziali requested a review from a team as a code owner June 24, 2026 14:33
@amarziali amarziali added comp: testing Testing inst: others All other instrumentations tag: no release notes Changes to exclude from release notes tag: concurrency Virtual Threads, Coroutines, Async, RX, Executors labels Jun 24, 2026

@PerfectSlayer PerfectSlayer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 praise: ‏Good catch! Thanks for the fix

@amarziali
amarziali enabled auto-merge June 24, 2026 14:34
@PerfectSlayer PerfectSlayer added inst: java Core Java language instrumentation type: bug fix Bug fix and removed inst: others All other instrumentations comp: testing Testing labels Jun 24, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.71 s 14.60 s [-0.0%; +1.5%] (no difference)
startup:insecure-bank:tracing:Agent 13.61 s 13.68 s [-1.5%; +0.5%] (no difference)
startup:petclinic:appsec:Agent 16.93 s 16.80 s [-0.1%; +1.7%] (no difference)
startup:petclinic:iast:Agent 16.91 s 17.00 s [-1.5%; +0.4%] (no difference)
startup:petclinic:profiling:Agent 16.91 s 16.90 s [-0.9%; +1.1%] (no difference)
startup:petclinic:sca:Agent 16.29 s 16.77 s [-7.0%; +1.2%] (no difference)
startup:petclinic:tracing:Agent 15.75 s 16.07 s [-6.2%; +2.2%] (no difference)

Commit: 927fae96 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@amarziali
amarziali added this pull request to the merge queue Jun 24, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jun 24, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-06-24 15:28:27 UTC ℹ️ Start processing command /merge


2026-06-24 15:28:32 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-06-24 16:41:25 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 24, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 7e083fd into master Jun 24, 2026
786 of 795 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the andrea.marziali/java-conc-test branch June 24, 2026 16:41
@github-actions github-actions Bot added this to the 1.64.0 milestone Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inst: java Core Java language instrumentation tag: concurrency Virtual Threads, Coroutines, Async, RX, Executors tag: no release notes Changes to exclude from release notes type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants