Skip to content

Unify usage of OperatingSystem.architecture()#11816

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
alexeyk/cleanup-arm64-detection
Jul 1, 2026
Merged

Unify usage of OperatingSystem.architecture()#11816
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
alexeyk/cleanup-arm64-detection

Conversation

@AlexeyKuznetsov-DD

Copy link
Copy Markdown
Contributor

What Does This Do

Unifies all call sites to use OperatingSystem.architecture() instead of the statically-imported architecture(), removing the import static datadog.environment.OperatingSystem.architecture imports across the codebase.

Motivation

Addresses PR #11364 review feedback to keep usage of the OperatingSystem utility consistent. Qualifying calls with OperatingSystem.architecture() makes it explicit where the architecture check comes from and avoids ambiguity at the call site.

Additional Notes

  • Pure refactor — no behavioral change.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD requested a review from bric3 June 30, 2026 20:52
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD self-assigned this Jun 30, 2026
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD added tag: no release notes Changes to exclude from release notes type: refactoring comp: tooling Build & Tooling labels Jun 30, 2026
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD marked this pull request as ready for review June 30, 2026 20:53
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD requested review from a team as code owners June 30, 2026 20:53
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD requested review from evanchooly, jordan-wong and mhlidd and removed request for a team June 30, 2026 20:53
@dd-octo-sts dd-octo-sts Bot added the tag: ai generated Largely based on code generated by an AI or LLM label Jun 30, 2026
@datadog-prod-us1-3

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.01 s 13.97 s [-0.4%; +1.1%] (no difference)
startup:insecure-bank:tracing:Agent 12.94 s 13.05 s [-1.8%; +0.1%] (no difference)
startup:petclinic:appsec:Agent 16.80 s 15.96 s [+1.0%; +9.6%] (maybe worse)
startup:petclinic:iast:Agent 16.69 s 16.80 s [-1.4%; +0.1%] (no difference)
startup:petclinic:profiling:Agent 16.79 s 16.63 s [-0.1%; +2.1%] (no difference)
startup:petclinic:sca:Agent 16.81 s 16.58 s [+0.4%; +2.3%] (maybe worse)
startup:petclinic:tracing:Agent 15.59 s 16.04 s [-6.9%; +1.3%] (no difference)

Commit: 3f9a4f46 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@AlexeyKuznetsov-DD

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 1, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-01 12:45:48 UTC ℹ️ Start processing command /merge


2026-07-01 12:45:53 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-07-01 13:49:51 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 466cc7c into master Jul 1, 2026
783 of 791 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the alexeyk/cleanup-arm64-detection branch July 1, 2026 13:49
@github-actions github-actions Bot added this to the 1.64.0 milestone Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants