Allow Gradle verification of Test Optimization dependencies - #12077
Conversation
daniel-mohedano
added
type: feature
daniel-mohedano
changed the title
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2b016f9b29
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
🎯 Code Coverage (details) 🔗 Commit SHA: 2f7754b | Docs | Datadog PR Page | Give us feedback! |
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
|
Bits Code status: ✅ Done Comment @DataDog to request changes |
![datadog-datadog-us1-prod[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
There was a problem hiding this comment.
More details
The dependency-verification gate and warning behavior matched the intended default/opt-in contract, and an isolated Gradle probe confirmed the JaCoCo plugin creates only jacocoAgent and jacocoAnt configurations. The repository smoke test could not run because this environment lacks JDK 25 and cannot download the Gradle wrapper distribution.
📊 Validated against 1 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit 2f7754b · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
3 participants
What Does This Do
Adds an opt-in configuration for applying Gradle dependency verification to dependencies injected by Test Optimization:
DD_CIVISIBILITY_GRADLE_DEPENDENCY_VERIFICATION_ENABLED=true.Dependency verification remains disabled by default for the injected compiler plugin and JaCoCo dependencies. This avoids requiring customers to update their verification metadata when enabling the Java agent.
When dependency verification is disabled and
gradle/verification-metadata.xmlexists, the tracer logs a warning explaining the behavior and how to opt in.Motivation
Customers using Gradle dependency verification should not need to update their projects simply because Test Optimization injects dependencies.
Customers who want verification to cover these dependencies can explicitly enable it and add them to
gradle/verification-metadata.xml.Additional Notes
test-environment-trigger: skip
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: APMSP-3236