chore(deps): bump dd-smoke-tests/openfeature/src/test/resources/ffe-system-test-data from b42c4a1 to f3da9ae - #12093
Conversation
…ystem-test-data Bumps [dd-smoke-tests/openfeature/src/test/resources/ffe-system-test-data](https://github.com/DataDog/ffe-system-test-data) from `b42c4a1` to `f3da9ae`. - [Commits](DataDog/ffe-system-test-data@b42c4a1...f3da9ae) --- updated-dependencies: - dependency-name: dd-smoke-tests/openfeature/src/test/resources/ffe-system-test-data dependency-version: f3da9ae56b4dd765a46de64482c6904e2c67ffb2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
comp: openfeature
![datadog-prod-us1-5[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please try again by commenting @autotest review.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b231c686b5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -1 +1 @@ | |||
| Subproject commit b42c4a104ea70695c8fc3516780951f7434b7906 | |||
| Subproject commit f3da9ae56b4dd765a46de64482c6904e2c67ffb2 | |||
There was a problem hiding this comment.
This submodule pointer pulls in ffe-system-test-data@f3da9ae, whose ufc-config.json now contains malformed fixtures such as malformed-allocations-flag with allocations encoded as a string. When the submodule is initialized, DDEvaluatorTest loads that bumped ufc-config.json via the plain MOSHI.adapter(ServerConfiguration.class) at products/feature-flagging/feature-flagging-api/src/test/java/datadog/trace/api/openfeature/DDEvaluatorTest.java:59-61,273-274, so Moshi fails deserializing the config before the canonical fixture tests can run; update the Java test loader/evaluator support or hold this bump until the new tolerant fixtures are supported.
Useful? React with 👍 / 👎.
| @@ -1 +1 @@ | |||
| Subproject commit b42c4a104ea70695c8fc3516780951f7434b7906 | |||
| Subproject commit f3da9ae56b4dd765a46de64482c6904e2c67ffb2 | |||
There was a problem hiding this comment.
The bumped fixture adds test-case-regex-flag cases that expect the pattern ^([[:alnum:]._%+-]+)@capture\.example$ to match user.name+tag@capture.example, but DDEvaluator.matchesRegex evaluates UFC regexes with Java Pattern.compile(...) (products/feature-flagging/feature-flagging-api/src/main/java/datadog/trace/api/openfeature/DDEvaluator.java:282-286), where that POSIX bracket syntax does not match this email. Once the config-load issue is fixed, both the canonical evaluator test and the OpenFeature smoke test will return the default none instead of the expected capturing-groups, so this fixture bump needs either Java-compatible regex data or evaluator support for the fixture syntax.
Useful? React with 👍 / 👎.
| @@ -1 +1 @@ | |||
| Subproject commit b42c4a104ea70695c8fc3516780951f7434b7906 | |||
| Subproject commit f3da9ae56b4dd765a46de64482c6904e2c67ffb2 | |||
There was a problem hiding this comment.
The new fixture revision changes the expected reason for the active microsecond-date-test and start-and-end-date-test cases from STATIC to DEFAULT while keeping the returned values active/current. As of July 28, 2026 those allocations are inside their configured start/end windows, and DDEvaluator.resolveVariant still reports unsharded matched allocations as STATIC (products/feature-flagging/feature-flagging-api/src/main/java/datadog/trace/api/openfeature/DDEvaluator.java:416-424), so the existing reason assertions in both fixture-driven tests will fail until either the fixture expectations stay on STATIC or the evaluator is deliberately changed to emit the new reason.
Useful? React with 👍 / 👎.
| @@ -1 +1 @@ | |||
| Subproject commit b42c4a104ea70695c8fc3516780951f7434b7906 | |||
| Subproject commit f3da9ae56b4dd765a46de64482c6904e2c67ffb2 | |||
There was a problem hiding this comment.
The bumped data adds missing-split-shards-flag and expects the caller default because the split omits the required shards field, but Java deserializes that split with split.shards == null and DDEvaluator treats null the same as an explicit empty shard list at products/feature-flagging/feature-flagging-api/src/main/java/datadog/trace/api/openfeature/DDEvaluator.java:141-145. In the OpenFeature smoke path this parse-valid malformed flag is not skipped, so evaluating the new case resolves the trap variation with reason STATIC instead of the fixture's DEFAULT; add schema validation/skip handling for omitted shards or don't pull this fixture yet.
Useful? React with 👍 / 👎.
🟡 Java Benchmark SLOs — Performance SLO warning (near threshold)
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Bumps dd-smoke-tests/openfeature/src/test/resources/ffe-system-test-data from
b42c4a1tof3da9ae.Commits
f3da9aeMerge pull request #18 from DataDog/leo.romanovsky/revert-regex-shard-bound-f...44092cefix: limit rollback to regex fixtures9864c01fix: restore static temporal allocation reasonscb09e08revert: remove regex and shard-bound fixturesa596df7Merge pull request #17 from DataDog/leo.romanovsky/regex-shard-bound-fixturesce45493Add regex and shard-bound fixtures6c7f63bMerge pull request #16 from DataDog/leo.romanovsky/malformed-split-shards-fix...cf7d7d5Add missing split shards fixtured9d8020Merge pull request #15 from DataDog/leo.romanovsky/date-window-assignment-rea...e4803e3Fix temporal allocation reasonsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)