Support attaching tags to telemetry logs#8921
Merged
Conversation
sezen-datadog
approved these changes
Jun 4, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 42 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~72b5d3b494, baseline=1.51.0-SNAPSHOT~aa9dd27535
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.033 s) : 0, 1032948
Total [baseline] (10.578 s) : 0, 10577522
Agent [candidate] (1.024 s) : 0, 1024058
Total [candidate] (10.596 s) : 0, 10595811
section appsec
Agent [baseline] (1.185 s) : 0, 1185468
Total [baseline] (10.762 s) : 0, 10762013
Agent [candidate] (1.187 s) : 0, 1187003
Total [candidate] (10.651 s) : 0, 10651186
section iast
Agent [baseline] (1.16 s) : 0, 1160029
Total [baseline] (10.839 s) : 0, 10839439
Agent [candidate] (1.151 s) : 0, 1150847
Total [candidate] (10.86 s) : 0, 10860468
section profiling
Agent [baseline] (1.272 s) : 0, 1272038
Total [baseline] (11.028 s) : 0, 11027839
Agent [candidate] (1.266 s) : 0, 1265662
Total [candidate] (10.909 s) : 0, 10908968
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~72b5d3b494, baseline=1.51.0-SNAPSHOT~aa9dd27535
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (691.287 ms) : 0, 691287
BytebuddyAgent [candidate] (685.475 ms) : 0, 685475
GlobalTracer [baseline] (243.806 ms) : 0, 243806
GlobalTracer [candidate] (241.975 ms) : 0, 241975
AppSec [baseline] (56.94 ms) : 0, 56940
AppSec [candidate] (59.385 ms) : 0, 59385
Debugger [baseline] (7.817 ms) : 0, 7817
Debugger [candidate] (6.146 ms) : 0, 6146
Remote Config [baseline] (678.992 µs) : 0, 679
Remote Config [candidate] (650.069 µs) : 0, 650
Telemetry [baseline] (11.476 ms) : 0, 11476
Telemetry [candidate] (9.618 ms) : 0, 9618
section appsec
BytebuddyAgent [baseline] (713.584 ms) : 0, 713584
BytebuddyAgent [candidate] (713.708 ms) : 0, 713708
GlobalTracer [baseline] (236.281 ms) : 0, 236281
GlobalTracer [candidate] (236.713 ms) : 0, 236713
IAST [baseline] (21.994 ms) : 0, 21994
IAST [candidate] (22.053 ms) : 0, 22053
AppSec [baseline] (179.159 ms) : 0, 179159
AppSec [candidate] (179.834 ms) : 0, 179834
Debugger [baseline] (5.79 ms) : 0, 5790
Debugger [candidate] (5.83 ms) : 0, 5830
Remote Config [baseline] (615.503 µs) : 0, 616
Remote Config [candidate] (617.957 µs) : 0, 618
Telemetry [baseline] (7.271 ms) : 0, 7271
Telemetry [candidate] (7.314 ms) : 0, 7314
section iast
BytebuddyAgent [baseline] (812.129 ms) : 0, 812129
BytebuddyAgent [candidate] (805.029 ms) : 0, 805029
GlobalTracer [baseline] (232.782 ms) : 0, 232782
GlobalTracer [candidate] (231.708 ms) : 0, 231708
IAST [baseline] (26.9 ms) : 0, 26900
IAST [candidate] (26.59 ms) : 0, 26590
AppSec [baseline] (52.569 ms) : 0, 52569
AppSec [candidate] (52.291 ms) : 0, 52291
Debugger [baseline] (6.029 ms) : 0, 6029
Debugger [candidate] (5.892 ms) : 0, 5892
Remote Config [baseline] (618.089 µs) : 0, 618
Remote Config [candidate] (586.721 µs) : 0, 587
Telemetry [baseline] (8.012 ms) : 0, 8012
Telemetry [candidate] (7.923 ms) : 0, 7923
section profiling
BytebuddyAgent [baseline] (677.972 ms) : 0, 677972
BytebuddyAgent [candidate] (673.813 ms) : 0, 673813
GlobalTracer [baseline] (361.078 ms) : 0, 361078
GlobalTracer [candidate] (358.667 ms) : 0, 358667
AppSec [baseline] (62.369 ms) : 0, 62369
AppSec [candidate] (62.051 ms) : 0, 62051
Debugger [baseline] (6.169 ms) : 0, 6169
Debugger [candidate] (6.093 ms) : 0, 6093
Remote Config [baseline] (700.091 µs) : 0, 700
Remote Config [candidate] (688.507 µs) : 0, 689
Telemetry [baseline] (8.233 ms) : 0, 8233
Telemetry [candidate] (8.074 ms) : 0, 8074
ProfilingAgent [baseline] (107.005 ms) : 0, 107005
ProfilingAgent [candidate] (107.804 ms) : 0, 107804
Profiling [baseline] (107.03 ms) : 0, 107030
Profiling [candidate] (107.829 ms) : 0, 107829
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~72b5d3b494, baseline=1.51.0-SNAPSHOT~aa9dd27535
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.024 s) : 0, 1024129
Total [baseline] (8.551 s) : 0, 8550892
Agent [candidate] (1.026 s) : 0, 1025644
Total [candidate] (8.557 s) : 0, 8557310
section iast
Agent [baseline] (1.15 s) : 0, 1149500
Total [baseline] (9.205 s) : 0, 9204913
Agent [candidate] (1.15 s) : 0, 1149817
Total [candidate] (9.214 s) : 0, 9214162
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~72b5d3b494, baseline=1.51.0-SNAPSHOT~aa9dd27535
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.991 ms) : 0, 684991
BytebuddyAgent [candidate] (686.034 ms) : 0, 686034
GlobalTracer [baseline] (241.617 ms) : 0, 241617
GlobalTracer [candidate] (242.365 ms) : 0, 242365
AppSec [baseline] (57.121 ms) : 0, 57121
AppSec [candidate] (58.465 ms) : 0, 58465
Debugger [baseline] (6.211 ms) : 0, 6211
Debugger [candidate] (6.954 ms) : 0, 6954
Remote Config [baseline] (673.845 µs) : 0, 674
Remote Config [candidate] (664.462 µs) : 0, 664
Telemetry [baseline] (12.774 ms) : 0, 12774
Telemetry [candidate] (10.359 ms) : 0, 10359
section iast
BytebuddyAgent [baseline] (803.918 ms) : 0, 803918
BytebuddyAgent [candidate] (804.591 ms) : 0, 804591
GlobalTracer [baseline] (231.333 ms) : 0, 231333
GlobalTracer [candidate] (231.151 ms) : 0, 231151
IAST [baseline] (25.904 ms) : 0, 25904
IAST [candidate] (27.566 ms) : 0, 27566
AppSec [baseline] (53.081 ms) : 0, 53081
AppSec [candidate] (51.37 ms) : 0, 51370
Debugger [baseline] (5.917 ms) : 0, 5917
Debugger [candidate] (5.906 ms) : 0, 5906
Remote Config [baseline] (594.341 µs) : 0, 594
Remote Config [candidate] (609.218 µs) : 0, 609
Telemetry [baseline] (7.931 ms) : 0, 7931
Telemetry [candidate] (7.893 ms) : 0, 7893
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 1 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~72b5d3b494, baseline=1.51.0-SNAPSHOT~aa9dd27535
dateFormat X
axisFormat %s
section baseline
no_agent (37.253 ms) : 36947, 37559
. : milestone, 37253,
appsec (49.6 ms) : 49148, 50051
. : milestone, 49600,
code_origins (46.979 ms) : 46604, 47354
. : milestone, 46979,
iast (45.385 ms) : 44981, 45789
. : milestone, 45385,
profiling (49.017 ms) : 48502, 49532
. : milestone, 49017,
tracing (44.513 ms) : 44152, 44875
. : milestone, 44513,
section candidate
no_agent (38.037 ms) : 37730, 38343
. : milestone, 38037,
appsec (46.158 ms) : 45735, 46581
. : milestone, 46158,
code_origins (44.641 ms) : 44281, 45002
. : milestone, 44641,
iast (43.727 ms) : 43353, 44102
. : milestone, 43727,
profiling (49.963 ms) : 49450, 50477
. : milestone, 49963,
tracing (44.073 ms) : 43707, 44439
. : milestone, 44073,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~72b5d3b494, baseline=1.51.0-SNAPSHOT~aa9dd27535
dateFormat X
axisFormat %s
section baseline
no_agent (4.257 ms) : 4210, 4304
. : milestone, 4257,
iast (9.346 ms) : 9182, 9509
. : milestone, 9346,
iast_FULL (14.162 ms) : 13878, 14446
. : milestone, 14162,
iast_GLOBAL (10.023 ms) : 9851, 10194
. : milestone, 10023,
profiling (8.827 ms) : 8690, 8965
. : milestone, 8827,
tracing (7.801 ms) : 7691, 7912
. : milestone, 7801,
section candidate
no_agent (4.41 ms) : 4359, 4460
. : milestone, 4410,
iast (9.182 ms) : 9030, 9334
. : milestone, 9182,
iast_FULL (13.656 ms) : 13383, 13928
. : milestone, 13656,
iast_GLOBAL (10.11 ms) : 9926, 10294
. : milestone, 10110,
profiling (8.935 ms) : 8783, 9086
. : milestone, 8935,
tracing (7.619 ms) : 7507, 7731
. : milestone, 7619,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~72b5d3b494, baseline=1.51.0-SNAPSHOT~aa9dd27535
dateFormat X
axisFormat %s
section baseline
no_agent (15.514 s) : 15514000, 15514000
. : milestone, 15514000,
appsec (14.779 s) : 14779000, 14779000
. : milestone, 14779000,
iast (18.565 s) : 18565000, 18565000
. : milestone, 18565000,
iast_GLOBAL (18.319 s) : 18319000, 18319000
. : milestone, 18319000,
profiling (15.252 s) : 15252000, 15252000
. : milestone, 15252000,
tracing (14.779 s) : 14779000, 14779000
. : milestone, 14779000,
section candidate
no_agent (15.396 s) : 15396000, 15396000
. : milestone, 15396000,
appsec (14.854 s) : 14854000, 14854000
. : milestone, 14854000,
iast (18.306 s) : 18306000, 18306000
. : milestone, 18306000,
iast_GLOBAL (18.055 s) : 18055000, 18055000
. : milestone, 18055000,
profiling (15.079 s) : 15079000, 15079000
. : milestone, 15079000,
tracing (14.969 s) : 14969000, 14969000
. : milestone, 14969000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~72b5d3b494, baseline=1.51.0-SNAPSHOT~aa9dd27535
dateFormat X
axisFormat %s
section baseline
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (2.397 ms) : 2349, 2445
. : milestone, 2397,
iast (2.19 ms) : 2129, 2251
. : milestone, 2190,
iast_GLOBAL (2.224 ms) : 2163, 2285
. : milestone, 2224,
profiling (2.049 ms) : 1999, 2100
. : milestone, 2049,
tracing (2.015 ms) : 1967, 2062
. : milestone, 2015,
section candidate
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (2.404 ms) : 2355, 2452
. : milestone, 2404,
iast (2.183 ms) : 2122, 2244
. : milestone, 2183,
iast_GLOBAL (2.226 ms) : 2165, 2287
. : milestone, 2226,
profiling (2.054 ms) : 2003, 2105
. : milestone, 2054,
tracing (2.021 ms) : 1974, 2069
. : milestone, 2021,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Add support for
LogCollectorto create telemetry logs with tags. Tags are defined as a string, a comma-separated list, e.g.tag1:value1,tag2:value2.Motivation
We have new use cases in AppSec to send telemetry logs with more structured data in tags. This functionality was already in our telemetry system, but not exposed in
internal-api.This is still not exposed via regular SLF4J logging integration. For the time being, if one needs this, they'll have to use the telemetry-specific interface in this PR.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]