Conversation
smola
left a comment
There was a problem hiding this comment.
+1 to this. Big advantage of the test-retry plugin as opposed to JUnit/Spock-level retry mechanisms is that intermediate test runs are not lost. So we can keep observability of intermediate failures in Test Optimization (I checked this in Circle CI back in the day, I haven't verified with Test Optimization though).
I think eventually we'd need a more nuanced approach here the way I outlined at #8113, and also stop skipping @Flaky tests and rely on this mechanism. But there's more work involved there. I think it is a good idea to start with this PR if it works well.
PerfectSlayer
left a comment
There was a problem hiding this comment.
So we can keep observability of intermediate failures in Test Optimization
It was my main concern about the feature. I'm glad @bric3 came with a new pair of eyes and gave it another try with the new CI 👍
What Does This Do
Retry tests in CI, I wonder however if these should be tracked ? Maybe Test Optim has that?
Note:
When a test fails it is captured by Test Optimization.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]