Fix OpenLineage instrumentation for Spark#9341
Closed
pawel-big-lebowski wants to merge 1 commit intomasterfrom
Closed
Fix OpenLineage instrumentation for Spark#9341pawel-big-lebowski wants to merge 1 commit intomasterfrom
pawel-big-lebowski wants to merge 1 commit intomasterfrom
Conversation
Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~b07d7eec01, baseline=1.53.0-SNAPSHOT~5dfc6f71bd
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1042761
Total [baseline] (10.66 s) : 0, 10660341
Agent [candidate] (1.048 s) : 0, 1048136
Total [candidate] (10.736 s) : 0, 10735962
section appsec
Agent [baseline] (1.225 s) : 0, 1224893
Total [baseline] (10.756 s) : 0, 10756413
Agent [candidate] (1.225 s) : 0, 1225445
Total [candidate] (10.829 s) : 0, 10828742
section iast
Agent [baseline] (1.178 s) : 0, 1178416
Total [baseline] (10.883 s) : 0, 10883174
Agent [candidate] (1.178 s) : 0, 1177755
Total [candidate] (10.9 s) : 0, 10900268
section profiling
Agent [baseline] (1.2 s) : 0, 1200180
Total [baseline] (10.863 s) : 0, 10862685
Agent [candidate] (1.202 s) : 0, 1201529
Total [candidate] (10.888 s) : 0, 10887743
gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~b07d7eec01, baseline=1.53.0-SNAPSHOT~5dfc6f71bd
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.426 ms) : 0, 1426
crashtracking [candidate] (1.428 ms) : 0, 1428
BytebuddyAgent [baseline] (730.709 ms) : 0, 730709
BytebuddyAgent [candidate] (733.154 ms) : 0, 733154
GlobalTracer [baseline] (242.133 ms) : 0, 242133
GlobalTracer [candidate] (243.411 ms) : 0, 243411
AppSec [baseline] (30.081 ms) : 0, 30081
AppSec [candidate] (30.219 ms) : 0, 30219
Debugger [baseline] (6.08 ms) : 0, 6080
Debugger [candidate] (6.078 ms) : 0, 6078
Remote Config [baseline] (650.437 µs) : 0, 650
Remote Config [candidate] (657.383 µs) : 0, 657
Telemetry [baseline] (10.625 ms) : 0, 10625
Telemetry [candidate] (12.148 ms) : 0, 12148
section appsec
crashtracking [baseline] (1.434 ms) : 0, 1434
crashtracking [candidate] (1.443 ms) : 0, 1443
BytebuddyAgent [baseline] (756.242 ms) : 0, 756242
BytebuddyAgent [candidate] (756.426 ms) : 0, 756426
GlobalTracer [baseline] (236.26 ms) : 0, 236260
GlobalTracer [candidate] (235.891 ms) : 0, 235891
IAST [baseline] (23.826 ms) : 0, 23826
IAST [candidate] (23.655 ms) : 0, 23655
AppSec [baseline] (169.873 ms) : 0, 169873
AppSec [candidate] (168.936 ms) : 0, 168936
Debugger [baseline] (7.103 ms) : 0, 7103
Debugger [candidate] (8.108 ms) : 0, 8108
Remote Config [baseline] (635.318 µs) : 0, 635
Remote Config [candidate] (617.514 µs) : 0, 618
Telemetry [baseline] (8.386 ms) : 0, 8386
Telemetry [candidate] (9.229 ms) : 0, 9229
section iast
crashtracking [baseline] (1.449 ms) : 0, 1449
crashtracking [candidate] (1.447 ms) : 0, 1447
BytebuddyAgent [baseline] (850.352 ms) : 0, 850352
BytebuddyAgent [candidate] (850.186 ms) : 0, 850186
GlobalTracer [baseline] (233.365 ms) : 0, 233365
GlobalTracer [candidate] (233.079 ms) : 0, 233079
IAST [baseline] (28.521 ms) : 0, 28521
IAST [candidate] (29.877 ms) : 0, 29877
AppSec [baseline] (27.324 ms) : 0, 27324
AppSec [candidate] (24.294 ms) : 0, 24294
Debugger [baseline] (7.461 ms) : 0, 7461
Debugger [candidate] (9.102 ms) : 0, 9102
Remote Config [baseline] (585.169 µs) : 0, 585
Remote Config [candidate] (578.245 µs) : 0, 578
Telemetry [baseline] (8.352 ms) : 0, 8352
Telemetry [candidate] (8.18 ms) : 0, 8180
section profiling
crashtracking [baseline] (1.415 ms) : 0, 1415
crashtracking [candidate] (1.42 ms) : 0, 1420
BytebuddyAgent [baseline] (764.373 ms) : 0, 764373
BytebuddyAgent [candidate] (766.08 ms) : 0, 766080
GlobalTracer [baseline] (222.546 ms) : 0, 222546
GlobalTracer [candidate] (222.719 ms) : 0, 222719
AppSec [baseline] (30.114 ms) : 0, 30114
AppSec [candidate] (30.382 ms) : 0, 30382
Debugger [baseline] (6.324 ms) : 0, 6324
Debugger [candidate] (6.325 ms) : 0, 6325
Remote Config [baseline] (687.19 µs) : 0, 687
Remote Config [candidate] (680.975 µs) : 0, 681
Telemetry [baseline] (16.074 ms) : 0, 16074
Telemetry [candidate] (15.921 ms) : 0, 15921
ProfilingAgent [baseline] (108.733 ms) : 0, 108733
ProfilingAgent [candidate] (108.106 ms) : 0, 108106
Profiling [baseline] (109.365 ms) : 0, 109365
Profiling [candidate] (108.737 ms) : 0, 108737
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~b07d7eec01, baseline=1.53.0-SNAPSHOT~5dfc6f71bd
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1051989
Total [baseline] (8.609 s) : 0, 8608775
Agent [candidate] (1.043 s) : 0, 1043493
Total [candidate] (8.575 s) : 0, 8575131
section iast
Agent [baseline] (1.175 s) : 0, 1175139
Total [baseline] (9.317 s) : 0, 9317484
Agent [candidate] (1.182 s) : 0, 1182423
Total [candidate] (9.315 s) : 0, 9315269
gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~b07d7eec01, baseline=1.53.0-SNAPSHOT~5dfc6f71bd
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.432 ms) : 0, 1432
crashtracking [candidate] (1.427 ms) : 0, 1427
BytebuddyAgent [baseline] (734.363 ms) : 0, 734363
BytebuddyAgent [candidate] (730.22 ms) : 0, 730220
GlobalTracer [baseline] (245.214 ms) : 0, 245214
GlobalTracer [candidate] (242.118 ms) : 0, 242118
AppSec [baseline] (30.745 ms) : 0, 30745
AppSec [candidate] (30.028 ms) : 0, 30028
Debugger [baseline] (6.134 ms) : 0, 6134
Debugger [candidate] (6.042 ms) : 0, 6042
Remote Config [baseline] (662.35 µs) : 0, 662
Remote Config [candidate] (643.299 µs) : 0, 643
Telemetry [baseline] (12.314 ms) : 0, 12314
Telemetry [candidate] (12.062 ms) : 0, 12062
section iast
crashtracking [baseline] (1.426 ms) : 0, 1426
crashtracking [candidate] (1.447 ms) : 0, 1447
BytebuddyAgent [baseline] (847.869 ms) : 0, 847869
BytebuddyAgent [candidate] (855.095 ms) : 0, 855095
GlobalTracer [baseline] (232.452 ms) : 0, 232452
GlobalTracer [candidate] (233.635 ms) : 0, 233635
IAST [baseline] (28.586 ms) : 0, 28586
IAST [candidate] (28.388 ms) : 0, 28388
AppSec [baseline] (27.422 ms) : 0, 27422
AppSec [candidate] (27.35 ms) : 0, 27350
Debugger [baseline] (7.544 ms) : 0, 7544
Debugger [candidate] (6.577 ms) : 0, 6577
Remote Config [baseline] (577.015 µs) : 0, 577
Remote Config [candidate] (586.377 µs) : 0, 586
Telemetry [baseline] (8.263 ms) : 0, 8263
Telemetry [candidate] (8.208 ms) : 0, 8208
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 2 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~b07d7eec01, baseline=1.53.0-SNAPSHOT~5dfc6f71bd
dateFormat X
axisFormat %s
section baseline
no_agent (4.412 ms) : 4363, 4462
. : milestone, 4412,
iast (9.155 ms) : 9000, 9310
. : milestone, 9155,
iast_FULL (13.621 ms) : 13352, 13890
. : milestone, 13621,
iast_GLOBAL (10.691 ms) : 10503, 10879
. : milestone, 10691,
profiling (8.957 ms) : 8809, 9105
. : milestone, 8957,
tracing (7.733 ms) : 7616, 7849
. : milestone, 7733,
section candidate
no_agent (4.484 ms) : 4428, 4540
. : milestone, 4484,
iast (9.488 ms) : 9331, 9645
. : milestone, 9488,
iast_FULL (13.757 ms) : 13486, 14029
. : milestone, 13757,
iast_GLOBAL (10.275 ms) : 10097, 10454
. : milestone, 10275,
profiling (9.31 ms) : 9172, 9449
. : milestone, 9310,
tracing (7.847 ms) : 7731, 7964
. : milestone, 7847,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~b07d7eec01, baseline=1.53.0-SNAPSHOT~5dfc6f71bd
dateFormat X
axisFormat %s
section baseline
no_agent (36.763 ms) : 36468, 37058
. : milestone, 36763,
appsec (47.814 ms) : 47392, 48235
. : milestone, 47814,
code_origins (43.602 ms) : 43235, 43969
. : milestone, 43602,
iast (45.757 ms) : 45369, 46145
. : milestone, 45757,
profiling (49.773 ms) : 49306, 50241
. : milestone, 49773,
tracing (43.6 ms) : 43224, 43976
. : milestone, 43600,
section candidate
no_agent (37.246 ms) : 36952, 37541
. : milestone, 37246,
appsec (45.808 ms) : 45414, 46203
. : milestone, 45808,
code_origins (45.549 ms) : 45159, 45938
. : milestone, 45549,
iast (45.361 ms) : 44965, 45756
. : milestone, 45361,
profiling (46.895 ms) : 46464, 47327
. : milestone, 46895,
tracing (43.382 ms) : 43019, 43744
. : milestone, 43382,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~b07d7eec01, baseline=1.53.0-SNAPSHOT~5dfc6f71bd
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (3.647 ms) : 3431, 3862
. : milestone, 3647,
iast (2.186 ms) : 2123, 2248
. : milestone, 2186,
iast_GLOBAL (2.224 ms) : 2162, 2287
. : milestone, 2224,
profiling (2.471 ms) : 2302, 2641
. : milestone, 2471,
tracing (2.016 ms) : 1967, 2064
. : milestone, 2016,
section candidate
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (3.622 ms) : 3405, 3839
. : milestone, 3622,
iast (2.193 ms) : 2131, 2256
. : milestone, 2193,
iast_GLOBAL (2.23 ms) : 2167, 2293
. : milestone, 2230,
profiling (2.043 ms) : 1992, 2094
. : milestone, 2043,
tracing (2.012 ms) : 1963, 2060
. : milestone, 2012,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~b07d7eec01, baseline=1.53.0-SNAPSHOT~5dfc6f71bd
dateFormat X
axisFormat %s
section baseline
no_agent (15.533 s) : 15533000, 15533000
. : milestone, 15533000,
appsec (15.042 s) : 15042000, 15042000
. : milestone, 15042000,
iast (18.267 s) : 18267000, 18267000
. : milestone, 18267000,
iast_GLOBAL (18.225 s) : 18225000, 18225000
. : milestone, 18225000,
profiling (15.547 s) : 15547000, 15547000
. : milestone, 15547000,
tracing (15.225 s) : 15225000, 15225000
. : milestone, 15225000,
section candidate
no_agent (15.275 s) : 15275000, 15275000
. : milestone, 15275000,
appsec (14.738 s) : 14738000, 14738000
. : milestone, 14738000,
iast (18.711 s) : 18711000, 18711000
. : milestone, 18711000,
iast_GLOBAL (17.818 s) : 17818000, 17818000
. : milestone, 17818000,
profiling (15.085 s) : 15085000, 15085000
. : milestone, 15085000,
tracing (15.04 s) : 15040000, 15040000
. : milestone, 15040000,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intrumenting OpenLineage listener from within DataDogListener is broken and results in jobs hanging.
Example haning job can be investigated here. Spark driver logs mention:
Hipothesis: OpenLineage listener hangs bcz of not being configured properly: possibly bcz if misconfigured transport.
Why?
OpenLineageInstrumentationtracer applies method advice on constructor and putsconfontoInstanceStoreconfbut this is not reflected in configuration used by OpenLineage.Verification
To vefify this, I've created a locally built OpenLineage jar with defensive copy mechanism disabled (simply removed
.clone()call). Then:This PR contains a workaround for this as it captures
conffrom private field ofOpenLineageListener. The missing part is to verify the java tracer PR with Mortar...