Refactor System.getenv to providers.environmentVariable.#9538
Merged
Conversation
sarahchen6
approved these changes
Sep 15, 2025
Contributor
|
🎯 Code Coverage 🔗 Commit SHA: 2a19eb0 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~2a19eb0391, baseline=1.54.0-SNAPSHOT~5422517873
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1065525
Total [baseline] (10.733 s) : 0, 10732523
Agent [candidate] (1.063 s) : 0, 1063100
Total [candidate] (10.806 s) : 0, 10806069
section appsec
Agent [baseline] (1.245 s) : 0, 1244710
Total [baseline] (11.044 s) : 0, 11044433
Agent [candidate] (1.233 s) : 0, 1232669
Total [candidate] (11.032 s) : 0, 11032035
section iast
Agent [baseline] (1.189 s) : 0, 1188520
Total [baseline] (11.137 s) : 0, 11136837
Agent [candidate] (1.19 s) : 0, 1189752
Total [candidate] (11.085 s) : 0, 11084996
section profiling
Agent [baseline] (1.212 s) : 0, 1212191
Total [baseline] (10.969 s) : 0, 10968593
Agent [candidate] (1.209 s) : 0, 1208574
Total [candidate] (11.023 s) : 0, 11023386
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~2a19eb0391, baseline=1.54.0-SNAPSHOT~5422517873
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (735.184 ms) : 0, 735184
BytebuddyAgent [candidate] (733.538 ms) : 0, 733538
GlobalTracer [baseline] (254.192 ms) : 0, 254192
GlobalTracer [candidate] (253.098 ms) : 0, 253098
AppSec [baseline] (30.846 ms) : 0, 30846
AppSec [candidate] (30.569 ms) : 0, 30569
Debugger [baseline] (6.419 ms) : 0, 6419
Debugger [candidate] (6.402 ms) : 0, 6402
Remote Config [baseline] (707.798 µs) : 0, 708
Remote Config [candidate] (708.977 µs) : 0, 709
Telemetry [baseline] (15.511 ms) : 0, 15511
Telemetry [candidate] (16.144 ms) : 0, 16144
section appsec
crashtracking [baseline] (1.472 ms) : 0, 1472
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (762.619 ms) : 0, 762619
BytebuddyAgent [candidate] (754.538 ms) : 0, 754538
GlobalTracer [baseline] (247.724 ms) : 0, 247724
GlobalTracer [candidate] (245.068 ms) : 0, 245068
AppSec [baseline] (172.434 ms) : 0, 172434
AppSec [candidate] (171.491 ms) : 0, 171491
Debugger [baseline] (5.993 ms) : 0, 5993
Debugger [candidate] (6.007 ms) : 0, 6007
Remote Config [baseline] (613.569 µs) : 0, 614
Remote Config [candidate] (648.053 µs) : 0, 648
Telemetry [baseline] (8.554 ms) : 0, 8554
Telemetry [candidate] (8.51 ms) : 0, 8510
IAST [baseline] (23.971 ms) : 0, 23971
IAST [candidate] (23.81 ms) : 0, 23810
section iast
crashtracking [baseline] (1.451 ms) : 0, 1451
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (850.5 ms) : 0, 850500
BytebuddyAgent [candidate] (850.754 ms) : 0, 850754
GlobalTracer [baseline] (247.852 ms) : 0, 247852
GlobalTracer [candidate] (243.435 ms) : 0, 243435
AppSec [baseline] (25.605 ms) : 0, 25605
AppSec [candidate] (29.595 ms) : 0, 29595
Debugger [baseline] (6.119 ms) : 0, 6119
Debugger [candidate] (6.065 ms) : 0, 6065
Remote Config [baseline] (588.886 µs) : 0, 589
Remote Config [candidate] (612.116 µs) : 0, 612
Telemetry [baseline] (8.215 ms) : 0, 8215
Telemetry [candidate] (9.245 ms) : 0, 9245
IAST [baseline] (27.168 ms) : 0, 27168
IAST [candidate] (27.46 ms) : 0, 27460
section profiling
ProfilingAgent [baseline] (107.381 ms) : 0, 107381
ProfilingAgent [candidate] (107.979 ms) : 0, 107979
crashtracking [baseline] (1.445 ms) : 0, 1445
crashtracking [candidate] (1.444 ms) : 0, 1444
BytebuddyAgent [baseline] (764.027 ms) : 0, 764027
BytebuddyAgent [candidate] (761.16 ms) : 0, 761160
GlobalTracer [baseline] (233.544 ms) : 0, 233544
GlobalTracer [candidate] (232.684 ms) : 0, 232684
AppSec [baseline] (30.547 ms) : 0, 30547
AppSec [candidate] (31.694 ms) : 0, 31694
Debugger [baseline] (12.895 ms) : 0, 12895
Debugger [candidate] (12.222 ms) : 0, 12222
Remote Config [baseline] (1.583 ms) : 0, 1583
Remote Config [candidate] (1.56 ms) : 0, 1560
Telemetry [baseline] (9.35 ms) : 0, 9350
Telemetry [candidate] (8.625 ms) : 0, 8625
Profiling [baseline] (108.006 ms) : 0, 108006
Profiling [candidate] (108.663 ms) : 0, 108663
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~2a19eb0391, baseline=1.54.0-SNAPSHOT~5422517873
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1062144
Total [baseline] (8.638 s) : 0, 8637883
Agent [candidate] (1.067 s) : 0, 1066976
Total [candidate] (8.64 s) : 0, 8639652
section iast
Agent [baseline] (1.2 s) : 0, 1199839
Total [baseline] (9.345 s) : 0, 9344803
Agent [candidate] (1.188 s) : 0, 1188195
Total [candidate] (9.317 s) : 0, 9317024
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~2a19eb0391, baseline=1.54.0-SNAPSHOT~5422517873
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (733.643 ms) : 0, 733643
BytebuddyAgent [candidate] (735.898 ms) : 0, 735898
GlobalTracer [baseline] (252.756 ms) : 0, 252756
GlobalTracer [candidate] (254.217 ms) : 0, 254217
AppSec [baseline] (30.47 ms) : 0, 30470
AppSec [candidate] (30.843 ms) : 0, 30843
Debugger [baseline] (6.4 ms) : 0, 6400
Debugger [candidate] (6.448 ms) : 0, 6448
Remote Config [baseline] (695.625 µs) : 0, 696
Remote Config [candidate] (693.7 µs) : 0, 694
Telemetry [baseline] (15.712 ms) : 0, 15712
Telemetry [candidate] (16.361 ms) : 0, 16361
section iast
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.471 ms) : 0, 1471
BytebuddyAgent [baseline] (859.483 ms) : 0, 859483
BytebuddyAgent [candidate] (850.667 ms) : 0, 850667
GlobalTracer [baseline] (246.239 ms) : 0, 246239
GlobalTracer [candidate] (245.411 ms) : 0, 245411
IAST [baseline] (30.697 ms) : 0, 30697
IAST [candidate] (28.699 ms) : 0, 28699
AppSec [baseline] (25.885 ms) : 0, 25885
AppSec [candidate] (26.204 ms) : 0, 26204
Debugger [baseline] (6.126 ms) : 0, 6126
Debugger [candidate] (6.033 ms) : 0, 6033
Remote Config [baseline] (602.75 µs) : 0, 603
Remote Config [candidate] (593.948 µs) : 0, 594
Telemetry [baseline] (8.213 ms) : 0, 8213
Telemetry [candidate] (8.122 ms) : 0, 8122
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 11 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~2a19eb0391, baseline=1.54.0-SNAPSHOT~5422517873
dateFormat X
axisFormat %s
section baseline
no_agent (36.952 ms) : 36651, 37252
. : milestone, 36952,
appsec (48.7 ms) : 48260, 49140
. : milestone, 48700,
code_origins (45.749 ms) : 45356, 46141
. : milestone, 45749,
iast (44.041 ms) : 43663, 44418
. : milestone, 44041,
profiling (48.397 ms) : 47953, 48840
. : milestone, 48397,
tracing (43.284 ms) : 42928, 43640
. : milestone, 43284,
section candidate
no_agent (37.309 ms) : 37011, 37607
. : milestone, 37309,
appsec (49.48 ms) : 49049, 49911
. : milestone, 49480,
code_origins (47.335 ms) : 46922, 47747
. : milestone, 47335,
iast (44.291 ms) : 43899, 44682
. : milestone, 44291,
profiling (49.043 ms) : 48591, 49494
. : milestone, 49043,
tracing (43.966 ms) : 43592, 44341
. : milestone, 43966,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~2a19eb0391, baseline=1.54.0-SNAPSHOT~5422517873
dateFormat X
axisFormat %s
section baseline
no_agent (4.368 ms) : 4311, 4424
. : milestone, 4368,
iast (9.741 ms) : 9577, 9905
. : milestone, 9741,
iast_FULL (14.364 ms) : 14078, 14649
. : milestone, 14364,
iast_GLOBAL (10.283 ms) : 10102, 10464
. : milestone, 10283,
profiling (8.51 ms) : 8377, 8643
. : milestone, 8510,
tracing (7.876 ms) : 7763, 7988
. : milestone, 7876,
section candidate
no_agent (4.315 ms) : 4265, 4366
. : milestone, 4315,
iast (9.442 ms) : 9289, 9596
. : milestone, 9442,
iast_FULL (14.239 ms) : 13957, 14521
. : milestone, 14239,
iast_GLOBAL (10.204 ms) : 10028, 10381
. : milestone, 10204,
profiling (8.681 ms) : 8538, 8824
. : milestone, 8681,
tracing (7.965 ms) : 7847, 8083
. : milestone, 7965,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~2a19eb0391, baseline=1.54.0-SNAPSHOT~5422517873
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (3.743 ms) : 3526, 3960
. : milestone, 3743,
iast (2.217 ms) : 2154, 2280
. : milestone, 2217,
iast_GLOBAL (2.254 ms) : 2191, 2317
. : milestone, 2254,
profiling (2.08 ms) : 2028, 2133
. : milestone, 2080,
tracing (2.039 ms) : 1990, 2089
. : milestone, 2039,
section candidate
no_agent (1.481 ms) : 1470, 1493
. : milestone, 1481,
appsec (3.733 ms) : 3518, 3949
. : milestone, 3733,
iast (2.213 ms) : 2149, 2276
. : milestone, 2213,
iast_GLOBAL (2.254 ms) : 2191, 2318
. : milestone, 2254,
profiling (2.084 ms) : 2031, 2137
. : milestone, 2084,
tracing (2.038 ms) : 1988, 2088
. : milestone, 2038,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~2a19eb0391, baseline=1.54.0-SNAPSHOT~5422517873
dateFormat X
axisFormat %s
section baseline
no_agent (15.025 s) : 15025000, 15025000
. : milestone, 15025000,
appsec (14.935 s) : 14935000, 14935000
. : milestone, 14935000,
iast (18.173 s) : 18173000, 18173000
. : milestone, 18173000,
iast_GLOBAL (17.536 s) : 17536000, 17536000
. : milestone, 17536000,
profiling (15.402 s) : 15402000, 15402000
. : milestone, 15402000,
tracing (15.096 s) : 15096000, 15096000
. : milestone, 15096000,
section candidate
no_agent (15.666 s) : 15666000, 15666000
. : milestone, 15666000,
appsec (15.013 s) : 15013000, 15013000
. : milestone, 15013000,
iast (19.086 s) : 19086000, 19086000
. : milestone, 19086000,
iast_GLOBAL (18.155 s) : 18155000, 18155000
. : milestone, 18155000,
profiling (15.327 s) : 15327000, 15327000
. : milestone, 15327000,
tracing (15.001 s) : 15001000, 15001000
. : milestone, 15001000,
|
amarziali
approved these changes
Sep 16, 2025
bric3
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Replaces direct calls to
System.getenvwithproviders.environmentVariable.Motivation
Aligns with idiomatic Gradle practices and improves maintainability.
Additional Notes
General cleanup and modernization of Gradle scripts by adopting the recommended provider-based approach.