Avoid to extract symbols for static final fields#9596
Closed
Avoid to extract symbols for static final fields#9596
Conversation
static final fields are not used in completion anyway and not captured by CapturedContext probes. So those symbols are useless.
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (316.372 µs) : 286, 347
. : milestone, 316,
basic (274.664 µs) : 268, 282
. : milestone, 275,
loop (8.945 ms) : 8941, 8949
. : milestone, 8945,
section candidate
noprobe (314.983 µs) : 291, 339
. : milestone, 315,
basic (279.62 µs) : 273, 286
. : milestone, 280,
loop (8.964 ms) : 8960, 8968
. : milestone, 8964,
|
Contributor
|
🎯 Code Coverage 🔗 Commit SHA: ab025f5 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 6 performance regressions! Performance is the same for 44 metrics, 9 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~ab025f5019, baseline=1.54.0-SNAPSHOT~6ee44ddde4
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.009 s) : 0, 1009040
Total [baseline] (10.751 s) : 0, 10751064
Agent [candidate] (1.02 s) : 0, 1019976
Total [candidate] (10.721 s) : 0, 10720595
section appsec
Agent [baseline] (1.185 s) : 0, 1185116
Total [baseline] (11.099 s) : 0, 11098571
Agent [candidate] (1.194 s) : 0, 1193654
Total [candidate] (10.879 s) : 0, 10879078
section iast
Agent [baseline] (1.145 s) : 0, 1145350
Total [baseline] (10.96 s) : 0, 10959517
Agent [candidate] (1.158 s) : 0, 1158151
Total [candidate] (11.038 s) : 0, 11037693
section profiling
Agent [baseline] (1.152 s) : 0, 1152245
Total [baseline] (11.044 s) : 0, 11044366
Agent [candidate] (1.164 s) : 0, 1163755
Total [candidate] (11.066 s) : 0, 11065518
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~ab025f5019, baseline=1.54.0-SNAPSHOT~6ee44ddde4
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.488 ms) : 0, 1488
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (689.885 ms) : 0, 689885
BytebuddyAgent [candidate] (687.913 ms) : 0, 687913
GlobalTracer [baseline] (248.74 ms) : 0, 248740
GlobalTracer [candidate] (258.06 ms) : 0, 258060
AppSec [baseline] (31.612 ms) : 0, 31612
AppSec [candidate] (31.679 ms) : 0, 31679
Debugger [baseline] (6.38 ms) : 0, 6380
Debugger [candidate] (6.362 ms) : 0, 6362
Remote Config [baseline] (701.772 µs) : 0, 702
Remote Config [candidate] (692.102 µs) : 0, 692
Telemetry [baseline] (9.029 ms) : 0, 9029
Telemetry [candidate] (12.728 ms) : 0, 12728
section appsec
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (710.357 ms) : 0, 710357
BytebuddyAgent [candidate] (708.951 ms) : 0, 708951
GlobalTracer [baseline] (239.584 ms) : 0, 239584
GlobalTracer [candidate] (249.448 ms) : 0, 249448
AppSec [baseline] (171.244 ms) : 0, 171244
AppSec [candidate] (170.99 ms) : 0, 170990
Debugger [baseline] (6.799 ms) : 0, 6799
Debugger [candidate] (6.051 ms) : 0, 6051
Remote Config [baseline] (643.516 µs) : 0, 644
Remote Config [candidate] (620.688 µs) : 0, 621
Telemetry [baseline] (9.074 ms) : 0, 9074
Telemetry [candidate] (10.048 ms) : 0, 10048
IAST [baseline] (24.809 ms) : 0, 24809
IAST [candidate] (24.986 ms) : 0, 24986
section iast
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.47 ms) : 0, 1470
BytebuddyAgent [baseline] (809.331 ms) : 0, 809331
BytebuddyAgent [candidate] (813.102 ms) : 0, 813102
GlobalTracer [baseline] (238.036 ms) : 0, 238036
GlobalTracer [candidate] (248.737 ms) : 0, 248737
AppSec [baseline] (33.787 ms) : 0, 33787
AppSec [candidate] (28.85 ms) : 0, 28850
Debugger [baseline] (6.109 ms) : 0, 6109
Debugger [candidate] (6.119 ms) : 0, 6119
Remote Config [baseline] (603.623 µs) : 0, 604
Remote Config [candidate] (595.13 µs) : 0, 595
Telemetry [baseline] (8.289 ms) : 0, 8289
Telemetry [candidate] (8.194 ms) : 0, 8194
IAST [baseline] (26.332 ms) : 0, 26332
IAST [candidate] (29.931 ms) : 0, 29931
section profiling
crashtracking [baseline] (1.44 ms) : 0, 1440
crashtracking [candidate] (1.438 ms) : 0, 1438
BytebuddyAgent [baseline] (719.619 ms) : 0, 719619
BytebuddyAgent [candidate] (719.978 ms) : 0, 719978
GlobalTracer [baseline] (223.791 ms) : 0, 223791
GlobalTracer [candidate] (234.44 ms) : 0, 234440
AppSec [baseline] (31.434 ms) : 0, 31434
AppSec [candidate] (31.1 ms) : 0, 31100
Debugger [baseline] (6.454 ms) : 0, 6454
Debugger [candidate] (6.469 ms) : 0, 6469
Remote Config [baseline] (689.013 µs) : 0, 689
Remote Config [candidate] (728.423 µs) : 0, 728
Telemetry [baseline] (16.165 ms) : 0, 16165
Telemetry [candidate] (16.806 ms) : 0, 16806
ProfilingAgent [baseline] (101.661 ms) : 0, 101661
ProfilingAgent [candidate] (101.685 ms) : 0, 101685
Profiling [baseline] (102.268 ms) : 0, 102268
Profiling [candidate] (102.285 ms) : 0, 102285
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~ab025f5019, baseline=1.54.0-SNAPSHOT~6ee44ddde4
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.007 s) : 0, 1006860
Total [baseline] (8.711 s) : 0, 8711231
Agent [candidate] (1.019 s) : 0, 1019390
Total [candidate] (8.665 s) : 0, 8664712
section iast
Agent [baseline] (1.144 s) : 0, 1144403
Total [baseline] (9.304 s) : 0, 9304087
Agent [candidate] (1.165 s) : 0, 1165447
Total [candidate] (9.336 s) : 0, 9335762
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~ab025f5019, baseline=1.54.0-SNAPSHOT~6ee44ddde4
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (688.895 ms) : 0, 688895
BytebuddyAgent [candidate] (686.719 ms) : 0, 686719
GlobalTracer [baseline] (248.197 ms) : 0, 248197
GlobalTracer [candidate] (258.03 ms) : 0, 258030
AppSec [baseline] (31.086 ms) : 0, 31086
AppSec [candidate] (31.708 ms) : 0, 31708
Debugger [baseline] (6.309 ms) : 0, 6309
Debugger [candidate] (6.359 ms) : 0, 6359
Remote Config [baseline] (696.292 µs) : 0, 696
Remote Config [candidate] (683.635 µs) : 0, 684
Telemetry [baseline] (9.046 ms) : 0, 9046
Telemetry [candidate] (13.416 ms) : 0, 13416
section iast
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.466 ms) : 0, 1466
BytebuddyAgent [baseline] (808.763 ms) : 0, 808763
BytebuddyAgent [candidate] (817.851 ms) : 0, 817851
GlobalTracer [baseline] (238.07 ms) : 0, 238070
GlobalTracer [candidate] (250.345 ms) : 0, 250345
AppSec [baseline] (33.771 ms) : 0, 33771
AppSec [candidate] (28.403 ms) : 0, 28403
Debugger [baseline] (6.225 ms) : 0, 6225
Debugger [candidate] (6.174 ms) : 0, 6174
Remote Config [baseline] (585.569 µs) : 0, 586
Remote Config [candidate] (602.002 µs) : 0, 602
Telemetry [baseline] (8.075 ms) : 0, 8075
Telemetry [candidate] (8.432 ms) : 0, 8432
IAST [baseline] (26.192 ms) : 0, 26192
IAST [candidate] (31.031 ms) : 0, 31031
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 3 performance regressions! Performance is the same for 6 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~ab025f5019, baseline=1.54.0-SNAPSHOT~6ee44ddde4
dateFormat X
axisFormat %s
section baseline
no_agent (37.499 ms) : 37204, 37794
. : milestone, 37499,
appsec (46.984 ms) : 46563, 47404
. : milestone, 46984,
code_origins (45.114 ms) : 44744, 45484
. : milestone, 45114,
iast (44.214 ms) : 43839, 44589
. : milestone, 44214,
profiling (49.086 ms) : 48620, 49552
. : milestone, 49086,
tracing (44.015 ms) : 43623, 44407
. : milestone, 44015,
section candidate
no_agent (37.381 ms) : 37074, 37688
. : milestone, 37381,
appsec (48.632 ms) : 48204, 49061
. : milestone, 48632,
code_origins (44.184 ms) : 43807, 44560
. : milestone, 44184,
iast (45.605 ms) : 45214, 45996
. : milestone, 45605,
profiling (47.493 ms) : 47064, 47922
. : milestone, 47493,
tracing (42.883 ms) : 42515, 43251
. : milestone, 42883,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~ab025f5019, baseline=1.54.0-SNAPSHOT~6ee44ddde4
dateFormat X
axisFormat %s
section baseline
no_agent (4.237 ms) : 4185, 4288
. : milestone, 4237,
iast (9.749 ms) : 9587, 9910
. : milestone, 9749,
iast_FULL (14.054 ms) : 13779, 14328
. : milestone, 14054,
iast_GLOBAL (11.118 ms) : 10918, 11319
. : milestone, 11118,
profiling (9.372 ms) : 9213, 9530
. : milestone, 9372,
tracing (7.509 ms) : 7397, 7621
. : milestone, 7509,
section candidate
no_agent (4.483 ms) : 4432, 4534
. : milestone, 4483,
iast (9.138 ms) : 8988, 9289
. : milestone, 9138,
iast_FULL (14.058 ms) : 13778, 14339
. : milestone, 14058,
iast_GLOBAL (11.092 ms) : 10893, 11291
. : milestone, 11092,
profiling (8.733 ms) : 8595, 8870
. : milestone, 8733,
tracing (7.698 ms) : 7575, 7822
. : milestone, 7698,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~ab025f5019, baseline=1.54.0-SNAPSHOT~6ee44ddde4
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.735 ms) : 3517, 3952
. : milestone, 3735,
iast (2.201 ms) : 2139, 2264
. : milestone, 2201,
iast_GLOBAL (2.238 ms) : 2175, 2300
. : milestone, 2238,
profiling (2.085 ms) : 2033, 2138
. : milestone, 2085,
tracing (2.031 ms) : 1982, 2080
. : milestone, 2031,
section candidate
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (3.65 ms) : 3436, 3865
. : milestone, 3650,
iast (2.203 ms) : 2140, 2266
. : milestone, 2203,
iast_GLOBAL (2.25 ms) : 2187, 2313
. : milestone, 2250,
profiling (2.051 ms) : 2000, 2101
. : milestone, 2051,
tracing (2.032 ms) : 1983, 2081
. : milestone, 2032,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~ab025f5019, baseline=1.54.0-SNAPSHOT~6ee44ddde4
dateFormat X
axisFormat %s
section baseline
no_agent (14.732 s) : 14732000, 14732000
. : milestone, 14732000,
appsec (14.931 s) : 14931000, 14931000
. : milestone, 14931000,
iast (18.55 s) : 18550000, 18550000
. : milestone, 18550000,
iast_GLOBAL (17.955 s) : 17955000, 17955000
. : milestone, 17955000,
profiling (15.972 s) : 15972000, 15972000
. : milestone, 15972000,
tracing (15.228 s) : 15228000, 15228000
. : milestone, 15228000,
section candidate
no_agent (15.608 s) : 15608000, 15608000
. : milestone, 15608000,
appsec (15.159 s) : 15159000, 15159000
. : milestone, 15159000,
iast (18.886 s) : 18886000, 18886000
. : milestone, 18886000,
iast_GLOBAL (18.156 s) : 18156000, 18156000
. : milestone, 18156000,
profiling (15.317 s) : 15317000, 15317000
. : milestone, 15317000,
tracing (14.975 s) : 14975000, 14975000
. : milestone, 14975000,
|
Member
Author
|
because static final fields could be used in Automatic commit Inference mechanism we will filter them on backend side |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
static final fields are not used in completion anyway and not captured by CapturedContext probes. So those symbols are useless.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: DEBUG-4488