Skip to content

Fix symbol extraction for interface static method #9597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpbempel merged 1 commit into from
Sep 23, 2025
Merged

Fix symbol extraction for interface static method #9597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/symbol/SymbolExtractor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,8 +237,10 @@ private static Collection<String> extractMethodModifiers(
"Invalid access modifiers method[" + methodNode.name + methodNode.desc + "]: " + bit);
}
}
// if class is an interface && method as code this is a default method
if ((classNode.access & Opcodes.ACC_INTERFACE) > 0 && methodNode.instructions.size() > 0) {
// if class is an interface && method has code && non-static this is a default method
if ((classNode.access & Opcodes.ACC_INTERFACE) > 0
&& methodNode.instructions.size() > 0
&& (methodNode.access & Opcodes.ACC_STATIC) == 0) {
results.add("default");
}
return results;
Expand Down
8 changes: 8 additions & 0 deletions ...t-debugger/src/test/java/com/datadog/debugger/symbol/SymbolExtractionTransformerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -829,6 +829,14 @@ public void symbolExtraction14() throws IOException, URISyntaxException {
null,
null,
Void.TYPE.getTypeName());
Scope m4MethodScope = i1ClassScope.getScopes().get(1);
assertLangSpecifics(
m4MethodScope.getLanguageSpecifics(),
asList("public", "static"),
null,
null,
null,
String.class.getTypeName());
Scope myEnumClassScope = symbolSinkMock.jarScopes.get(3).getScopes().get(0);
assertLangSpecifics(
myEnumClassScope.getLanguageSpecifics(),
Expand Down
3 changes: 3 additions & 0 deletions ...agent-debugger/src/test/resources/com/datadog/debugger/symboltest/SymbolExtraction14.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ private strictfp synchronized final String m2(String... strVarArgs) {

interface I1 {
default void m3(){}
static String m4(String arg){
return arg;
}
}

interface I2 {
Expand Down
Loading