chore(eslint): update eslint-plugin-unicorn to 72 (#9503)

Activate Node.js 18 compatible rules that remove redundant syntax and catch correctness issues.

1. Skip esbuild resolution for built-in modules without package paths.
2. Contain detached Cucumber finalizer rejections without changing the returned test promise.
3. Preserve datastream varint continuation bits at 0x80 boundaries.
4. Avoid buffering Electron traces when the trace channel has no subscribers.
5. Replace regex-based HTTP path splitting with a shared delimiter scan, reducing representative cost from 41.4 ns to 14.7 ns per call.

Author: BridgeAR

ci/test-optimization-validation/generated-files.js

@@ -132,7 +132,7 @@ function getMissingDirectories (root, directory) {
 function cleanupCreatedDirectories (root) {
   const outcome = { removed: 0, retained: 0 }
   const resolvedRoot = path.resolve(root)
-  const directories = [...createdGeneratedDirectories.entries()]
+  const directories = [...createdGeneratedDirectories]
     .filter(([directory]) => isPathInside(resolvedRoot, directory))
     .sort(([left], [right]) => right.length - left.length)
 

ci/test-optimization-validation/generated-test-contract.js

@@ -192,9 +192,7 @@ function getGeneratedTestContractError (framework) {
     if (!cleanupPaths.has(path.normalize(stepsFile))) {
       return 'must include the isolated Cucumber step definitions in cleanupPaths.'
     }
-  }
-
-  if (framework.framework === 'playwright') {
+  } else if (framework.framework === 'playwright') {
     const configPath = playwrightAdapter.getGeneratedConfigPath(strategy.testDirectory)
     const config = files.find(file => path.normalize(file.path) === path.normalize(configPath))
     if (config?.contentLines?.join('\n') !== playwrightAdapter.getGeneratedConfigContent()) {

ci/test-optimization-validation/manifest-scaffold.js

@@ -477,8 +477,7 @@ function buildGeneratedTestStrategy ({ framework, projectRoot, representative })
     const stepsFile = cucumber.getGeneratedStepsPath(testDirectory)
     files.push({ path: stepsFile, contentLines: cucumber.getGeneratedStepsContent().split('\n') })
     cleanupPaths.push(stepsFile)
-  }
-  if (framework === 'playwright') {
+  } else if (framework === 'playwright') {
     const configFile = playwright.getGeneratedConfigPath(testDirectory)
     files.push({ path: configFile, contentLines: playwright.getGeneratedConfigContent().split('\n') })
     cleanupPaths.push(configFile)

ci/test-optimization-validation/runner-command.js

@@ -211,7 +211,7 @@ function getRunnerArgs (framework, testFile, generated) {
  */
 function getRunnerEnv (framework) {
   return {
-    ...(framework.validation.environment || {}),
+    ...framework.validation.environment,
     ...(framework.framework === 'cucumber' ? { CUCUMBER_PUBLISH_QUIET: 'true' } : {}),
   }
 }

ci/test-optimization-validation/scenarios/basic-reporting.js

@@ -58,7 +58,7 @@ async function runBasicReporting ({ framework, out, options }) {
       selector,
       settingsLoadedFromCache: run.offline.inputs.settings?.status === 'loaded',
     }
-    evidence.foundationalReportingEstablished = evidence.foundationalReportingEstablished && selector.verified
+    evidence.foundationalReportingEstablished &&= selector.verified
 
     if (run.result.timedOut) {
       return inconclusive(

ci/test-optimization-validation/scenarios/test-management.js

@@ -149,7 +149,7 @@ function buildQuarantinedResponse (framework, scenario, discoveredIdentities = [
   for (const identity of identities) {
     for (const suite of getSuiteCandidates(identity, scenario)) {
       for (const name of getNameCandidates(identity)) {
-        suites[suite] = suites[suite] || { tests: {} }
+        suites[suite] ||= { tests: {} }
         suites[suite].tests[name] = {
           properties: {
             quarantined: true,
@@ -210,7 +210,7 @@ function summarizeManagedTests (testManagementTests) {
     }
     summary.set(displaySuite, testNames)
   }
-  return [...summary.entries()].slice(0, 5).map(([suite, tests]) => ({
+  return [...summary].slice(0, 5).map(([suite, tests]) => ({
     suite,
     tests: [...tests].slice(0, 5),
   }))

eslint.config.mjs

@@ -586,60 +586,57 @@ export default [
       ...eslintPluginUnicorn.configs.recommended.rules,
 
       // Overriding recommended unicorn rules.
-      // Rules not listed here are left at the `recommended` default. The v65→v68 bump
-      // turned ~130 rules on in `recommended`; the entries below are the ones that fire
-      // on our source and are intentionally kept off (counts are from the v68 run).
-      'unicorn/catch-error-name': ['off', { name: 'err' }], // Many errors
+      // Rules not listed here are left at the `recommended` default. The entries below
+      // document deliberate exceptions. Volume markers stay coarse so they do not drift:
+      // `few` is under ten sites, `many` is tens, `lots` is hundreds or more.
+      'unicorn/catch-error-name': ['off', { name: 'err' }], // lots
       'unicorn/expiring-todo-comments': 'off',
-      'unicorn/filename-case': ['off', { case: 'kebabCase' }], // Many errors
-      'unicorn/name-replacements': 'off', // Many errors | naming churn (split out of prevent-abbreviations)
-      'unicorn/prevent-abbreviations': 'off', // Many errors
+      'unicorn/filename-case': ['off', { case: 'kebabCase' }], // lots
+      'unicorn/name-replacements': 'off', // lots | naming churn (split out of prevent-abbreviations)
+      'unicorn/prevent-abbreviations': 'off', // Its replacements moved to name-replacements
 
       // These rules require a newer Node.js version than we support
       'unicorn/no-array-reverse': 'off', // Node.js 20
       'unicorn/no-array-sort': 'off', // Node.js 20
+      'unicorn/prefer-abort-signal-any': 'off', // Node.js 18.17
       'unicorn/prefer-dispose': 'off', // Explicit resource management (newer Node.js)
+      'unicorn/prefer-group-by': 'off', // Node.js 21
+      'unicorn/prefer-iterator-helpers': 'off', // Iterator helpers (Node.js 22)
       'unicorn/prefer-iterator-to-array': 'off', // Iterator helpers (Node.js 22)
       'unicorn/prefer-iterator-to-array-at-end': 'off', // Iterator helpers (Node.js 22)
-      'unicorn/prefer-promise-with-resolvers': 'off', // 6 errors | Promise.withResolvers (Node.js 22)
+      'unicorn/prefer-promise-try': 'off', // Promise.try (Node.js 24)
+      'unicorn/prefer-promise-with-resolvers': 'off', // few | Promise.withResolvers (Node.js 22)
+      'unicorn/prefer-set-methods': 'off', // Set methods (Node.js 22)
       'unicorn/prefer-temporal': 'off', // Temporal is not stable on supported Node.js
       'unicorn/prefer-uint8array-base64': 'off', // Uint8Array base64 (Node.js 22)
 
       // These rules could potentially be evaluated again at a much later point
-      'unicorn/class-reference-in-static-methods': 'off', // 6 errors
-      'unicorn/consistent-class-member-order': 'off', // 55 errors | ordering churn
-      'unicorn/consistent-conditional-object-spread': 'off', // 3 errors
-      'unicorn/consistent-optional-chaining': 'off', // 3 errors
+      'unicorn/class-reference-in-static-methods': 'off', // few
+      'unicorn/consistent-class-member-order': 'off', // many | ordering churn
+      'unicorn/consistent-conditional-object-spread': 'off', // few
       'unicorn/explicit-length-check': 'off', // Not a big advantage
       'unicorn/explicit-timer-delay': 'off', // Covered by our own timer lint rules
       'unicorn/no-array-callback-reference': 'off',
-      'unicorn/no-computed-property-existence-check': 'off', // 160 errors | needs an audit
-      'unicorn/no-declarations-before-early-exit': 'off', // 62 errors
-      'unicorn/no-duplicate-if-branches': 'off', // 1 error | may surface real bugs
-      'unicorn/no-duplicate-logical-operands': 'off', // 2 errors | may surface real bugs
-      'unicorn/no-error-property-assignment': 'off', // 6 errors
+      'unicorn/no-computed-property-existence-check': 'off', // lots | needs an audit
+      'unicorn/no-declarations-before-early-exit': 'off', // many
+      'unicorn/no-error-property-assignment': 'off', // few | all preserve upstream error metadata
       'unicorn/no-for-loop': 'off', // Activate if this is resolved https://github.com/sindresorhus/eslint-plugin-unicorn/issues/2664
-      'unicorn/no-incorrect-template-string-interpolation': 'off', // 3 errors | audit for real bugs first
-      'unicorn/no-invalid-argument-count': 'off', // 98 errors | high false-positive risk, worth a focused pass
-      'unicorn/no-loop-iterable-mutation': 'off', // 2 errors | may surface real bugs
-      'unicorn/no-nonstandard-builtin-properties': 'off', // 34 errors | needs an audit
+      'unicorn/no-nonstandard-builtin-properties': 'off', // many | needs an audit
       'unicorn/no-this-assignment': 'off', // This would need some further refactoring and the benefit is small
-      'unicorn/no-undeclared-class-members': 'off', // 272 errors | requires declaring every field
-      'unicorn/no-unreadable-array-destructuring': 'off', // 4 errors | not autofixable, needs manual rewrite
-      'unicorn/no-unreadable-for-of-expression': 'off', // 32 errors
-      'unicorn/no-unreadable-object-destructuring': 'off', // 57 errors
-      'unicorn/no-unsafe-string-replacement': 'off', // 6 errors
-      'unicorn/no-useless-recursion': 'off', // 2 errors
+      'unicorn/no-undeclared-class-members': 'off', // lots | requires declaring every field
+      'unicorn/no-unreadable-array-destructuring': 'off', // few | not autofixable, needs manual rewrite
+      'unicorn/no-unreadable-for-of-expression': 'off', // many
+      'unicorn/no-unreadable-object-destructuring': 'off', // many
+      'unicorn/no-unsafe-string-replacement': 'off', // many | replacement callbacks reduce readability
+      'unicorn/no-useless-recursion': 'off', // few | iterative rewrites add substantial nesting
       'unicorn/prefer-code-point': 'off', // Should be activated, but needs a refactor of some code
-      'unicorn/prefer-early-return': 'off', // 67 errors | tension with our positive-`if` style
-      'unicorn/prefer-hoisting-branch-code': 'off', // 2 errors | reshapes branch bodies
-      'unicorn/prefer-minimal-ternary': 'off', // 24 errors
-      'unicorn/prefer-number-is-safe-integer': 'off', // 17 errors
-      'unicorn/prefer-object-iterable-methods': 'off', // 56 errors
+      'unicorn/prefer-early-return': 'off', // many | tension with our positive-`if` style
+      'unicorn/prefer-number-is-safe-integer': 'off', // many
+      'unicorn/prefer-object-iterable-methods': 'off', // many
       'unicorn/prefer-queue-microtask': 'off', // process.nextTick semantics differ
-      'unicorn/prefer-smaller-scope': 'off', // 3 errors
-      'unicorn/prefer-split-limit': 'off', // 23 errors
-      'unicorn/require-array-sort-compare': 'off', // 8 errors | may surface real default-sort bugs
+      'unicorn/prefer-simple-condition-first': 'off', // lots | needs a short-circuit behavior audit
+      'unicorn/prefer-then-catch': 'off', // many | broadens rejection boundaries
+      'unicorn/require-array-sort-compare': 'off', // many | many intentional lexicographic sorts
 
       // The following rules should not be activated!
       'unicorn/consistent-boolean-name': 'off', // Would rename public API and config booleans
@@ -649,6 +646,8 @@ export default [
       'unicorn/no-array-splice': 'off', // toSpliced copies the whole array (perf)
       'unicorn/no-break-in-nested-loop': 'off', // Conflicts with our performance-oriented loops
       'unicorn/no-global-object-property-assignment': 'off', // We use globalThis[Symbol.for('dd-trace')]
+      'unicorn/no-negated-array-predicate': 'off', // Predicate inversion is harder to read and creates churn
+      'unicorn/no-negated-comparison': 'off', // Opposite comparisons do not preserve NaN handling
       'unicorn/no-nested-ternary': 'off', // Not really an issue in the code and the benefit is small
       'unicorn/no-new-array': 'off', // new Array is often used for performance reasons
       'unicorn/no-null': 'off', // We do not control external APIs and it is hard to differentiate these
@@ -659,47 +658,32 @@ export default [
       'unicorn/operator-assignment': 'off', // Covered by core operator-assignment
       'unicorn/prefer-array-last-methods': 'off', // Questionable benefit
       'unicorn/prefer-await': 'off', // We avoid async/await in production hot paths
+      'unicorn/prefer-dom-node-html-methods': 'off', // Browser compatibility and different serialization semantics
       'unicorn/prefer-event-target': 'off', // Benefit only outside of Node.js
       'unicorn/prefer-global-this': 'off', // Questionable benefit in Node.js alone
       'unicorn/prefer-includes-over-repeated-comparisons': 'off', // Bad for performance
       'unicorn/prefer-math-trunc': 'off', // Math.trunc is not a 1-to-1 replacement for most of our usage
+      'unicorn/prefer-minimal-ternary': 'off', // Conflicts with our restricted-syntax rule on require(cond ? a : b)
       'unicorn/prefer-module': 'off', // We use CJS
       'unicorn/prefer-node-protocol': 'off', // May not be used due to guardrails
       'unicorn/prefer-number-coercion': 'off', // Number() is not a 1-to-1 replacement for parseInt/parseFloat
       'unicorn/prefer-private-class-fields': 'off', // Many `_underscore` fields cross module boundaries
-      'unicorn/prefer-reflect-apply': 'off', // Questionable benefit and more than 500 matches
+      'unicorn/prefer-reflect-apply': 'off', // lots | questionable benefit
       'unicorn/prefer-short-arrow-method': 'off', // Method shorthand is intentional; arrow properties change `this`
+      'unicorn/prefer-split-limit': 'off', // A limit is slower than getSegment; the rest read every segment
       'unicorn/prefer-switch': 'off', // Questionable benefit
       'unicorn/prefer-top-level-await': 'off', // Only useful when using ESM
       'unicorn/prefer-unicode-code-point-escapes': 'off', // Replaces the dropped no-hex-escape; questionable benefit
       'unicorn/switch-case-braces': 'off', // Questionable benefit
 
-      // Safe to enable in a follow-up: autofixable and aligned with our style. Kept off
-      // here only to keep this version bump free of source churn (counts from the v68 run).
-      'unicorn/logical-assignment-operators': 'off', // 42 errors | matches our ??=/||= usage
-      'unicorn/no-confusing-array-splice': 'off', // 1 error
-      'unicorn/no-for-each': 'off', // 10 errors | we already prefer for-of in production
-      'unicorn/no-negated-array-predicate': 'off', // 2 errors
-      'unicorn/no-negated-comparison': 'off', // 1 error
-      'unicorn/no-subtraction-comparison': 'off', // 2 errors
-      'unicorn/no-unnecessary-boolean-comparison': 'off', // 6 errors
-      'unicorn/no-unnecessary-global-this': 'off', // 4 errors
-      'unicorn/no-unnecessary-splice': 'off', // 2 errors
-      'unicorn/no-useless-concat': 'off', // 4 errors
-      'unicorn/no-useless-continue': 'off', // 1 error
-      'unicorn/no-useless-delete-check': 'off', // 1 error
-      'unicorn/no-useless-fallback-in-spread': 'off', // 5 errors
-      'unicorn/no-useless-override': 'off', // 1 error
-      'unicorn/no-useless-template-literals': 'off', // 13 errors
-      'unicorn/prefer-array-from-map': 'off', // 6 errors
-      'unicorn/prefer-boolean-return': 'off', // 1 error
-      'unicorn/prefer-continue': 'off', // 52 errors
-      'unicorn/prefer-direct-iteration': 'off', // 5 errors
-      'unicorn/prefer-else-if': 'off', // 6 errors
-      'unicorn/prefer-global-number-constants': 'off', // 3 errors
-      'unicorn/prefer-logical-operator-over-ternary': 'off', // 3 errors
-      'unicorn/prefer-ternary': 'off', // 16 errors
-      'unicorn/prefer-unary-minus': 'off', // 1 error
+      // These remaining rules need focused rewrites before activation.
+      'unicorn/no-confusing-array-splice': 'off', // few
+      'unicorn/no-for-each': 'off', // many | we already prefer for-of in production
+      'unicorn/no-unnecessary-global-this': 'off', // few | explicit globals are clearer
+      'unicorn/no-useless-continue': 'off', // few
+      'unicorn/prefer-array-from-map': 'off', // few | loops avoid callback allocation
+      'unicorn/prefer-continue': 'off', // many
+      'unicorn/prefer-ternary': 'off', // many
     },
   },
   {

package.json

@@ -213,7 +213,7 @@
     "eslint-plugin-n": "^18.2.1",
     "eslint-plugin-promise": "^7.3.0",
     "eslint-plugin-sonarjs": "^4.2.0",
-    "eslint-plugin-unicorn": "^68.0.0",
+    "eslint-plugin-unicorn": "^72.0.0",
     "express": "^5.1.0",
     "glob": "^10.4.5",
     "globals": "^17.7.0",

packages/datadog-esbuild/index.js

@@ -265,10 +265,12 @@ ${build.initialOptions.banner.js}`
         }
       }
       // The file namespace is used when requiring files from disk in userland
+      if (extracted.pkg === null) return
+
       let pathToPackageJson
       try {
         // we can't use require.resolve('pkg/package.json') as ESM modules don't make the file available
-        pathToPackageJson = require.resolve(`${extracted.pkg}`, { paths: [args.resolveDir] })
+        pathToPackageJson = require.resolve(extracted.pkg, { paths: [args.resolveDir] })
         pathToPackageJson = extractPackageAndModulePath(pathToPackageJson).pkgJson
       } catch (err) {
         if (err.code === 'MODULE_NOT_FOUND') {
@@ -340,7 +342,7 @@ ${build.initialOptions.banner.js}`
 
       if (data.isESM) {
         if (args.path.endsWith(ESM_INTERCEPTED_SUFFIX)) {
-          args.path = args.path.slice(0, -1 * ESM_INTERCEPTED_SUFFIX.length)
+          args.path = args.path.slice(0, -ESM_INTERCEPTED_SUFFIX.length)
 
           if (data.internal) {
             args.path = args.path.slice(INTERNAL_ESM_INTERCEPTED_PREFIX.length)

packages/datadog-esbuild/src/utils.js

@@ -174,7 +174,7 @@ async function processModule ({ path, internal = false, context, excludeDefault
   for (const n of exportNames) {
     if (n === 'default' && excludeDefault) continue
 
-    if (isStarExportLine(n) === true) {
+    if (isStarExportLine(n)) {
       // export * from 'wherever'
       const [, modFile] = n.split('* from ')