test: drive install script and withVersions from the shared resolver

Both call sites now consume resolvePluginVersions, so the generated versions/
folders and the folders withVersions() iterates derive from one place and can no
longer drift. The generator caps its mkdir/writeFile fan-out through the
concurrency helper to avoid EMFILE.

The resolver fills every in-between major on its own, so the lodash, ws, and
mquery same-name externals that only re-stated their addHook ranges are dropped.
Two peer-dependency anchors are added in their place: @apollo/server pins graphql
so v5 does not resolve the 15.x that apollo-server v3 drags in, and knex installs
the @vscode/sqlite3 fork its 1.x dialect requires.

Author: BridgeAR

packages/dd-trace/test/plugins/externals.js

@@ -187,10 +187,6 @@ module.exports = {
       name: 'express',
       versions: ['>=4', '>=4.0.0 <4.3.0', '>=4.0.0 <5.0.0', '>=4.3.0 <5.0.0'],
     },
-    {
-      name: 'mquery',
-      versions: ['>=5.0.0'],
-    },
     {
       name: 'mongodb',
       versions: ['5', '>=6'],
@@ -316,6 +312,15 @@ module.exports = {
       versions: ['^16.6.0'],
     },
   ],
+  '@apollo/server': [
+    {
+      // The shared apollo-server-* install also brings in graphql 15.x (for apollo-server v3), which yarn may
+      // hoist over the ^16.11 that @apollo/server v5 needs. Without the pin, v5 resolves 15.x, whose TypeInfo
+      // lacks the `.enter`/`.leave` methods the graphql instrumentation calls, so every traced operation throws.
+      name: 'graphql',
+      dep: true,
+    },
+  ],
   grpc: [
     {
       name: '@grpc/proto-loader',
@@ -339,6 +344,14 @@ module.exports = {
       name: 'sqlite3',
       versions: ['^5.0.8'],
     },
+    {
+      // knex 1.x is the only major whose sqlite3 dialect requires the @vscode/sqlite3 fork instead of `sqlite3`
+      // (reverted in 2.x). The instrumentation spec loads knex from `versions/knex@<ver>` and opens a sqlite3
+      // client, so the fork must be installed there. Pin an exact prerelease build so prebuilt binaries exist for
+      // the whole Node CI matrix.
+      name: '@vscode/sqlite3',
+      versions: ['5.1.12-vscode'],
+    },
     {
       name: 'pg',
       versions: [
@@ -424,12 +437,6 @@ module.exports = {
       versions: ['>=3'],
     },
   ],
-  lodash: [
-    {
-      name: 'lodash',
-      versions: ['>=4'],
-    },
-  ],
   mariadb: [
     {
       name: 'mariadb',
@@ -653,10 +660,4 @@ module.exports = {
       versions: ['1.20.1'],
     },
   ],
-  ws: [
-    {
-      name: 'ws',
-      versions: ['>=8.0.0'],
-    },
-  ],
 }

packages/dd-trace/test/plugins/versions/package.json

@@ -89,6 +89,7 @@
     "@vitest/coverage-istanbul": "4.1.9",
     "@vitest/coverage-v8": "4.1.9",
     "@vitest/runner": "4.1.9",
+    "@vscode/sqlite3": "5.1.12-vscode",
     "aerospike": "6.7.0",
     "ai": "6.0.204",
     "amqp10": "3.6.0",

packages/dd-trace/test/setup/mocha.js

@@ -14,6 +14,7 @@ const sinon = require('sinon')
 require('./core')
 
 const externals = require('../plugins/externals')
+const { resolvePluginVersions } = require('../plugins/versions')
 const runtimeMetrics = require('../../src/runtime_metrics')
 const Nomenclature = require('../../src/service-naming')
 const { SVC_SRC_KEY } = require('../../src/constants')
@@ -283,20 +284,17 @@ function withVersions (plugin, modules, range, cb) {
 
       // Some entries coming from `externals.js` are dependency-only (e.g. `dep: true`) and don't have `versions`.
       // Treat those as "not a test target" instead of crashing.
-      const versions = process.env.PACKAGE_VERSION_RANGE
-        ? [process.env.PACKAGE_VERSION_RANGE]
-        : normalizeVersions(instrumentation.versions)
-
-      for (const version of versions) {
-        if (process.env.RANGE && !semver.subset(version, process.env.RANGE)) continue
-        if (version !== '*') {
-          const min = semver.coerce(version)?.version
-          if (!min) throw new Error(`Invalid version: ${version}`)
-          testVersions.set(min, { versionRange: version, versionKey: min, resolvedVersion: min })
-        }
-
-        const max = require(getModulePath(moduleName, version)).version()
-        testVersions.set(max, { versionRange: version, versionKey: version, resolvedVersion: max })
+      // Share the install script's resolution so the tested folders exactly match the installed ones (lowest supported
+      // version, the latest of every major in between, and the newest supported version), de-duplicated by version.
+      const { versionList } = resolvePluginVersions({
+        name: moduleName,
+        declaredVersions: normalizeVersions(instrumentation.versions),
+      })
+
+      for (const { versionKey, range: declaredRange } of versionList) {
+        // Exact keys resolve to themselves; range keys (`*`, `>=2`, `>=3.0.0 <4.0.0`) resolve to what was installed.
+        const resolvedVersion = semver.valid(versionKey) ?? require(getModulePath(moduleName, versionKey)).version()
+        testVersions.set(resolvedVersion, { versionRange: declaredRange, versionKey, resolvedVersion })
       }
     }