fix(openfeature): use canonical feature flags kill switch

Author: leoromanovsky

integration-tests/openfeature/openfeature-agentless.spec.js

@@ -86,7 +86,7 @@ describe('OpenFeature agentless configuration integration', () => {
       cwd,
       env: {
         DD_API_KEY: 'integration-api-key',
-        DD_FEATURE_FLAGGING_PROVIDER_ENABLED: 'true',
+        DD_FEATURE_FLAGS_ENABLED: 'true',
         DD_FEATURE_FLAGS_CONFIGURATION_SOURCE_AGENTLESS_BASE_URL: backendUrl,
         DD_FEATURE_FLAGS_CONFIGURATION_SOURCE_AGENTLESS_POLL_INTERVAL_SECONDS: '5',
         DD_FEATURE_FLAGS_CONFIGURATION_SOURCE_AGENTLESS_REQUEST_TIMEOUT_SECONDS: '1',

integration-tests/openfeature/openfeature-exposure-events.spec.js

@@ -60,7 +60,7 @@ describe('OpenFeature Remote Config and Exposure Events Integration', () => {
           env: {
             DD_TRACE_AGENT_PORT: agent.port,
             DD_REMOTE_CONFIG_POLL_INTERVAL_SECONDS: '0.1',
-            DD_FEATURE_FLAGGING_PROVIDER_ENABLED: 'true',
+            DD_FEATURE_FLAGS_ENABLED: 'true',
             // Preserve the existing RC exposure path until agentless emission is supported.
             DD_FEATURE_FLAGS_CONFIGURATION_SOURCE: 'remote_config',
           },
@@ -161,7 +161,7 @@ describe('OpenFeature Remote Config and Exposure Events Integration', () => {
           env: {
             DD_TRACE_AGENT_PORT: agent.port,
             DD_REMOTE_CONFIG_POLL_INTERVAL_SECONDS: '0.1',
-            DD_FEATURE_FLAGGING_PROVIDER_ENABLED: 'true',
+            DD_FEATURE_FLAGS_ENABLED: 'true',
             DD_FEATURE_FLAGS_CONFIGURATION_SOURCE: 'remote_config',
           },
         })
@@ -245,7 +245,7 @@ describe('OpenFeature Remote Config and Exposure Events Integration', () => {
         env: {
           DD_TRACE_AGENT_PORT: agent.port,
           DD_REMOTE_CONFIG_POLL_INTERVAL_SECONDS: '0.1',
-          DD_FEATURE_FLAGGING_PROVIDER_ENABLED: 'true',
+          DD_FEATURE_FLAGS_ENABLED: 'true',
           DD_FEATURE_FLAGS_CONFIGURATION_SOURCE: 'remote_config',
         },
       })
@@ -307,7 +307,7 @@ describe('OpenFeature Remote Config and Exposure Events Integration', () => {
         cwd,
         env: {
           DD_TRACE_AGENT_PORT: agent.port,
-          DD_FEATURE_FLAGGING_PROVIDER_ENABLED: 'false',
+          DD_FEATURE_FLAGS_ENABLED: 'false',
         },
       })
     })

packages/dd-trace/src/config/generated-config-types.d.ts

@@ -83,11 +83,11 @@ export interface GeneratedConfig {
   DD_EXPERIMENTAL_TEST_OPT_VITEST_NO_WORKER_INIT: boolean | undefined;
   DD_EXPERIMENTAL_TEST_REQUESTS_FS_CACHE: boolean;
   DD_EXTERNAL_ENV: string | undefined;
-  DD_FEATURE_FLAGGING_PROVIDER_ENABLED: boolean;
   DD_FEATURE_FLAGS_CONFIGURATION_SOURCE: string;
   DD_FEATURE_FLAGS_CONFIGURATION_SOURCE_AGENTLESS_BASE_URL: string | undefined;
   DD_FEATURE_FLAGS_CONFIGURATION_SOURCE_AGENTLESS_POLL_INTERVAL_SECONDS: number;
   DD_FEATURE_FLAGS_CONFIGURATION_SOURCE_AGENTLESS_REQUEST_TIMEOUT_SECONDS: number;
+  DD_FEATURE_FLAGS_ENABLED: boolean;
   DD_GIT_BRANCH: string | undefined;
   DD_GIT_COMMIT_AUTHOR_DATE: string | undefined;
   DD_GIT_COMMIT_AUTHOR_EMAIL: string | undefined;
@@ -693,11 +693,11 @@ export interface GeneratedEnvVarConfig {
   DD_EXPERIMENTAL_TEST_OPT_VITEST_NO_WORKER_INIT: boolean | undefined;
   DD_EXPERIMENTAL_TEST_REQUESTS_FS_CACHE: boolean;
   DD_EXTERNAL_ENV: string | undefined;
-  DD_FEATURE_FLAGGING_PROVIDER_ENABLED: boolean;
   DD_FEATURE_FLAGS_CONFIGURATION_SOURCE: string;
   DD_FEATURE_FLAGS_CONFIGURATION_SOURCE_AGENTLESS_BASE_URL: string | undefined;
   DD_FEATURE_FLAGS_CONFIGURATION_SOURCE_AGENTLESS_POLL_INTERVAL_SECONDS: number;
   DD_FEATURE_FLAGS_CONFIGURATION_SOURCE_AGENTLESS_REQUEST_TIMEOUT_SECONDS: number;
+  DD_FEATURE_FLAGS_ENABLED: boolean;
   DD_GIT_BRANCH: string | undefined;
   DD_GIT_COMMIT_AUTHOR_DATE: string | undefined;
   DD_GIT_COMMIT_AUTHOR_EMAIL: string | undefined;

packages/dd-trace/src/config/supported-configurations.json

@@ -817,7 +817,7 @@
         "default": "false"
       }
     ],
-    "DD_FEATURE_FLAGGING_PROVIDER_ENABLED": [
+    "DD_FEATURE_FLAGS_ENABLED": [
       {
         "implementation": "A",
         "type": "boolean",

packages/dd-trace/src/openfeature/configuration_source.js

@@ -112,7 +112,7 @@ function isEnabled (config) {
  * @returns {string} Selected configuration-source mode.
  */
 function resolveMode (config) {
-  if (config.DD_FEATURE_FLAGGING_PROVIDER_ENABLED === false) return CONFIGURATION_SOURCE_DISABLED
+  if (config.DD_FEATURE_FLAGS_ENABLED === false) return CONFIGURATION_SOURCE_DISABLED
 
   const value = config.DD_FEATURE_FLAGS_CONFIGURATION_SOURCE
   const origin = config.getOrigin?.('DD_FEATURE_FLAGS_CONFIGURATION_SOURCE')

packages/dd-trace/test/config/index.spec.js

@@ -4943,7 +4943,7 @@ rules:
       const config = getConfig()
 
       assertObjectContains(config, {
-        DD_FEATURE_FLAGGING_PROVIDER_ENABLED: true,
+        DD_FEATURE_FLAGS_ENABLED: true,
         DD_FEATURE_FLAGS_CONFIGURATION_SOURCE: 'agentless',
         DD_FEATURE_FLAGS_CONFIGURATION_SOURCE_AGENTLESS_BASE_URL: undefined,
         DD_FEATURE_FLAGS_CONFIGURATION_SOURCE_AGENTLESS_POLL_INTERVAL_SECONDS: 30,
@@ -4953,11 +4953,11 @@ rules:
     })
 
     it('reads the stable provider kill switch', () => {
-      process.env.DD_FEATURE_FLAGGING_PROVIDER_ENABLED = 'false'
+      process.env.DD_FEATURE_FLAGS_ENABLED = 'false'
 
       const config = getConfig()
 
-      assert.strictEqual(config.DD_FEATURE_FLAGGING_PROVIDER_ENABLED, false)
+      assert.strictEqual(config.DD_FEATURE_FLAGS_ENABLED, false)
     })
 
     for (const value of ['true', 'false']) {
@@ -4966,7 +4966,7 @@ rules:
 
         const config = getConfig()
 
-        assert.strictEqual(config.DD_FEATURE_FLAGGING_PROVIDER_ENABLED, true)
+        assert.strictEqual(config.DD_FEATURE_FLAGS_ENABLED, true)
         assert.strictEqual(config.experimental.flaggingProvider.enabled, value === 'true')
       })
     }

packages/dd-trace/test/openfeature/configuration_source.spec.js

@@ -16,7 +16,7 @@ describe('OpenFeature configuration source', () => {
   beforeEach(() => {
     config = {
       DD_API_KEY: 'test-api-key',
-      DD_FEATURE_FLAGGING_PROVIDER_ENABLED: true,
+      DD_FEATURE_FLAGS_ENABLED: true,
       DD_FEATURE_FLAGS_CONFIGURATION_SOURCE: 'agentless',
       DD_FEATURE_FLAGS_CONFIGURATION_SOURCE_AGENTLESS_BASE_URL: undefined,
       DD_FEATURE_FLAGS_CONFIGURATION_SOURCE_AGENTLESS_POLL_INTERVAL_SECONDS: 30,
@@ -88,7 +88,7 @@ describe('OpenFeature configuration source', () => {
   })
 
   it('lets the stable kill switch override every configuration source', () => {
-    config.DD_FEATURE_FLAGGING_PROVIDER_ENABLED = false
+    config.DD_FEATURE_FLAGS_ENABLED = false
     config.DD_FEATURE_FLAGS_CONFIGURATION_SOURCE = 'remote_config'
     config.experimental.flaggingProvider.enabled = true
     config.getOrigin.returns('env_var')