fix: [OTLP] detect http/https protocol from parsedUrl.protocol#9028
fix: [OTLP] detect http/https protocol from parsedUrl.protocol#9028ida613 wants to merge 4 commits into
Conversation
Overall package sizeSelf size: 6.31 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.2.0 | 104.26 kB | 843.44 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
|
BenchmarksBenchmark execution time: 2026-06-23 20:46:22 Comparing candidate commit 6d0218f in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1952 metrics, 13 unstable metrics.
|
| this.options.hostname = parsedUrl.hostname | ||
| this.options.port = parsedUrl.port | ||
| this.options.path = parsedUrl.pathname + parsedUrl.search | ||
| this.#transport = parsedUrl.protocol === 'http:' ? http : https |
There was a problem hiding this comment.
Mind also updating the telemetryTags while being on it? :)
| this.#transport = parsedUrl.protocol === 'http:' ? http : https | |
| this.#transport = parsedUrl.protocol === 'http:' ? http : https | |
| if (this.telemetryTags !== undefined) { | |
| this.telemetryTags[0] = `protocol:${this.#transport === https ? 'https' : 'http'}` | |
| } |
What does this PR do?
As title, ensures https payloads are encrypted
Motivation
Additional Notes