refactor(profiling): make profiling exporter fields private#9043
Merged
szegedi merged 1 commit intoJun 24, 2026
Merged
Conversation
The EventSerializer, AgentExporter, and FileExporter state is read only inside each class, so promote it to #private and let the runtime enforce the boundary instead of the underscore convention. AgentExporter._url stays a plain underscore property: the profiling config spec asserts the resolved intake URL through config.exporters[0]._url, so the field is part of a reachable surface rather than purely internal.
Contributor
Overall package sizeSelf size: 6.31 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.2.0 | 104.26 kB | 843.44 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
|
BenchmarksBenchmark execution time: 2026-06-23 20:00:18 Comparing candidate commit 89c7073 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1953 metrics, 12 unstable metrics.
|
szegedi
approved these changes
Jun 24, 2026
szegedi
deleted the
BridgeAR/2026-06-23-profiling-exporter-private-fields
branch
dd-octo-sts Bot
pushed a commit
that referenced
this pull request
Jun 25, 2026
The EventSerializer, AgentExporter, and FileExporter state is read only inside each class, so promote it to #private and let the runtime enforce the boundary instead of the underscore convention. AgentExporter._url stays a plain underscore property: the profiling config spec asserts the resolved intake URL through config.exporters[0]._url, so the field is part of a reachable surface rather than purely internal.
pabloerhard
pushed a commit
that referenced
this pull request
Jun 26, 2026
The EventSerializer, AgentExporter, and FileExporter state is read only inside each class, so promote it to #private and let the runtime enforce the boundary instead of the underscore convention. AgentExporter._url stays a plain underscore property: the profiling config spec asserts the resolved intake URL through config.exporters[0]._url, so the field is part of a reachable surface rather than purely internal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
EventSerializer,AgentExporter, andFileExporterstate is read only inside each class, yet stayed underscore-prefixed. Promote it to#privateso the runtime enforces the boundary instead of the convention.AgentExporter._urlstays a plain underscore property: the profiling config spec asserts the resolved intake URL throughconfig.exporters[0]._url, so it is part of a reachable surface rather than purely internal.Test plan
packages/dd-trace/test/profiling/**/*.spec.js