Skip to content

test(integration): extend loader-hang workaround to Node 22.0.0 #9422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tlhunter wants to merge 1 commit into from
Closed

test(integration): extend loader-hang workaround to Node 22.0.0 #9422

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions integration-tests/init.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,9 +278,12 @@ describe('init.js', () => {
// or on 18.0.0 in particular.
if (semver.satisfies(process.versions.node, '>=14.13.1')) {
describe('initialize.mjs', () => {
// Node 20.0.0 can leave short-lived loader-based children alive after they
// print the expected output, so terminate them after a short grace period.
setShouldKill(process.versions.node === '20.0.0')
// Node 20.0.0 and 22.0.0 can leave short-lived loader-based children alive after they
// print the expected output, so terminate them after a short grace period. Both are the
// first release of their major line to ship `module.register`'s off-thread hooks worker,
// which had known bugs around `process.exit()` not tearing down the hooks thread
// (e.g. nodejs/node#52706, #53097, #53182) that were fixed in later patch releases.
setShouldKill(['20.0.0', '22.0.0'].includes(process.versions.node))
useSandbox()
stubTracerIfNeeded()

Expand Down
Loading